From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F16E28725F for ; Sat, 7 Feb 2026 22:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770503483; cv=none; b=YnsqHzYBn1VulpT90jIghspRuBEhRIVw3XvO8j4BnqDadX1k8HgXYdZF6Gj/7+W7fvjjZcl7QxDHFLcEtx98MAWZBGD1yQ5w/pn/klJE5GovBXIsFgnlifly32LbKlC2wPgZuPvXeesDcoSyVUbSWch+czrFYSvagFukonFjaeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770503483; c=relaxed/simple; bh=3XyvSOP6kFVR1xaLqBiGN0oHnixD21SKCZKLJrvMIzA=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=mPvgBVLdeTGgUxKJD3qiu4DjdNTqD8Hvcr6/yeOkYnaI/Eo1x8hxRDL3VNFT/5zCxZ+0xgpCURrLRTHZqbi5TUhSkphuSzpwq4nN7r4kpsGLEo/YaOYoxIk7kTS9+pxjolRyZrVquDdK07hXkRYzjpiCEhGKB5Yv/ZlH3sXmgLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rk+utw5x; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rk+utw5x" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-404263bd58fso2634531fac.1 for ; Sat, 07 Feb 2026 14:31:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770503482; x=1771108282; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g3Zar8UvYGL2HDa4Uj3rH657Lt9+T552vCr1ZsJi0j4=; b=Rk+utw5xU1qBZW6eg2HRtvZibo0bN6M3Gnulwobn2PQzJLvsadrNVnZ0sVE8VAAHjW m0f1vxutT39mu57L3OnS61osH6gZubpIY/gXGg58QVU2M5/rKT4Sgkoizjc8g9a1faWr XKjwRCNg8LroNqC5Ir9zqEE55SYNCXcjnHRHMzMuLJtk7Cm6WVlptFFWQrRa5y4duvTO Qo7RvdapMh2nMHrf1/FegVI2O+tt3LbP5+ZWw/02Vwfgwy9MVRFUltA6LQWIw9G/rQ7c +VrOXe3r0Nl6ZGQ17KUA5FgPOu2Y0aR6BYah4wV2qVY6Blej9ifLmI8gFiP3MFEHhjQS r0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770503482; x=1771108282; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=g3Zar8UvYGL2HDa4Uj3rH657Lt9+T552vCr1ZsJi0j4=; b=HvyLHTHCFq5XUFeJfSxjCjuP9ZYdqbICh1krWOgUpll+hvjnk4zwOVU9JqOcc25Xis VhDw/SjcR+4bH93TWmI+pvabLqpN6RYfnnmOIZb8rtwuqiZEu50jzzPVinJ1bzIPkvFF bMuR4q9OW+L2uENVA6NCKA9ICezNJS1BeJDdTKavvbUWHwocC4KPzyKsbtf00o6wTjwD cXE8GSRzmkM37sneFT7fSvucIYphuBrKeyFOksp262w9jPsLzoFuEWuJZR2ySr6I2A3k Fi7GTBekDWM+pdkpyFGswdFH/+/7/faobmAZQ21hJy+0AxvPxR5uYC/aHeHr04vCP0gT O75A== X-Forwarded-Encrypted: i=1; AJvYcCWBDzglVbdOUvkSsC7AvumSyJ1r4YVwva8ptYcj3P/WqhSopVpB/CCdQzjka1W0wHEtnF8fcmPkPOz1crs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7AXhoYNrN/5qyfCeCh83FCo2csl1FoEyQQnFxt1CkaSb6RlzP 8+G2m/RBhkHOT0/TtuCwhVXMcS6JJpOddps2wc2e3iCK5wFXCIHUuWTv X-Gm-Gg: AZuq6aL2G1rWK/jVQRu2n+iVY+FDn++qbkofed+rGmsKuZ6+L/0DxUVJvSnZXfbsY0a rz8+1zmTcGG+bNF75pgrh56h/tQov9Wym8T/D+r5B1w7dWTUyOXtjiVY0A131kZeT8QW/Tg9aIA N77VH2MwNJ1KoJ75SGvo4dFegEtKq8WJL+EzEXxkGxODlFJD6gsirndIdmpBJlnPi1UZq8N9XfR 7cqUIEO3TuYv3b2hWDuFS2Fb5VIJ8ydXzvdTr0jFtEbw2Lwp4DLSAoWEMHMZ5CJi6P2q4mZi9HB OnaQzfHI6gcDOZHkO9tpGcuIoHLqIpsFfKKmrc/kmTA1RN4sQOpX74oGDiws4kiUe8axzFbgTDC BIkkjMMyguB63IaxRS2+FVrU1y4hJfqH5aEG+6qjUVPmDPhTtyIkEFR0qy95JobAw/YHjDZLPn3 T9JNZsm9oaaX2jvXFY8mnNxHRYcim6wnSMfODH3qVzDj6iOi7p8+QklFCZA+KJW2Aaq2I2W98LH ke4Z7++FfCWgQpTgBYanFaQ9gBr9K3fLuaxRo5XWUtFySVPpPO743NdRA== X-Received: by 2002:a05:6870:e2cf:b0:409:5e29:e899 with SMTP id 586e51a60fabf-40a96d4717dmr3784899fac.6.1770503482391; Sat, 07 Feb 2026 14:31:22 -0800 (PST) Received: from localhost ([2600:100d:b16d:c41f:3d7b:1f53:769e:a0fb]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40a996456d4sm4183236fac.13.2026.02.07.14.31.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 14:31:21 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 07 Feb 2026 16:31:18 -0600 Message-Id: From: "Ethan Tidmore" To: "Azamat Rakhim" , Cc: , , Subject: Re: [PATCH] staging: rtl8723bs: clean up checkpatch warnings in rtw_btcoex.c X-Mailer: aerc 0.21.0 References: <20260207210124.10094-1-azamatrakhim8@gmail.com> In-Reply-To: <20260207210124.10094-1-azamatrakhim8@gmail.com> On Sat Feb 7, 2026 at 3:01 PM CST, Azamat Rakhim wrote: > Remove unnecessary comparison to true and extra blank lines > to address checkpatch warnings. > > Signed-off-by: Azamat Rakhim > --- > drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/stagin= g/rtl8723bs/core/rtw_btcoex.c > index f4b19ef7b341..8c17ac994bbc 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c > +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c > @@ -11,7 +11,7 @@ > void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_sta= tus) > { > if ((media_status =3D=3D RT_MEDIA_CONNECT) > - && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true)) { > + && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE))) { > rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL); > } You fixed one checkpatch.pl error on this line, but left another one. Logical operators need to go at the end of the previous line not the beginning of it. So that'd be "if ((media_status =3D=3D RT_MEDIA_CONNECT) &&". > =20 > @@ -54,7 +54,6 @@ void rtw_btcoex_LPS_Enter(struct adapter *padapter) > struct pwrctrl_priv *pwrpriv; > u8 lps_val; > =20 > - > pwrpriv =3D adapter_to_pwrctl(padapter); > =20 > pwrpriv->bpower_saving =3D true; > @@ -66,7 +65,6 @@ void rtw_btcoex_LPS_Leave(struct adapter *padapter) > { > struct pwrctrl_priv *pwrpriv; > =20 > - > pwrpriv =3D adapter_to_pwrctl(padapter); > =20 > if (pwrpriv->pwr_mode !=3D PS_MODE_ACTIVE) { These whitespace fixes should be their own patch. Please keep one logical change per patch. Also, your subject line should say what you fixed not the tool you used to find it. Next time before sending patches off run "$ ./scripts/checkpatch.pl --strict " to find problems like this. Thanks, ET