From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B660336EE3 for ; Tue, 10 Feb 2026 07:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709140; cv=none; b=RbJn+vLwPQpjdVmjUIxor/C4BYMsEOBdWa92I85zaops2OL6bGN3qfIGFk6U0goOCqcGNtCbi4t2wtE7EmHXzZcg0bfgWlfIQV6ij+QAry2nRJSa7VucTJ/IEGQt6JJHtjLfeI/TcEtzlWOmZduWvZhE7FnVV5vw5b7GsJ/oyLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709140; c=relaxed/simple; bh=B0b3B0Qs5/qfPBaaRXW4KMtzJHv7uO/t40eDFJuptU4=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To: References:In-Reply-To; b=gXIqVSECneP+AuGQwayzyMk+m2PIclQjiE3o7PTRr6fReVbS6rkSuBzRkRpwGfR6PIpBLN/wSL2uiJH68b400Z5NZU5zyFKmY4SYzrtUjjk0quOu7L1YgyeQAJniwbxm0QZCAlmsnhZEAP58SRK6vpL2IZtA/g03l9rL2SUupg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vFrVT8Et; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vFrVT8Et" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3ED1C19421; Tue, 10 Feb 2026 07:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770709140; bh=B0b3B0Qs5/qfPBaaRXW4KMtzJHv7uO/t40eDFJuptU4=; h=Date:Subject:From:To:References:In-Reply-To:From; b=vFrVT8EtdhrkE4evqH6Njmi2jJtu+hkLrThz1DcKBsUiwLZH4/f5XlN7kSUxirgBv wtFeAefFaADN/CWR6oU2FACCW77JaefFbtoQ+vYvHZviJVormhTqnTGipyD4XTOmDu eFUhrT9C+4xD7xGlMNkiX0wzPmUMBUEvqWlebYnmSnK21dp45Wnux0DwhDEtQeaZIZ EtX0/epshi6HwmQnKQQTQrWkEDPKhn6MkreMmB3gOYlNoRNgudsDp2j3PoDxLPsrwt bH55LVkr8JpnwLJ9EHA29UZkiVp7bOJkb7FGrtiJh5KiEdnX34g72z4JRV/rwKbZVQ 4SzMKJG2qNCGg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=e30df2874f9189943a99ced2374909534207af888b11016e532adc210f49; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Tue, 10 Feb 2026 08:38:56 +0100 Message-Id: Subject: Re: [PATCH 1/4] mtd: spi-nor: winbond: Fix locking support for w25q256jwm From: "Michael Walle" To: "Eliav Farber" , , , , , , , X-Mailer: aerc 0.20.0 References: <20260208061919.30498-1-farbere@amazon.com> <20260208061919.30498-2-farbere@amazon.com> In-Reply-To: <20260208061919.30498-2-farbere@amazon.com> --e30df2874f9189943a99ced2374909534207af888b11016e532adc210f49 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sun Feb 8, 2026 at 7:19 AM CET, Eliav Farber wrote: > The Winbond w25q256jwm device supports four Block Protect (BP) bits and > uses Status Register bit 6 as the Top/Bottom (TB) protect bit. > > Update the flash parameters by enabling SPI_NOR_4BIT_BP and > SPI_NOR_TB_SR_BIT6. Without these flags, the locking configuration is > incorrect. > > Reference: > https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=3D= en&DocNo=3DDA00-W25Q256JW.1 > > Signed-off-by: Eliav Farber > --- > drivers/mtd/spi-nor/winbond.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.= c > index fb855fe44733..55f1209936d5 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -337,7 +337,7 @@ static const struct flash_info winbond_nor_parts[] = =3D { > .id =3D SNOR_ID(0xef, 0x80, 0x19), > .name =3D "w25q256jwm", > .size =3D SZ_32M, > - .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, > + .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SP= I_NOR_4BIT_BP, > .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, > }, { > .id =3D SNOR_ID(0xef, 0x80, 0x20), Reviewed-by: Michael Walle -michael --e30df2874f9189943a99ced2374909534207af888b11016e532adc210f49 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaYrgkBIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/jF3QF9EQgzY2hTHby+BzXVzdSSsdl0BkdXH8n6 STtVdonFVaANpGL2DzJ9mBboRrYsPoTgAX0aEl+QptOBsm4GD7GR2oFKMdXJg5nx 3c4TnoRroSQAyhzyVvImIX9kk3D1qQYQpbE= =3tDT -----END PGP SIGNATURE----- --e30df2874f9189943a99ced2374909534207af888b11016e532adc210f49--