From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEE8C248F7C for ; Tue, 10 Feb 2026 22:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770763916; cv=none; b=FS8maYwg3XpzAb+iGSa0lPx8OKjavG/2jqLl49uutMi3gX7sZbcOAdaKy6BwuBi8BjY42iPePUZQGPrr8Mab42sf06Mhkwe5AwrY2uuVSX4BtZwD+JHlJosqA+b2rqwN4EjkpRJNBh3vXJWg+LHlFrbOiL9k10icAhNMufkXyvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770763916; c=relaxed/simple; bh=ojnLFsnGQeAhbZxAI9qeRW0Ds/xb8yBobc1iN/SQL98=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=DHS3nVEDFD2MplrlEDi8qhTkW2ojIvcMp4BP8cAJ2GlEYMlpsL7QuJ8DEyzqKb9teTMe0tn/AUnZJWbPW/7RxBERP1MqMPJziP+nrrjKpLmykKctiiu0B5IYeAzvhzpzQVFQPYasUiGThESKEWMd3UsOxiY/LkaNQnlmlU8QwHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IFAmFfh5; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IFAmFfh5" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7945838691aso4953877b3.0 for ; Tue, 10 Feb 2026 14:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770763914; x=1771368714; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ojnLFsnGQeAhbZxAI9qeRW0Ds/xb8yBobc1iN/SQL98=; b=IFAmFfh5ShPKPlAC/zB/LHMiZYMZDjPdWc+ymGnxXQdAIC3hn5jvcQWH8mgRdn/Xb4 XI7vUsnl4HBng8f/s2uIWUx0j6RgE8yhERrlf/KOptT6bzmIK8+t8L8SRRnWUGFBqRPb aqHahEty0W6BQrIN00t8DbjVoIh8Ka7Cla1JI428mQGnR7JyKYcLhhwpkY2CsYG1eYQW my5WU0RnukULewQayfeI0gQoKbvt8WLwl4511a1qZIHz/Ac/Q1rYtTntRKJ9KUoc1Xk5 7GCkFxfkoKZWFJmtNgxpcDUTKnkoht63gpShqnAqcT3vg74NC9wUZyuF9bGR1kDgzWNp ji3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770763914; x=1771368714; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ojnLFsnGQeAhbZxAI9qeRW0Ds/xb8yBobc1iN/SQL98=; b=EwFekxbaPEavUH5yBIlusrtiuXtsjxzPUtcKMjL5Vx3n8LIDUGi2dTvdbW6wtowrC4 eEwf/vyhQk5FV0J52P8ZkZP4tXYd8aZPKXGjAR0U7xRJM8JGxum5r80BQJzU6rqG3Wga 1LLgK2TFnOLEtbgZHsVrdU2tP1J/udyOhkCUGwcbEpXoPI8g9qMoOyvLqrquPZgZmtkE orDW0+9qBsk8YFG+/79U1VnHycXOVvmyX+uWvQaO19zq+HBJJLKc3vyZryFQDR3yX4jj 4sWl3dBeNvt4/AjNc9KHjbDzWZH2ecyx1xfVSXP9jxRD1aD+JZVXGOllMjXxo5lYCv6T 5j0A== X-Forwarded-Encrypted: i=1; AJvYcCWfvo7Ae3KpPZ/7pvssuCvWmKb9vxT/N0UdyOuIq1rHVzGthP4e1ZAyqaOINlqOWNEwJ/xCEX+9uvgiwzg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0OIClwRBZcqQLj5fTnbuaoRN/bYnlID28ofoniJVuzixfXcTM 7kz/k39vo1GGohBlkPXmWprnGI/61GFljwlw9m1vyZv9Ap6tY41LIg3sf1RgFWb2BSk= X-Gm-Gg: AZuq6aLpNp1gDWNdjwmiTBGPljbE54FA/9+0WEuxDcyii3GNtaey4Eq/cA0n31Bsgex AwLPzvV1BaTtKrOV7LaFafrdNAf1tVhU6FgfkFXqdXqEGLgNjHcuIW6m0cAOr04YcVgwZwURitx eOAaont+gkPbrDIodepB+d9RFEYaDMRlHfRaT0mcA0unyVwn9wX4OgFXrE/pw72SrfcT/pN/CmP El2n+4Lu6nLkz7T4AmMTMWzfuhYw0PmYhwCW1k8fYZZpLIyJM/AzObzQ2HqsDaO9Wjl6bpTr6Lp HKacv1uv3/hnbe+FUS0F0XIIjvfcRniAdwU+Z6QvFlJT6XiJOHCpdj0pumqzbYaN8u0SYNOhwj7 L7YUOFN1L1Stci5xucqE6dxQxyQiLSzfgZIDiRuYvefUqX40snS+zRO7ROV/yDzFP8yxnEGH5VQ 8PhmZ8kj0EmwM1zC7VSfKork8nt7PziW3WxDbwFFphV1RYRABiTN3uFbotadaKyh8bLrHMuzbBJ QpFAMd98g6NZ0ttl7csoAV7axsoszmV X-Received: by 2002:a05:690c:3612:b0:794:baaa:cc71 with SMTP id 00721157ae682-7965e2442d7mr33920857b3.16.1770763913958; Tue, 10 Feb 2026 14:51:53 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c16ee7csm307587b3.6.2026.02.10.14.51.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 14:51:53 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Feb 2026 16:51:36 -0600 Message-Id: To: "Haroen Tmimi" , Cc: , Subject: Re: [PATCH v3] staging: rtl8723bs: remove shadowed variable in sdio_halinit From: "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260210185630.54577-1-tmimiharoen@gmail.com> In-Reply-To: <20260210185630.54577-1-tmimiharoen@gmail.com> On Tue Feb 10, 2026 at 12:56 PM CST, Haroen Tmimi wrote: > The variable 'bMacPwrCtrlOn' was redeclared in the function > CardEnable, shadowing a variable of the same name declared at the > top of the function (line 21). > > Remove the redundant 'u8' type declaration to use the existing outer > variable and resolve a -Wshadow warning. > > Signed-off-by: Haroen Tmimi > --- LGTM. Reviewed-by: Ethan Tidmore Thanks, ET