From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E0E17ADE0 for ; Wed, 11 Feb 2026 03:27:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770780423; cv=none; b=vBUuFNem48KMJvT2M3UpxNcaNJ8ae3o9IrNFSgtX7VlnGUba9DiGZbOaqfjokbl6JWTb6MCBdy982sjzC6N36UQ5YnGGAgVX+KDywjnYqM3PPfbknbtJ+oGh3RSXrTMtSLCIiwVcK7zk8+cn7mpcHxirYCqXwLHsXY9rzT7XIz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770780423; c=relaxed/simple; bh=gLlohk1hM8dYTljLbj1pIKzl18cU6MDglJaze3Q1z4o=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=VvLHJzXaNli6hOK6uoRSNQJnFnSytoXxED2jyk4ZuzkM9wVRhK3BdC0betMWqd0p9cad9PMS5gpNq3AznyjkiC1lpxb5dM4zbKpJ74fPx6N1XpxJuBE/IwTXc/j/JL9d0iW69UluuyOY7Ka+DljsXcu8QoaAGjER9PQqbiXtjic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MLyQsbqC; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MLyQsbqC" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-79088484065so15854027b3.1 for ; Tue, 10 Feb 2026 19:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770780422; x=1771385222; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rKoCmVrrSKursSlU1GLGZdDvYA7k9AT9IwetYLGcTXI=; b=MLyQsbqC0rUHC28q8I/fP1DpzUcslU4umbms/C3VhmRlsykfDY0jutJJ4vXCkrpE9r 0KqfnmHlIJBDmQmHnFvUuQW1l9WPdMqEZ9h9FvULBt/rFljz/wYbhTxHXygA69O1T05l +qIPUs7bSBHDAGQ+hD/6/KKhsBsAr5UNqZF3wnVf4aWX9tq/KJsYBEZHwkmQ4ZvzkWH4 ya714Fkg3dtIDNyCoaZB1YHzMqHC9Y32LHGULlS3Cn/RecqzlFy7v5Mzb0o3yaw+MLvw BmVsT+Bl7P60oEQoNH3XcXyqswZBNathgFEjFMsBEmi51qLGrv3ND6e3vBiH/l3bhyfJ 0ZlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770780422; x=1771385222; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rKoCmVrrSKursSlU1GLGZdDvYA7k9AT9IwetYLGcTXI=; b=tFgadvOUYFbi1IFgcW2hZCqIDKJBGsgP6Oy6x7zpidya2F7ikIxU1rRuAjE0Z67KDc O4b4x+ihAHqbJ4FJe8fDxFNl36zDjsG+aYz/vtacqvW3wwCo2RQIQc/R9WuhtSJRmwXw BFRyaNZfUB00amq+yyh65yhX7DF4XnUVleVP3zUTB8Uf0HozU8Y76rC9lLqC/HYxTC0N 3eyC0Qgpj2dQJUvZDxIGHLwMV/eY53h2YGphzH6q5MBHie1KNsaD9bS7eOxS8q1zntst cb4pajX6HF5ehSBFDyzeX2GVqI4yz4g/lcfWGsAA260t9O7+XA1nXs+eqqVeuiSrvdfi ACug== X-Forwarded-Encrypted: i=1; AJvYcCVsnq+exEmfBsVrNbTXvWZOcMdcIpZ4pekU7YapjM9DvO+i3h8yZ3hJCCCAPPBsz3Xjh3LTE+AmFJUHCcg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg7W2XpDGkUzB1AzDEgl8x2TQ2I+Xh8MOAcdKe86bA3xdQBFZu +RnvWpme+CeEjVbGfK6uLLPJQvdaMM2KLzb72hsDE0w8A8qpOraZazZyvmq4YHfw6iQ= X-Gm-Gg: AZuq6aJHLZFzql+LFvyYBLGTjIqj6YBkneL3t5sSyfujQdHYetc/RFSdtq6WtCgBIdR VWV0d7a9R5adqwXONZ07Y5vrdND4gk9bwVa5xvAXCmwgJgTIIlY4RzADeNoPpPMeu/YSYaMk4Z+ jJuD4HQ4IiDhybNgNJ/NAiANcYcnLalbAG4b1boUEWrG4iCUgG3zk4BHSIiQ1V4+OvBiyr2ysj3 N0KcGWG3eZ6zhEY2ETDCdwwHick9tmr8eYYE3dDEcHb+bB5g+0j0rhsMD2hczqp3PjOVVdliAzw JUL8BwB1pfozdE2uJlSmwNN3ppbhHwQqvMd/9VCQqVXvLAh5ouqcZvdu+ejsuTHanJ0LYCnRdXo 0mvg8oOBR/V9lXvYvC8WkADcEzlcI+fhkWMZ8S0NSTVw34Jt4w86yRXdVO6IFHQqE3Y+1BT4dqY 5KgznrHeD40kE9NT9gzRrZ7Ww9W6edmG1gz2IHaL3EPu4E6wOFJ87bgCIxzBI1k+fL99Spk5K+W 6x/uWzwE7DAt2ZU9BqfhdkzenpbiM4k X-Received: by 2002:a05:690c:c50c:b0:796:371c:caa4 with SMTP id 00721157ae682-796371cce0amr228355477b3.52.1770780421489; Tue, 10 Feb 2026 19:27:01 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c254d5asm5290087b3.43.2026.02.10.19.27.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 19:27:01 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Feb 2026 21:26:44 -0600 Message-Id: To: "Ethan Luna" , Cc: , Subject: Re: [PATCH] staging: rtl8723bs: remove NDIS_802_11_RATES typedef From: "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260211024115.31339-1-trunixcodes@zohomail.com> In-Reply-To: <20260211024115.31339-1-trunixcodes@zohomail.com> On Tue Feb 10, 2026 at 8:41 PM CST, Ethan Luna wrote: > The kernel coding style discourages typedefs, especially those that hide > array types. Remove the NDIS_802_11_RATES typedef and replace its users > with explicit unsigned char arrays. > > No functional changes. > > Signed-off-by: Ethan Luna > --- You sent the exact same patch twice. As far as I can tell I don't see a difference between them? However, had this been a revision, please only send them every 24 hours. > drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/st= aging/rtl8723bs/include/wlan_bssdef.h > index eb38594c8f5c..6ad73d4de6bf 100644 > --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h > +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h > @@ -16,7 +16,7 @@ > #define NDIS_802_11_LENGTH_RATES_EX 16 > =20 > typedef unsigned char NDIS_802_11_MAC_ADDRESS[6]; > -typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; = /* Set of 8 data rates */ > +unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; /* = Set of 8 data rates */ > typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX= ]; /* Set of 16 data rates */ > =20 > struct ndis_802_11_ssid { By removing the typedef you made this a global char array, just remove the line entirely. And actually replace the users of this typedef. Which you said you did in your patch notes? Thanks, ET