public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Maxime Ripard" <mripard@kernel.org>
Cc: "Boris Brezillon" <boris.brezillon@collabora.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Drew Fustini" <fustini@kernel.org>,
	"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org,
	linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v3 1/3] rust: clk: use the type-state pattern
Date: Wed, 11 Feb 2026 17:47:09 +0100	[thread overview]
Message-ID: <DGCAAE4YEDLO.299F5M641E90B@kernel.org> (raw)
In-Reply-To: <20260211-flawless-feathered-boar-0b87ad@houat>

On Wed Feb 11, 2026 at 5:37 PM CET, Maxime Ripard wrote:
> I do think we can find a compromise though. Miguel suggested for example
> to make the current enable/prepare/disable/unprepare function unsafe,
> and that's totally reasonable to me.
>
> Then we can implement the "managed" clock version on that unsafe API,

What do you mean with "managed" clock? Do you mean devres managed? If so, I
don't think there is any reason to switch to the unsafe API to be able to
implement devres managed APIs (see also [1]).

[1] https://lore.kernel.org/all/DFVW9MS5YLON.CVJDBYQKJ0P6@kernel.org/

> and we would end up with a "raw", unsafe, version kind of equivalent to
> the one we have today, and where callers would have to justify why their
> usage of the API is actually safe, or the new, managed, variant that is
> safe and can be easily used by most drivers.
>
> And we can call these RawClk vs Clk, or Clk vs ManagedClk, or whatever.
>
> How does that sound?

What about we just wait until we have a user that really requires an unsafe API
for some reason? And if it never appears, even better. :)

  reply	other threads:[~2026-02-11 16:47 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 15:09 [PATCH v3 0/3] Clk improvements Daniel Almeida
2026-01-07 15:09 ` [PATCH v3 1/3] rust: clk: use the type-state pattern Daniel Almeida
2026-01-08  8:07   ` Maxime Ripard
2026-01-08 13:57     ` Miguel Ojeda
2026-01-08 14:18       ` Daniel Almeida
2026-01-08 14:14     ` Daniel Almeida
2026-01-19 10:45       ` Maxime Ripard
2026-01-19 12:13         ` Daniel Almeida
2026-01-19 12:35         ` Alice Ryhl
2026-01-19 12:54           ` Daniel Almeida
2026-01-19 13:13             ` Danilo Krummrich
2026-01-19 14:18               ` Maxime Ripard
2026-01-19 14:37                 ` Danilo Krummrich
2026-01-22 13:44                   ` Maxime Ripard
2026-01-23  0:29                     ` Daniel Almeida
2026-02-04  9:15                       ` Maxime Ripard
2026-02-04 12:43                         ` Daniel Almeida
2026-02-04 14:34                           ` Maxime Ripard
2026-02-09  9:50                             ` Boris Brezillon
2026-02-11 16:37                               ` Maxime Ripard
2026-02-11 16:47                                 ` Danilo Krummrich [this message]
2026-02-12  7:59                                   ` Maxime Ripard
2026-02-12  8:52                                     ` Alice Ryhl
2026-02-12  9:23                                     ` Danilo Krummrich
2026-02-12 14:01                                       ` Danilo Krummrich
2026-02-12 16:50                                         ` Maxime Ripard
2026-02-12 11:45                                     ` Miguel Ojeda
2026-02-12  8:16                                 ` Alice Ryhl
2026-02-12 13:38                                   ` Maxime Ripard
2026-02-12 14:02                                     ` Alice Ryhl
2026-02-12 16:48                                       ` Maxime Ripard
2026-01-23 10:25                     ` Danilo Krummrich
2026-01-19 12:57           ` Gary Guo
2026-01-19 14:27           ` Maxime Ripard
2026-02-03 10:39           ` Boris Brezillon
2026-02-03 11:26             ` Boris Brezillon
2026-02-03 14:53               ` Boris Brezillon
2026-02-03 13:33             ` Daniel Almeida
2026-02-03 13:42               ` Gary Guo
2026-02-03 13:55                 ` Daniel Almeida
2026-02-03 14:33                   ` Boris Brezillon
2026-02-03 14:08               ` Boris Brezillon
2026-02-03 16:28                 ` Daniel Almeida
2026-02-03 16:55                   ` Boris Brezillon
2026-02-03 16:59                   ` Gary Guo
2026-02-03 19:26                     ` Daniel Almeida
2026-02-03 19:43                       ` Boris Brezillon
2026-02-03 20:36                       ` Gary Guo
2026-02-04  8:11                         ` Boris Brezillon
2026-02-04  9:18                           ` Maxime Ripard
2026-01-19 14:26         ` Gary Guo
2026-01-19 15:44           ` Daniel Almeida
2026-01-19 14:20   ` Gary Guo
2026-01-19 15:22     ` Miguel Ojeda
2026-01-19 15:36       ` Gary Guo
2026-01-19 15:46         ` Miguel Ojeda
2026-01-19 16:10           ` Gary Guo
2026-02-02 16:10     ` Boris Brezillon
2026-02-03  9:09       ` Boris Brezillon
2026-02-03  9:47         ` Boris Brezillon
2026-02-03 13:37         ` Daniel Almeida
2026-02-03 14:18           ` Boris Brezillon
2026-02-03  9:17   ` Boris Brezillon
2026-02-03 13:35     ` Daniel Almeida
2026-01-07 15:09 ` [PATCH v3 2/3] rust: clk: add devres-managed clks Daniel Almeida
2026-01-19 14:33   ` Gary Guo
2026-01-07 15:09 ` [PATCH v3 3/3] rust: clk: use 'kernel vertical style' for imports Daniel Almeida
2026-01-08  7:53   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGCAAE4YEDLO.299F5M641E90B@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fustini@kernel.org \
    --cc=gary@garyguo.net \
    --cc=guoren@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lossin@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=tzimmermann@suse.de \
    --cc=ukleinek@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox