From: "Danilo Krummrich" <dakr@kernel.org>
To: "Benno Lossin" <lossin@kernel.org>
Cc: "Andreas Hindborg" <a.hindborg@kernel.org>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: alloc: allow different error types in `KBox::pin_slice`
Date: Sat, 14 Feb 2026 15:56:43 +0100 [thread overview]
Message-ID: <DGERTGLMB5S2.3OE4VYDYHMJ3M@kernel.org> (raw)
In-Reply-To: <DGERGXTEJ2B2.24F7OWLIZZAK7@kernel.org>
On Sat Feb 14, 2026 at 3:40 PM CET, Benno Lossin wrote:
> On Sat Feb 14, 2026 at 3:17 PM CET, Danilo Krummrich wrote:
>> On Sat Feb 14, 2026 at 2:28 PM CET, Andreas Hindborg wrote:
>>> @@ -333,24 +333,31 @@ pub fn pin(x: T, flags: Flags) -> Result<Pin<Box<T, A>>, AllocError>
>>> /// assert_eq!(s[3].d.lock().a, 20);
>>> /// # Ok::<(), Error>(())
>>> /// ```
>>> - pub fn pin_slice<Func, Item, E>(
>>> + pub fn pin_slice<Func, Item, E, E2>(
>>> mut init: Func,
>>> len: usize,
>>> flags: Flags,
>>> ) -> Result<Pin<Box<[T], A>>, E>
>>> where
>>> Func: FnMut(usize) -> Item,
>>> - Item: PinInit<T, E>,
>>> - E: From<AllocError>,
>>
>> I think we should keep this bound and just add:
>
> The `Into` trait bounds are the idiomatic ones for functions consuming
> things. See https://doc.rust-lang.org/std/convert/trait.Into.html:
>
> Prefer using Into over From when specifying trait bounds on a
> generic function to ensure that types that only implement Into can
> be used as well.
Yeah, but isn't this only because of [1], which does not apply to the kernel
because our minimum compiler version is 1.78 anyways?
I.e. are there any cases where we can't implement From in the kernel and have to
fall back to Into?
[1] https://doc.rust-lang.org/std/convert/trait.Into.html#implementing-into-for-conversions-to-external-types-in-old-versions-of-rust
next prev parent reply other threads:[~2026-02-14 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 13:28 [PATCH] rust: alloc: allow different error types in `KBox::pin_slice` Andreas Hindborg
2026-02-14 13:37 ` Andreas Hindborg
2026-02-14 14:17 ` Danilo Krummrich
2026-02-14 14:40 ` Benno Lossin
2026-02-14 14:56 ` Danilo Krummrich [this message]
2026-02-15 23:29 ` Benno Lossin
2026-02-16 8:48 ` Alice Ryhl
2026-02-16 9:37 ` Danilo Krummrich
2026-02-27 14:38 ` Gary Guo
2026-02-14 14:37 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGERTGLMB5S2.3OE4VYDYHMJ3M@kernel.org \
--to=dakr@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox