From: "Benno Lossin" <lossin@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Fiona Behrens" <me@kloenk.dev>,
"Christian Schrefl" <chrisi.schrefl@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: pin-init: replace clippy `expect` with `allow`
Date: Mon, 16 Feb 2026 12:17:23 +0100 [thread overview]
Message-ID: <DGGCEMEX10HB.3AZIOF9M54YVR@kernel.org> (raw)
In-Reply-To: <5f29715dba04c5a66195a962ffd1fb69@garyguo.net>
On Mon Feb 16, 2026 at 2:36 AM CET, Gary Guo wrote:
> On 2026-02-15 13:22, Benno Lossin wrote:
>> `clippy` has changed behavior in [1] (Rust 1.95) where it no longer
>> warns about the `let_and_return` lint when a comment is placed between
>> the let binding and the return expression. Nightly thus fails to build,
>> because the expectation is no longer fulfilled.
>>
>> Thus replace the expectation with an `allow`.
>>
>> Link: https://github.com/rust-lang/rust-clippy/pull/16461 [1]
>> Signed-off-by: Benno Lossin <lossin@kernel.org>
>
> I think it's worth adding a comment (or reason) that this is no longer needed after 1.95.
We'll remove the let binding when we raise the MSRV above 1.78 and then
the `allow` should also be gone. Do you still want me to add it?
Cheers,
Benno
next prev parent reply other threads:[~2026-02-16 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 13:22 [PATCH] rust: pin-init: replace clippy `expect` with `allow` Benno Lossin
2026-02-15 14:24 ` Tamir Duberstein
2026-02-15 14:57 ` Benno Lossin
2026-02-15 15:19 ` Tamir Duberstein
2026-02-15 18:29 ` Benno Lossin
2026-02-16 1:36 ` Gary Guo
2026-02-16 11:17 ` Benno Lossin [this message]
2026-02-18 15:08 ` Gary Guo
2026-02-18 20:38 ` Benno Lossin
2026-02-16 14:24 ` Miguel Ojeda
2026-02-19 8:37 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGGCEMEX10HB.3AZIOF9M54YVR@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=chrisi.schrefl@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox