From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Matthew Wilcox" <willy@infradead.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: "Andreas Gruenbacher" <agruenba@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
<gfs2@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gfs2: Fix error pointer dereference
Date: Wed, 18 Feb 2026 15:53:40 -0600 [thread overview]
Message-ID: <DGIF6W2ADL8N.RRRHPABYOFUG@gmail.com> (raw)
In-Reply-To: <aZYrw29iK1ak5Npw@casper.infradead.org>
On Wed Feb 18, 2026 at 3:14 PM CST, Matthew Wilcox wrote:
> On Wed, Feb 18, 2026 at 02:06:45PM -0600, Ethan Tidmore wrote:
>> The function __filemap_get_folio() can return an error pointer and is
>> not checked for one. Add check for error pointer.
>
> Can you explain how __filemap_get_folio() would fail, given the
> presence of __GFP_NOFAIL in the GFP flags?
>
I hadn't thought of that, looks like Smatch gave me a false positive. I
just saw the same function being called a few lines down and its return
value being checked for error pointer so I just assumed this one was
missing. Sorry about that.
Thanks,
ET
prev parent reply other threads:[~2026-02-18 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 20:06 [PATCH] gfs2: Fix error pointer dereference Ethan Tidmore
2026-02-18 21:14 ` Matthew Wilcox
2026-02-18 21:53 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGIF6W2ADL8N.RRRHPABYOFUG@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox