From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AD6E3161AE for ; Wed, 18 Feb 2026 21:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771451640; cv=none; b=bt1JzalZn5CDeI+soOyRxSfPcqi2c9n0rtWZo1MiMkxL7IUhHTRqoPzCFTYxqvqTOWpJxlKhHrXxvjw4P5Syyb641y0CMIFrRnlcQsEqPVC+whY1+axz8GBZUEc0KcS5UQ5vC5u/G+L5LVfkvn2H/7HTjkW++WQN7JxNFOwgHVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771451640; c=relaxed/simple; bh=yiZwkgF3kiNHaL7k0PdazEmxDginp2jVf72EIFLrFt0=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=Hp8GncJpUvXmkdlGe0BksjMHhvEj4Q+hReQOlYd+TfjLpMY/1uim2WXx+JP+NViv4Jd9jeQRPjyyzLzp/eHQ25FCU1MAWh8maWhGLHZ8MmYckmkXT3MtjKq40Xp7dlSMyJQ18qNBUUOYJWBOPpt5zMrFHWdscc0/BZs3xUo87Cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KUDYGKx3; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KUDYGKx3" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-797d3864d89so3855337b3.1 for ; Wed, 18 Feb 2026 13:53:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771451638; x=1772056438; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yiZwkgF3kiNHaL7k0PdazEmxDginp2jVf72EIFLrFt0=; b=KUDYGKx3eWKk6c1XPkJhtG0ujfRILRQufEdUd+ghDMiMV/slibM8VgzgYIhV+Axg1o wxVIj6eOLjmvpT0fbnM7W1+FDjI3mASvtEhTX+seBf2dMm8Z/fGYtjQNYo/4OYF35Q/U UOmsp2QwU4rwBl5xSdh43yTAni+Tzso1UaLnd7lJQXrw2dMfiXUKKOD3d5PDuc5ssp0P gRYJM0yEa36HyZIOPJPNrTQnVuYGDjWEcpMSmpA1q+J83nARRldds80xtGK1PY5No154 X5Cyh9dNk+4H/0io9w8BSi49VZprOCdEMX0tMJ74ULuHWKTG9RzDyerrSoMWI0cKerYA oORQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771451638; x=1772056438; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yiZwkgF3kiNHaL7k0PdazEmxDginp2jVf72EIFLrFt0=; b=GzOMgwCXYHc6LJ/rsPgh9tPl5awD52hUPiTkWpGK+btc67KPXilcjOWrPzsyAKGPUS X//sui1V2BQVunJN8/UxlJ1I9ILHjLqbGieADo4EoOUHos+0AM9yA/jf5AMX3mU6OUP+ W9YTK/DY/eDWuUzx6QiRqDTn3ctQy26DtMC5zL4dWpxlwIrJeAZ6UYx4S9eypDCqojQb UfETwLH68qK0+o3BsvHHVpMmtOxfHavnLZsO5BzCYCxuoRtmafXIxcBO8bTDwCstAaAx 6wcxouPEzSzqGDKXt6nhDenIMDxUZz0RxMqpGrj4fSRDSQKpFB6vytkAD2Kvg58VcKf1 jjTA== X-Forwarded-Encrypted: i=1; AJvYcCX50w8pTOY8bSAmuS+nELnrs79859DHcBPrit6feElwbpkvc5kPfA1QRLLINgw8OuIR5Njqu7YNti52kXs=@vger.kernel.org X-Gm-Message-State: AOJu0YyYPrix6P8pUWGnifTEb0qGkBUhuMoKuXk8Ne2aGD8dlXFrs9Af ws8Qil6/Mn4NbDgWyFpvpIInE39kAshd2/2BiY+dzt+nqpILYOwA5yNVkWWT+fAKFTM= X-Gm-Gg: AZuq6aI9fvm/cfTre+CxppAuMin3hIfy7lXzawphw2nHxeScKuWq7J6iUWOluH4XCuo 5zHhrkoltB3wScFu3jEuL6k2v0iTJBCnT6WwSMjVXz7MzyCrnBrnYHO4DkKWfucdCWkKwrh5h1e DBffDV1QQV0lwqQVxGbLk166JMUrmsvQ7s+8sO248eeph9h4Onv9qvK/20GI43XHU1BUT7iqsLD yD4P+WFKZczkCRNCUkdkijV0jgKKIdp3ID2S7mICSv9zSLsFE+WTs/kTwqxwQeCo9qKRjzC1CUy 9bQxG6D6hQ7fL+jM2QE7JDpBfmo1NIw585BIwakzqH6p6YQYz48tjo42VQGfKjmAsq0arWELxEC 4DhpHdFO2P3yjIfY1wwfzN/g1l9uV5E/bbumHc72Le394TJ3lGDyw98nm9N/5oCIvPsls131a6w TB7xvg0nBeDucvPT2hrXEiOOFaoBygxCQ90qYDOxZchWXUe9AM/X86HU9RROQVVb2doVnakIuld CcT11Olj5fZ2c8rWp8MmA8uoZwYur5gt3Ch7DDKJuMKmwTaaHc= X-Received: by 2002:a05:690c:399:b0:796:5278:84f0 with SMTP id 00721157ae682-797ac61b556mr132033307b3.57.1771451638451; Wed, 18 Feb 2026 13:53:58 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-798064888ebsm629497b3.15.2026.02.18.13.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 13:53:58 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Feb 2026 15:53:40 -0600 Message-Id: From: "Ethan Tidmore" To: "Matthew Wilcox" , "Ethan Tidmore" Cc: "Andreas Gruenbacher" , "Andrew Morton" , , Subject: Re: [PATCH] gfs2: Fix error pointer dereference X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260218200645.15713-1-ethantidmore06@gmail.com> In-Reply-To: On Wed Feb 18, 2026 at 3:14 PM CST, Matthew Wilcox wrote: > On Wed, Feb 18, 2026 at 02:06:45PM -0600, Ethan Tidmore wrote: >> The function __filemap_get_folio() can return an error pointer and is >> not checked for one. Add check for error pointer. > > Can you explain how __filemap_get_folio() would fail, given the > presence of __GFP_NOFAIL in the GFP flags? > I hadn't thought of that, looks like Smatch gave me a false positive. I just saw the same function being called a few lines down and its return value being checked for error pointer so I just assumed this one was missing. Sorry about that. Thanks, ET