From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39FA2D1916 for ; Thu, 19 Feb 2026 07:51:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771487518; cv=none; b=qds38dI7oMyG7aOpwAA4TDvHLfVAk/TXOj/4teWwnAr/bPEgkgFtiKh41vJszI2YWO7jHF2gOy606oq/GhbGLSz5co5OIIrIvTlT99FCXa6Cuxc9wFyXXun+W32CYbwnGbjdRo/7UdvvIgrUrk1PfFSgRnrhH2da9/SlT93eNRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771487518; c=relaxed/simple; bh=BftuWu5xc6UDS/Cu2AeKUgqwOXx8OPwjeNoP/kExL5U=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To: References:In-Reply-To; b=aamtK5aZPJF8lbfHXjWX5FembwzQKeSjWZKnERLZJge9K4JdifBu4C11q+Kq7eWlhwWsgAG7i3Xq+gzIIJuXD8a2vsPWg7NV9DWVXcyhpE98hsglSbu6jjXq9GZ6rqp7m25H49TNicujHuRaHtpmn8sIYU1sFtEUMqSVv97vj2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Asarl1dg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Asarl1dg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2768FC4CEF7; Thu, 19 Feb 2026 07:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771487517; bh=BftuWu5xc6UDS/Cu2AeKUgqwOXx8OPwjeNoP/kExL5U=; h=Date:Subject:From:To:References:In-Reply-To:From; b=Asarl1dgd5jUHWdLztz1U/iLWw5CC2QJmOhJ/zbdWG8OTNtZVqtfyDgjg/vgq3iHS YxWuTnAx0CNIa6XOtgLJlPJSQh6dPMDlyAY3+L3g1tyjYe09J4nNuBlYUfnL0M2fQe 7BEY2UNXXxK7ciVMSwIFgUEJm5yxjixW3F1AM4gFXQWiCKshOvp4Xhwrjg1if/KZQx dxU4/+for58XnjM2SFTJyBh4zlFV5TlYmlOFg9U6vdyEzma2cja1qH7yGx2WqvUI22 QkJqhJIuy5YdrZeey3y8/6M/RleM6MzQeaXAbUIwYt4Pk+yRKzlEo4fYjXw43PFLVV o3lJWCZ7jXjNg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=b4c395245128df01f78d3065ca2b3b2b7429c3dffa2013c7e6473e9923a2; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Thu, 19 Feb 2026 08:51:53 +0100 Message-Id: Subject: Re: [PATCH v2 0/3] mtd: spi-nor: winbond: Fix protection handling From: "Michael Walle" To: "Eliav Farber" , , , , , , , X-Mailer: aerc 0.20.0 References: <20260218143523.17467-1-farbere@amazon.com> In-Reply-To: <20260218143523.17467-1-farbere@amazon.com> --b4c395245128df01f78d3065ca2b3b2b7429c3dffa2013c7e6473e9923a2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Eliav, On Wed Feb 18, 2026 at 3:35 PM CET, Eliav Farber wrote: > This series fixes block protection handling for the following Winbond > SPI-NOR devices: > - w25q256jwm > - w25q256jw > - w25q64jvm > > The devices do not correctly describe their Status Register layout and > protection capabilities (locking flags, TB bit, BP bit configuration). > As a result, the spi-nor core rejects protection requests and locking > operations fail with -EINVAL, e.g.: > > flash_lock -l /dev/mtd29 > flash_lock: error!: could not lock device: /dev/mtd29 > error 22 (Invalid argument) > > Update the device flags to match the actual hardware behavior so that > locking and unlocking regions work correctly. > > All changes were validated using flash_lock on the affected devices. > > Changes in v2: > - Remove last patch in series that added dual/quad read for w25q64jvm Why? Unfortunately, you didn't answer my questions. > - Added Minimum testing requirements for w25q256jwm and w25q64jvm Thanks, but why was the w25q256jw left out? > Eliav Farber (3): > mtd: spi-nor: winbond: Fix locking support for w25q256jwm > mtd: spi-nor: winbond: Fix locking support for w25q256jw > mtd: spi-nor: winbond: Fix locking support for w25q64jvm You're supposed to pick the Reviewed-by: tags up before sending a new version, see [1]. -michael [1] https://docs.kernel.org/process/submitting-patches.html > > drivers/mtd/spi-nor/winbond.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) --b4c395245128df01f78d3065ca2b3b2b7429c3dffa2013c7e6473e9923a2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaZbBGRIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/gY1QGAz96mfu3GzNXMFKVHYODQNoiKDamF7Zwq LTovXhA66TEqJYm1/GftvloFjBIkamn/AYC43AXEoGpbMDV80m5IUzGWbCtD2Qoj IhQu9UfPwOwb8YhHNJPbWyY5Hx4wbFPs8TY= =cPZG -----END PGP SIGNATURE----- --b4c395245128df01f78d3065ca2b3b2b7429c3dffa2013c7e6473e9923a2--