From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Rivka Bukchin" <rivkab300@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: fix CamelCase variable name
Date: Thu, 26 Feb 2026 19:48:32 -0600 [thread overview]
Message-ID: <DGPD72RZFLPL.43AQ4SBBC64H@gmail.com> (raw)
In-Reply-To: <20260226084308.2915-1-rivkab300@gmail.com>
On Thu Feb 26, 2026 at 2:43 AM CST, Rivka Bukchin wrote:
> Rename pHT_info_ie to ht_info_ie to address checkpatch warning.
>
> Signed-off-by: Rivka Bukchin <rivkab300@gmail.com>
>
> ---
> v2:
> - Use full real name in Signed-off-by and From fields
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
You have a few issues with your commit body, please view this on how to
send a v2:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
> int ret = _SUCCESS;
> u8 *p;
> u8 *pHT_caps_ie = NULL;
It'd be nice if you changed this to snake_case too.
Thanks,
ET
next prev parent reply other threads:[~2026-02-27 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 8:43 [PATCH v2] staging: rtl8723bs: fix CamelCase variable name Rivka Bukchin
2026-02-27 1:48 ` Ethan Tidmore [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 14:22 Rivka Bukchin
2026-02-25 15:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGPD72RZFLPL.43AQ4SBBC64H@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rivkab300@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox