From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4B742D0C62 for ; Fri, 27 Feb 2026 02:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772157845; cv=none; b=ta6bH908Yj0XJPpqoH5+lqmM3v9bJSqGfSs5OTN3Y9O0JepiFAcDcC04yMi6K2ZKOSaKRIzrZA+EbjCFuP2iGTr+Wo91rptWfuTec2v7HyKIUe8SEEXe+3auexqRIYorPHCiWFelH1jsYPoBBWdvo9haw87cBdDhiZ03LdFiXag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772157845; c=relaxed/simple; bh=L0/k8V3HbNC3Rbjv9wQ1SK7tR8DEowT2Ha9rRtvNk/4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=T3Vux6qr3a0Y3IJD9fH6k/BSxeU+yCNO2zToGZUN7rvDss8a8vZqpTyNVeOu25vqguCUPYrbfHRr47vzN1Suct+CEeW2Z1NRCsLsYwEAzcrdTYZ+79hAVBeYukWI1EGoZCO320A/brho27ruXCYjiginf4H5aQ3BpJtBGS0ERr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cw3sKxbv; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cw3sKxbv" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-79868cde1eeso16822677b3.2 for ; Thu, 26 Feb 2026 18:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772157843; x=1772762643; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Mky5EJIKY6m2lCVUPp9GcJwSxelYZ9nTjAx3mMslLwY=; b=cw3sKxbvR+qBlsNM9vnDjtCHingI8hL22SMBVb9GeLg4jFvQGr/Iu+Kk9sGbx/Obxm Er8b1QplwxrdlmdIP6qp2dhVJH8UjEhU6zferyVQ3UHUswa4pk6vjMRkjcBJbspYLnk1 +vn6npIvkkUZWdIvZTlIimnHSKht378Luki/uqR9e772ASuTczBVCLPhkmh0kdLI/yRO /pFkoWdWxNmsO5zhFX+fSaWj5SPkVBJayHODjwaOfpAccMsPnBWrq4yurWYMy5gApq2w f86BXAwslmMSLnHrDoDqAJSMkmIWt2nvI7qLqnrU14C7///MDhleeYFpTdwuIZnT5QCi c2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772157843; x=1772762643; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Mky5EJIKY6m2lCVUPp9GcJwSxelYZ9nTjAx3mMslLwY=; b=MsdYr4cquk0IdU+7kNjSD4EGiDx35/KVuTan1nAbSVddfEhkakwvKsetCqAEMOfMtV DR/bp1xqe8QqB6ZiVgndLvxYFrwSTl+IbH2IJ8jMSyx3VanASZzGBzZQbv0bgppeNPNN Vde7GjepZOpOM02P8sVd6X0SRc+NS3JdT/Yuw8mN3C7r9DK0uTUD1wB7cgeQ5JZeAiEV YxKkSzTnGjBIV1mmM74gTSzjMl51a++JO8AUnHPvRUYqdff77ZnFnMuIUVDUcp/27aQu /71OEkiHL3mS/4dgjMATZdTzaNk78g1FZLtoFmHyq7zc1XQdBqK4TQ0UWWg6Ism645sf O95w== X-Forwarded-Encrypted: i=1; AJvYcCWG/1CLrpZWkUR848C/7rKuzJyvyhfI6haNCb7FyciVXAS54ejccywbw2tO4T3dhfD+MZ6OqXk4/+B3egU=@vger.kernel.org X-Gm-Message-State: AOJu0YzOfAdVlhVVCkfLNMlBP90u0NicoYZgL6dD6/zIxA0ZWTLQU2t+ cxwAZlXS858bnH5QhlXf2TaufVtVGOwSjZhvTDeqU8aD2xVAQLVHaiwl X-Gm-Gg: ATEYQzxB8aeFD7LkM+hHuZXhq+/SQuSJIp3A1v2wLfqEKYvJ8zAGUbRdvl+rx9pNeCh PDBlvsjmOSN9eFCYsxHTXMp85oUYfZgj7dxQbDmKBUdzkaqobmOVfZbXesuCxMWIXEDrzmfaycQ 8uBgCIHQeer0kKjCXXfrmNT5r3X8bUHshj5h+jAibx6f5aWpVOvcTIzBmiHQ0at8JMygxazuKN+ QuiTvtYQXLzWgLnbYudVKqeMAOnWnkbQjxHFy9PreiSwCsUEmtzhxYWby7E0+CMOrAyWmG0D5D6 28w/ftCw+wCFDU15vcyZddCRHgvM5p7FBnXV27JkNmaua57sjgxFMCP/tvWokqAmIx0nuc0HYO0 JFki4Fdkyh4IQK8kap3UYaf10pdu6JB+b995CdiRDDPqOp5AbvX8Qp13DfymhJ80ZKBhGbn+PTu LBCyLhnkoKLsiwUuZh2g/UYFMwLasWJu22s+Rzegg52+vHkcY33E6hRo+E1j0HPu7eD+w4+sDqM StAeY1Z6L0GUtMhXvez+wLnrOUu+yzE X-Received: by 2002:a05:690c:2609:b0:794:cd8e:3616 with SMTP id 00721157ae682-798854dbb07mr12097817b3.21.1772157842822; Thu, 26 Feb 2026 18:04:02 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876c862e5sm15433097b3.44.2026.02.26.18.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Feb 2026 18:04:02 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 26 Feb 2026 20:03:39 -0600 Message-Id: Cc: "Minu Jin" , , Subject: Re: [PATCH] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c From: "Ethan Tidmore" To: "Jose A. Perez de Azpillaga" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260226010536.179729-1-azpijr@gmail.com> In-Reply-To: <20260226010536.179729-1-azpijr@gmail.com> On Wed Feb 25, 2026 at 7:05 PM CST, Jose A. Perez de Azpillaga wrote: > Replace msleep() with fsleep() in rtw_cmd.c to improve delay > precision and follow modern kernel practices. > > Specifically, this fixes a checkpatch warning for the 10ms delay > in _rtw_free_evt_priv() and updates the 100ms polling loop in > rtw_chk_hi_queue_hdl() for consistency. > > Signed-off-by: Jose A. Perez de Azpillaga > --- ... > _cancel_workitem_sync(&pevtpriv->c2h_wk); > while (pevtpriv->c2h_wk_alive) > - msleep(10); > + fsleep(10 * 1000); It's better to use USEC_PER_MSEC instead of 1000 to avoid magic numbers. ... > while (!empty && jiffies_to_msecs(jiffies - start) < g_wait_hiq_empty) = { > - msleep(100); > + fsleep(100 * 1000); Ditto. Thanks, ET