From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF1936215F for ; Fri, 27 Feb 2026 06:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772174535; cv=none; b=L4WQr6HBQkbvCpVu2LIpNcfJxiJ2b022zPFRBifJZ9/8Fp7k74iwdRFRhaa3k/UaCfI1pnxTdylWXbUkHtgkg90+am/PXA64Ykr8CzILD5hxtV/vdzeDenKoAbIpwGuAjSJJrhDM0ISc/OrNgr0kOII/uyHt+/6fTM0cL6i1QSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772174535; c=relaxed/simple; bh=MlU/NhOGYcbdW214lqr8s1ycuVN6dxQdZPlBV7yR1v8=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=o2thGKo9TUNREkAG66vbeBUsTzIhVtJDyJCHONyuPce2c7bzj5uMpQE/6CxZKXxXcamsf64GHry27R2nN2YLw1z1iBAx49nFYf3Q8V9ihE/N+k5plAethrOO/ugd4u4RA+CRp/E+ZVjwgffZpkWL6MHL8C+4he/XfSWmKV5aRAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ifqqjpw0; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ifqqjpw0" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-798374d0f44so39770557b3.0 for ; Thu, 26 Feb 2026 22:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772174533; x=1772779333; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MlU/NhOGYcbdW214lqr8s1ycuVN6dxQdZPlBV7yR1v8=; b=ifqqjpw0PF0hb9kMrFhu0zjmF6LD7id5Sx7ApK4kduVoLqkNGhqSxfK9lDnbRaxrEy z64Y6OjMGENOgjKG6YEUbSbiLOMWLUFmQfwWik4tMTw3CUOoUFqE+rRsqSusQYFMMyt6 NADUnZVoqdYn3Db42X2Em87OQngs6t16IO7uVHS3gq2HdafbITvGrDzPRUr1as+Lbwl1 JE6RgV587azxdPMra3Nnk5vFVlWNFXYlKfObRnvMWL47L4fLxGIYKRGs3uxo6R2h2bSH df190FFZoc+utICCLd9L4s8HBbm47SEExDuwnX2FadFVfVHCyPw6HAjr57730HtVMS41 PiLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772174533; x=1772779333; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MlU/NhOGYcbdW214lqr8s1ycuVN6dxQdZPlBV7yR1v8=; b=TxZRvHEJ6POT9Ti0fKJy+WZR+GL2kHsA9qRUL6onXVBu2UCHzEYYERDu3klSzISBdr 165BHBACDOiKEr/6NKVnag20uqSlUYKUwjM+qdONYM4opzU58wa4dvxpTztZPMZrMRzw zF/KLKKFWzHYTFW+QT7bV9RmrKceah/tomJdTSEscGCPqN/BJhcB7sa+ErG+obNBpN8U 5xSN574UVBu6Rrap1s9lzCsfT56c6DjYPxEn2tVkLumC+ldhczFwVBE4RzZ3iISCzS3t SFjx9hxSpAQVgFQE0YczQl12elUA6uva+N+9vJ+YnvkhVyHfjmne4lqvWTFlu1s8iU2r zAAQ== X-Forwarded-Encrypted: i=1; AJvYcCV/sMbbdGVw5uBA3ccwoz6uvU2BhvwqgYWIMN/I6YQzjsjcpMP/VtlGL+L75/d5rbGZrSJGwSDJUhnDzSk=@vger.kernel.org X-Gm-Message-State: AOJu0YxVxSirpoUVR/Ilm7dsQvYqBnhzKxYJMiakc5RiQh7yB9muQyzD oOrJ7PGyWmOkA9DfoBr8yq3cEZcVgTdqih0IMAL4ONP/wYgmXRJtU2Di X-Gm-Gg: ATEYQzwYWog+450BoX/s1ZhxuIeY0/tZeFut4x5wLDQb3HR0JMIULYmYWlVmhLNjoet 6zY1QOJ3ZqwYd/zN1ji0LJlvSWN4I85Dw5kPjt0yhiXhlqFMFpl1iLYKVXzuzjfAi0Zcoz9JD8g ntXjX/AxQeE75dfWpoI6bKnojXGuv1Kr0P6juJ+mBY153FpxZ0kzwQrPqsDBXfBHtLoJGg75XDw owu5kEtvU7MVvgqlRsfvUBHiYHyZ4NiQbBrclcSg+XIJtuvW6eV7V1EQi+4H9DzD2TXrY/2dXOo mqSAQjoibSUaelEyWbzT1TaU1WMJ5zkn0gR9XgY93oqMjp34tql6CjEUPeB8SyDbYOhuzUS5BYk M15KDwAI7B8T8XpKoVaTIi0dygEZMODbIU7E5xWLOsH47we6upWU1NhAPP6xkGssaDGf9Bf8LV3 6oAva06+duoh/8zKDL6xRDB62Uu8Hj/LAqnr+Au+kIuol1rQNhDkoSbNRv19S1DR7mqVQl1F3GU iNIaItCjXK9T3DGFwlnN9NbkGYAoAqkDXrNxEftuJSqB5NTG0WzcsWOSUgYh1vE+ic= X-Received: by 2002:a05:690c:81:b0:798:6665:ca0d with SMTP id 00721157ae682-79885ac731amr14280547b3.28.1772174532861; Thu, 26 Feb 2026 22:42:12 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00:4c6c:c25b:2031:24dc]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ac3c0dsm17962127b3.12.2026.02.26.22.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Feb 2026 22:42:12 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Feb 2026 00:42:11 -0600 Message-Id: Subject: Re: [PATCH 1/3] iio: filter: admv8818: Add missing error code From: "Ethan Tidmore" To: "Ethan Tidmore" , "Antoniu Miclaus" , "Jonathan Cameron" , "Lars-Peter Clausen" , "Michael Hennerich" Cc: "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , , X-Mailer: aerc 0.21.0 References: <20260227061424.1135505-1-ethantidmore06@gmail.com> <20260227061424.1135505-2-ethantidmore06@gmail.com> In-Reply-To: <20260227061424.1135505-2-ethantidmore06@gmail.com> On Fri Feb 27, 2026 at 12:14 AM CST, Ethan Tidmore wrote: > If the macro FIELD_GET() returns an error code the function returns > with 0 because ret was just confirmed to be 0 a few lines above. > > Add error code. > > Detected by Smatch: > drivers/iio/filter/admv8818.c:335 __admv8818_read_hpf_freq() warn: > missing error code? 'ret' > > drivers/iio/filter/admv8818.c:376 __admv8818_read_lpf_freq() > warn: missing error code? 'ret' > > Fixes: f34fe888ad054 ("iio:filter:admv8818: add support for ADMV8818") > Signed-off-by: Ethan Tidmore > --- Just realized I should have used -EIO for the error code. Will wait however on reviews before v2. Thanks, ET