From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EF281F2B88 for ; Fri, 27 Feb 2026 12:59:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772197148; cv=none; b=ZWA9auD+j7eK0bMaKz0vWJoxMnhOg9rufvdk+dIM3kCxgjfknImKTvt2mMPawstbLVFsmLgRwhFukzDUor6WVSXc1JEUih1GU/Ej3d5IDFpSi1vbVu20AUlBuMSVi6P4Kef1VRTtfQ8nDzpYwoHhMeH9yn3u0K1mHB3JwDIFphE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772197148; c=relaxed/simple; bh=N6mRK6B0TD2fyKDXfse/EMxs0/EfS9Cy7XdI1gpQOKQ=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=AnRnFJIJmzcaOZR7iRyNopMakM3W82Z/EK0jk41Qaf9l1GX60RHX814CV6T/zTghubKInGi1jlfYBk4UF1LmVANBWHFRHgT+gaHE+BqGov9MOL6D0CCwlN/gDdey4aTyu5jwkSxFl7nOR6TVH9zDzzGBphEZvxFaS1fo/CUIImY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ObTqDIw7; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ObTqDIw7" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 64A0EC406AA; Fri, 27 Feb 2026 12:59:20 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 824E05FE46; Fri, 27 Feb 2026 12:59:04 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 30EED1036943D; Fri, 27 Feb 2026 13:58:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772197140; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=vr8wnBI6tXD0cjqGp1qmUgWaymHUW24b6tbquknqsZk=; b=ObTqDIw7SCeC3udo1DAW+aMsMnpTqEaUbfe18HWtHP4S30sOa7x4jJqEPrr6LvaDp6ZwO4 2ca66sTYcKDDezYi8PfSSjKUGhSVCqm3a/OGvFDT7Uu5UTL6V4U+4HM7sWFz3D8ANcdBN6 KIkrsL7uKrIoHvTDnth8Rw6kQ3g/gadP1BH8Scq9nLfW/EmYsJntEkPePaMWObt5dw1CUL Zftxi/O73cAkI8C95NkA8DyTQYSqI3BCElTFSz/g9kif6hvDdfBzaMyYcyumCad75ICtqI bKg8wjcc9V4tlSiSkPZzKJVKZ0d7NLxjq+f/QEftohdl2atKCzVDbdNRfYVKgg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Feb 2026 13:58:56 +0100 Message-Id: Subject: Re: [PATCH 3/3] drm/bridge: ti-sn65dsi83: add test pattern generation support Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Frieder Schrempf" , "Marek Vasut" , "Linus Walleij" , "Thomas Petazzoni" , , To: "Maxime Ripard" , "Marek Vasut" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260226-ti-sn65dsi83-dual-lvds-fixes-and-test-pattern-v1-0-2e15f5a9a6a0@bootlin.com> <20260226-ti-sn65dsi83-dual-lvds-fixes-and-test-pattern-v1-3-2e15f5a9a6a0@bootlin.com> <71224e5f-d982-45f9-be91-b61b78f38853@mailbox.org> <20260227-loud-silky-macaw-8d4d3b@houat> In-Reply-To: <20260227-loud-silky-macaw-8d4d3b@houat> X-Last-TLS-Session-Version: TLSv1.3 Hello Marek, Maxime, On Fri Feb 27, 2026 at 11:57 AM CET, Maxime Ripard wrote: >> > @@ -134,6 +135,9 @@ >> > #define REG_IRQ_STAT_CHA_SOT_BIT_ERR BIT(2) >> > #define REG_IRQ_STAT_CHA_PLL_UNLOCK BIT(0) >> > +static bool sn65dsi83_test_pattern; >> > +module_param_named(test_pattern, sn65dsi83_test_pattern, bool, 0644); >> >> Can this be enabled/disabled at runtime via sysfs attribute instead ? > > Then you would have to deal with concurrency with the atomic state > updates, and it would really be better implemented as a connector > property. > > In other words, it's probably enough for now :) I agree with Maxime, let's keep it simple, especially as it's a debugging tool and nobody wants to debug a debugging tool. :) It can be made more complex in the future if there is a real need. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com