From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Dan Carpenter" <dan.carpenter@linaro.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: "Mariyam Shahid" <mariyam.shahid135@gmail.com>,
<gregkh@linuxfoundation.org>, <ethan.tidmore@gmail.com>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: Fix logical continuation placement
Date: Fri, 27 Feb 2026 09:12:12 -0600 [thread overview]
Message-ID: <DGPUAEKP8SCX.3AUUXG0PMXF8H@gmail.com> (raw)
In-Reply-To: <aaFD7mluUSq9PfWE@stanley.mountain>
On Fri Feb 27, 2026 at 1:12 AM CST, Dan Carpenter wrote:
> On Thu, Feb 26, 2026 at 07:31:34PM -0600, Ethan Tidmore wrote:
>> On Thu Feb 26, 2026 at 3:38 AM CST, Mariyam Shahid wrote:
>> > Move logical operators to the end of the previous line
>> > to fix checkpatch warnings.
>> >
>> > Signed-off-by: Mariyam Shahid <mariyam.shahid135@gmail.com>
...
> Ideally, it would be aligned.
>
> if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
> pmlmepriv->num_sta_ht_no_gf) {
>
> [tab][space * 4]pmlmepriv->num_sta_ht_no_gf) {
That's what I meant I guess my email client mangled it? I'll just
demonstrate it like you did here for now on.
Thanks,
ET
prev parent reply other threads:[~2026-02-27 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 9:38 [PATCH] staging: rtl8723bs: Fix logical continuation placement Mariyam Shahid
2026-02-27 1:31 ` Ethan Tidmore
2026-02-27 7:12 ` Dan Carpenter
2026-02-27 15:12 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGPUAEKP8SCX.3AUUXG0PMXF8H@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=ethan.tidmore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mariyam.shahid135@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox