From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF5162A1BF for ; Fri, 27 Feb 2026 15:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772205153; cv=none; b=qPaWImwCISeRM/38zwOQu1NZniiijXiqW0R6hfPU2wPBmgPagX5Hl9D6TzZT5yXYeoHCGCEymmqZ1neNmIXO5XYaLp2ucfpofSo14K5mJ4sWYFk4qpblyY7Y08sNefO3fkUUJ0VbS54u1zdefgYlWHRT3xYW2Cgpn9SDMyosOnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772205153; c=relaxed/simple; bh=GBBkV8bu+I6h4BqPqfvoZgo1xACXj99VWvBi4PHzK9A=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=hU4nxhM8STLrravAvhEj3oYAA2QdQte8fqkxSe+X0OHvA3aV2g+8S56EmeydNPDLrqutHsnOgus0YrCwUkrIUoxCqOyvJLVUvkzsWJfZkPFJ5Nw1HeOXuyuvGwQF2hIGyaDq1BA73wZDFjOByiGhyNm6d6YZP2F0vBGR6EXP16o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KudEN8P9; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KudEN8P9" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-64c9a6d6b70so1804843d50.3 for ; Fri, 27 Feb 2026 07:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772205151; x=1772809951; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MO9cPCVCCePdE3t0jkdiABb6AY8+DqQ96RWqTyHdRy4=; b=KudEN8P9uoT5DO80DhDhau7tJvfHifoqGGm2hNZKy1Ebf7S0DHsLVd3NZ3RprIuIc9 dIfn0+zTA4yJAQWToJfy1PqAGLru381NsPX3FT+RhUzHvkVFhGxkz8VVvbWVOQQ/KaJx tLgiA98L/dHoBADmpoxits3/tPWYKU65VddT8ShwQfKx4h4RWgw79CZ3CfMwhSKcuyKO VirriuoJ8bP9NSXjTDU4tD8iI8DMpk0Ryau7AeoJY+8Dc0QocuFEZaMulKXR8KPwzjVk 86f8p28I+L7OcMMwPbJghtWC2LIJOgZe1lrzXuf/ZjFgp4OIBNdLqBA49IGdB9+PbiUk qIwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772205151; x=1772809951; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MO9cPCVCCePdE3t0jkdiABb6AY8+DqQ96RWqTyHdRy4=; b=I5OF+UKOhKzXELit6CqmvffienptTPPjJtINtSBYzvrskI6Nc92Z/sW+l7chTsHIAU F47uu9/+NCzZy0JbA777CoGx7+8k9w/TQcTHPXOzuckMf2kMCzXXexE8ShExAh32oj1h 3uYXc1eRr61xCFLXarPXjxZixDzbIDYowxk1paAVorfHgdFjaMVfhQhREEh55jsLCtEi p7wIANdOILCH/w1iaS8Cohti4F2HMj3NioAQ682IJMXl/gRPQfKGfwkv+NvDqP08xAin eB+0M5+4QTAQaeXi6hYQFurlJc8lf/mbWYAvrugdIkNz5/cz/9OKVOjCYjT7UMDFP63S YrZg== X-Forwarded-Encrypted: i=1; AJvYcCX/jR1yCb7Y/hJ9TJeo9ohIctNo6VHpAqzwtM1dk+vXqJ+2j3NvpauBHtMtkMKtszuYwCx6c5Tj7rkcrIU=@vger.kernel.org X-Gm-Message-State: AOJu0YwC7IHPas+v/CefA2oYpSfUsrsKP7fbGPQeV3M8Qc69AZ3/+lAa x0y53W94PR4+MLGsGJmiomZC7Ihp+tbF+CUxywyhP14KU578yW3upxPb X-Gm-Gg: ATEYQzwIoCIN+79v+Udr9jS5K9GXF1WneaPIdESNtd38Rq2wkxJFdryVL4ywVJPgrSU JVBI9RP2VyejiaIQFLEmlYIuAnG3Xtchb9uySKmaXqUglOXwOeKnYtY/+MSH0NJ+XwJoAEcgsUQ zye9UmJw2p8xaVod7/4LRIMJ3891qDsNL9e0awVW6qr+hRJOnZFdVWQGh92gbuDI7jyBMgVOlIM wnwDUOimGc1JXNY1dANSnGYSjjuLCGZFgmw4EoK0dJ5D8LEXxTvvkbXZ235RZSeCHZFgrUb6+xu Od5jPbcgVX/aK+rkNHo1K9LmulDcu94lpiyVKPKvBUShDn5gr7J3mUtueX8n8icMSqVH5ps+f9J DKXEx4V6zVVenTvFO9oUzX7bE+Wvl/cQDcHUMKPP5xu/j2OUIX9EEvBPIha/o4aldgrjNQZEDRx bgyMDs6FopAJTBwSDD6+Nujcp6sPfDYj6ijnZGHaatdaeD++rDqJaABrlgipfzHui9JAp6CkxRz f2zy7CB9Ted0uYhy2CkEzwHy8ZuoGv7 X-Received: by 2002:a53:d20d:0:b0:64a:e648:b7f8 with SMTP id 956f58d0204a3-64cc218fa70mr2028748d50.36.1772205150709; Fri, 27 Feb 2026 07:12:30 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7626e49sm2374903d50.11.2026.02.27.07.12.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 07:12:30 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Feb 2026 09:12:12 -0600 Message-Id: Cc: "Mariyam Shahid" , , , , Subject: Re: [PATCH] staging: rtl8723bs: Fix logical continuation placement From: "Ethan Tidmore" To: "Dan Carpenter" , "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260226093811.30659-1-mariyam.shahid135@gmail.com> In-Reply-To: On Fri Feb 27, 2026 at 1:12 AM CST, Dan Carpenter wrote: > On Thu, Feb 26, 2026 at 07:31:34PM -0600, Ethan Tidmore wrote: >> On Thu Feb 26, 2026 at 3:38 AM CST, Mariyam Shahid wrote: >> > Move logical operators to the end of the previous line >> > to fix checkpatch warnings. >> > >> > Signed-off-by: Mariyam Shahid ... > Ideally, it would be aligned. > > if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) && > pmlmepriv->num_sta_ht_no_gf) { > > [tab][space * 4]pmlmepriv->num_sta_ht_no_gf) { That's what I meant I guess my email client mangled it? I'll just demonstrate it like you did here for now on. Thanks, ET