* [PATCH] staging: rtl8723bs: Fix logical continuation placement
@ 2026-02-26 9:38 Mariyam Shahid
2026-02-27 1:31 ` Ethan Tidmore
0 siblings, 1 reply; 4+ messages in thread
From: Mariyam Shahid @ 2026-02-26 9:38 UTC (permalink / raw)
To: gregkh
Cc: dan.carpenter, ethan.tidmore, linux-staging, linux-kernel,
Mariyam Shahid
Move logical operators to the end of the previous line
to fix checkpatch warnings.
Signed-off-by: Mariyam Shahid <mariyam.shahid135@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 3e62fc8f61cf..004730d5f98c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1573,8 +1573,8 @@ static int rtw_ht_operation_update(struct adapter *padapter)
if (pmlmepriv->htpriv.ht_option)
return 0;
- if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT)
- && pmlmepriv->num_sta_ht_no_gf) {
+ if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
+ pmlmepriv->num_sta_ht_no_gf) {
pmlmepriv->ht_op_mode |=
IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT;
op_mode_changes++;
@@ -1780,8 +1780,8 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
if (psta->no_short_preamble_set) {
psta->no_short_preamble_set = 0;
pmlmepriv->num_sta_no_short_preamble--;
- if (pmlmeext->cur_wireless_mode > WIRELESS_11B
- && pmlmepriv->num_sta_no_short_preamble == 0){
+ if (pmlmeext->cur_wireless_mode > WIRELESS_11B &&
+ pmlmepriv->num_sta_no_short_preamble == 0){
beacon_updated = true;
update_beacon(padapter, 0xFF, NULL, true);
}
@@ -1799,8 +1799,8 @@ u8 bss_cap_update_on_sta_leave(struct adapter *padapter, struct sta_info *psta)
if (psta->no_short_slot_time_set) {
psta->no_short_slot_time_set = 0;
pmlmepriv->num_sta_no_short_slot_time--;
- if (pmlmeext->cur_wireless_mode > WIRELESS_11B
- && pmlmepriv->num_sta_no_short_slot_time == 0){
+ if (pmlmeext->cur_wireless_mode > WIRELESS_11B &&
+ pmlmepriv->num_sta_no_short_slot_time == 0){
beacon_updated = true;
update_beacon(padapter, 0xFF, NULL, true);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8723bs: Fix logical continuation placement
2026-02-26 9:38 [PATCH] staging: rtl8723bs: Fix logical continuation placement Mariyam Shahid
@ 2026-02-27 1:31 ` Ethan Tidmore
2026-02-27 7:12 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Ethan Tidmore @ 2026-02-27 1:31 UTC (permalink / raw)
To: Mariyam Shahid, gregkh
Cc: dan.carpenter, ethan.tidmore, linux-staging, linux-kernel
On Thu Feb 26, 2026 at 3:38 AM CST, Mariyam Shahid wrote:
> Move logical operators to the end of the previous line
> to fix checkpatch warnings.
>
> Signed-off-by: Mariyam Shahid <mariyam.shahid135@gmail.com>
> ---
...
> - if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT)
> - && pmlmepriv->num_sta_ht_no_gf) {
> + if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
> + pmlmepriv->num_sta_ht_no_gf) {
This should be:
if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
pmlmepriv->num_sta_ht_no_gf) {
Also, my email is "ethantidmore06@gmail.com" I believe you used a wrong
email.
Thanks,
ET
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8723bs: Fix logical continuation placement
2026-02-27 1:31 ` Ethan Tidmore
@ 2026-02-27 7:12 ` Dan Carpenter
2026-02-27 15:12 ` Ethan Tidmore
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2026-02-27 7:12 UTC (permalink / raw)
To: Ethan Tidmore
Cc: Mariyam Shahid, gregkh, ethan.tidmore, linux-staging,
linux-kernel
On Thu, Feb 26, 2026 at 07:31:34PM -0600, Ethan Tidmore wrote:
> On Thu Feb 26, 2026 at 3:38 AM CST, Mariyam Shahid wrote:
> > Move logical operators to the end of the previous line
> > to fix checkpatch warnings.
> >
> > Signed-off-by: Mariyam Shahid <mariyam.shahid135@gmail.com>
> > ---
>
> ...
>
>
> > - if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT)
> > - && pmlmepriv->num_sta_ht_no_gf) {
> > + if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
> > + pmlmepriv->num_sta_ht_no_gf) {
>
> This should be:
>
> if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
> pmlmepriv->num_sta_ht_no_gf) {
Ideally, it would be aligned.
if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
pmlmepriv->num_sta_ht_no_gf) {
[tab][space * 4]pmlmepriv->num_sta_ht_no_gf) {
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8723bs: Fix logical continuation placement
2026-02-27 7:12 ` Dan Carpenter
@ 2026-02-27 15:12 ` Ethan Tidmore
0 siblings, 0 replies; 4+ messages in thread
From: Ethan Tidmore @ 2026-02-27 15:12 UTC (permalink / raw)
To: Dan Carpenter, Ethan Tidmore
Cc: Mariyam Shahid, gregkh, ethan.tidmore, linux-staging,
linux-kernel
On Fri Feb 27, 2026 at 1:12 AM CST, Dan Carpenter wrote:
> On Thu, Feb 26, 2026 at 07:31:34PM -0600, Ethan Tidmore wrote:
>> On Thu Feb 26, 2026 at 3:38 AM CST, Mariyam Shahid wrote:
>> > Move logical operators to the end of the previous line
>> > to fix checkpatch warnings.
>> >
>> > Signed-off-by: Mariyam Shahid <mariyam.shahid135@gmail.com>
...
> Ideally, it would be aligned.
>
> if (!(pmlmepriv->ht_op_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
> pmlmepriv->num_sta_ht_no_gf) {
>
> [tab][space * 4]pmlmepriv->num_sta_ht_no_gf) {
That's what I meant I guess my email client mangled it? I'll just
demonstrate it like you did here for now on.
Thanks,
ET
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-27 15:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 9:38 [PATCH] staging: rtl8723bs: Fix logical continuation placement Mariyam Shahid
2026-02-27 1:31 ` Ethan Tidmore
2026-02-27 7:12 ` Dan Carpenter
2026-02-27 15:12 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox