From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7443346A1B for ; Fri, 27 Feb 2026 17:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772212589; cv=none; b=fpNEjl5a76VvYXincM7BdmDt6N2+UU4JPPCtSJgLJxgs/eIYlK7iwQikAljJ8KcaMb+3DlqMYRypdUo4aXqvCRBBBsuLS18sUTQu4nIWE+V+KV/Vd9nhL6pT2lPKkMR5Xzn62w+NEHWvy95yo+iuq9+eTqQHC09hrMldKZYCpEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772212589; c=relaxed/simple; bh=NfbU1RBDY31CszwCscX8jNEklH06g8DVxaJC+XgLde4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Xmloh2T9t/Y/bhHOwcZ4A/mN37Q7tr5EPqJ104YXMF5IQnwxzoS6Dx2GPLvZUt/GZqzfuIdC915JiI5NmoY3f0AOr86fOOo+wKSDg0YliovLtgADmw3L/MmYcdB+XggrlF9EcM+W7WOrdBpYUgO+mrAyNK56/Y/ol9PxWiKblOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FKMwims3; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FKMwims3" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-64ca09f2170so2358795d50.1 for ; Fri, 27 Feb 2026 09:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772212587; x=1772817387; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NInD6tgW3uHC3N2D36Y6VAT8+EqRVwOxj+jQQUfDC7A=; b=FKMwims3FTVBeaZKDLLvBxwhbhLjrGuoCVD2glG0vkhi03QamQhW6xKkef/xz0LK9J UOIMpIf9nxIBxIyA0gEU2b6mKNw0rVuC/9teWngoBUsyzWiqeDvY7f9mOPskV8wshzEY 4R/JdE7hfyJlBoDx0EFT6EMAMNkXgt/r3skNqQIpF3O/gZw7VlvKwsprlWvAdbC9647r /Nt6P4jQ8Ps0MtwI0iLuAwLwVSTm1nNkfoVamHfVTDKYiyjfPccZDguaB4ZLkxZ7wlnD BQ0q1626pQMKkzQsDlcW73pICi7Z7oRrzArVE9CWr69RGpy7emAeS1tln16F8sycrUlg uLAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772212587; x=1772817387; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NInD6tgW3uHC3N2D36Y6VAT8+EqRVwOxj+jQQUfDC7A=; b=mVNr5kj43Z0UOOYBg7AR9FhEgi+30iKMXQgmcrMznNTK3k9WBJ63/9jE7/PATOiVjP hXpOkfklpub0Hvaqd2ersiLjY2SgdIDT0+f0BN2tihiohANzryQz3yTcA1J2AMcJvmcK k7pbS3tFPt4QzOSDCr/Jm1UFkGH6q9oUsKVF7Vnuz0kWGZ5iBu48pvk/Rrsq+CqOKju3 e5iVlPJD78kftm5qnZIZlTPnCsaY0wHctfz5sw5Ms/kjvnZTyMGUohmz9k8/28R/92wg 3xSgnxG+CKmjEnDsbp0jC/ZG+SPONkW/1T3MoeOI/boF1h0mPnpbotoW4DzaFHS92eum nGng== X-Forwarded-Encrypted: i=1; AJvYcCWk9TLLtO8+ZfON5xvpoJtUFymIO+czyvLqQzIc+A3RFYNpHrmAfFjBcewEctgqsHOC7T8nc06HriuScPo=@vger.kernel.org X-Gm-Message-State: AOJu0YxjrsyYFeamOF1BtnnHZZH+ENIwdOQUrk9HG1RGyS3xB8i1qGAz ZMkmVsl8MydabVIE0r/IMV1NQDSsJINPXxc3Vj+4EOPDH2aCAIU3M8nm X-Gm-Gg: ATEYQzwdYKRPE2FubzL5vGjnRwZ6DV1VSeg/sEWLr0VKg+RfFtey9qGmvKhihGySDcp ZmAB9HJzd3OnfmAnwnbkh2u6jPMG2UhftzWMyz0iixJqFsQy5ZSE3pWwFiRFjdpYOHo95+pyOWK 2C+ng7Mrkeb2m4ftnBWqtMPkig5/snUZXKf77v+Rq3eI1lS3j3yfwo3CibJ2qFDlQniUgUVj00C /ZtcRKuJiY5aOm96V0S6NruSwgRpcsqdCo/+5uPM4dnLaWZn/kXZqFenoXsOjvIb4e4r5ntyc+X xE9pukuyXoF+WOHxHSE18TvzWJTL2xbLrLBfZvL08chaIfqX2sUZB/msbdk0IhpxHMgpQAKUog7 RnRybXlg/FXVewhTWlBaYmW+5S9y3vwsbUWAdJrapM1l2O5Jsykxfml2V7J9BT9EDhXQ0E8qspm M5aFPdf+222Ho83+VLD7iJleK2Fhh5ZMTU5JFTkJzWovtGNc/iXIaUD52xKMhQeDcgPVfMnhN8I YR8euU/5o6JM8ItVWWO3DbBD5uDQzKLw7BwZQAmJV4= X-Received: by 2002:a53:c9cb:0:b0:64a:db3a:f83f with SMTP id 956f58d0204a3-64cc2083acfmr2439489d50.16.1772212586645; Fri, 27 Feb 2026 09:16:26 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb759f507sm2593053d50.8.2026.02.27.09.16.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 09:16:26 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Feb 2026 11:16:08 -0600 Message-Id: Cc: "Jose A. Perez de Azpillaga" , "Greg Kroah-Hartman" , "Minu Jin" , , Subject: Re: [PATCH v2] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c From: "Ethan Tidmore" To: "Dan Carpenter" , "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260226010536.179729-1-azpijr@gmail.com> <20260227084623.209913-1-azpijr@gmail.com> In-Reply-To: On Fri Feb 27, 2026 at 10:39 AM CST, Dan Carpenter wrote: > On Fri, Feb 27, 2026 at 09:18:24AM -0600, Ethan Tidmore wrote: >> On Fri Feb 27, 2026 at 2:46 AM CST, Jose A. Perez de Azpillaga wrote: >> > Replace msleep() with fsleep() in rtw_cmd.c to improve delay >> > precision and follow modern kernel practices. >> > >> > Specifically, this fixes a checkpatch warning for the 10ms delay >> > in _rtw_free_evt_priv() and updates the 100ms polling loops in >> > rtw_chk_hi_queue_hdl() and rtw_free_cmd_priv() for consistency. >> > >> > Signed-off-by: Jose A. Perez de Azpillaga >> > --- >> > v2: changed to USEC_PER_MSEC instead of magic numbers >> > --- >> ^^^ >> Remove this. >>=20 > > Having an extra --- cut off line doesn't matter. The other thing that > you sometimes see is an extra blank line before the --- cut off line > and that's fine too. > > regards, > dan carpenter Oh ok, nice to know. I guess I assumed the last cut of line was the one that counted. Thanks, ET