From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAE16326942 for ; Sat, 28 Feb 2026 23:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772321919; cv=none; b=u/CML1DIf8aOGBSW1ZFKutjYGNQ5Nunu/MSWnYvgBOTUCJC3U1eEaSotYpJdIeSQpAfVk5OrTJCe9RHsneCi1hFRvmhE5jMBAgfPdFYkjoY1rOU+8gb2TJ/dfp+k+DInGfb3+56vpvbrQSFIyGARYUEDEZAeQ5GynL9e/jMV5GE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772321919; c=relaxed/simple; bh=AW5T9Hc4nbKkDkGmRXK+0jMJLHNhZgY/umP29NnIa7A=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=AijOUldn+a2PXdRgCuhicSTLCGMzReROTVVa3xutPluFJJH+1yNXrDyHoWrWfokZWIxIL/TnHWp04bUcJ9wQETy0Mh7/rSKNhBBHwdPhBogQP/E2WuOPfLuQHsBnkKUOxHvSrLdWkoSoSFvg8YbBOJd/Rup/MepfoszJ7DvmPRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y+62m04m; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y+62m04m" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2bdecd00ebdso4015027eec.0 for ; Sat, 28 Feb 2026 15:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772321916; x=1772926716; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hziZ8HwNJIKxde4jYjnTUIsaI5Anyr71P4ZGtylHymA=; b=Y+62m04madFEPG2Egzu4UaSzjbGXDICKcnrhiGXXheiJIWV8XF3Ust9Lzm9XRj1NOg NxhlxYWqHfePx190ZNflO9TjXEQusCNXYWz83MgFxaozOytFzerq/9V+8uZfNiZNTmqg I2Xukgvhy5yyMIjnNFbXDXsRFHnzq08+vLusCHGX3tNvszdulkTZO2A5CRx6QM4zGw16 Le9evq6pcjjH/ADl9nr3Zi5Q/NYUnRSe1JbL9XbR/o+QkVbteknIsqaQTv3MitFMVuc6 aAKwQqZhrUgL6ix1dd8js30UPZKEl3mraiY9wu/kr7LU5Rxm20KjYYQWodwNMeEsRi1U Yo9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772321916; x=1772926716; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hziZ8HwNJIKxde4jYjnTUIsaI5Anyr71P4ZGtylHymA=; b=F+Qt8Rf5fEObR63S4Aym3eGuBG04ArjDZChuamq1X15ioF4d8IM99kZ2DLLlRj18Zz evNl+q5C6nb2USAOyZHZFS2LzaezHvrsde+edIsQnwOR5YAHyMbhDnwyjpgk5IIny554 4D0C9uWxqSuNQi1yQp4LZ1YlPW415hmj03P9erZEYKAafBR5THIS7JYU/+hrMJRCgCfa csVfiGk1TYQ9bqjVODF22pVOfK1PS8DFAbgon6QuXe7xMy3ZcyaP+h9qPuc2kQXECbSQ QO5rWDqmbafne+9B73WBVoSVDjEPjqRmv+hnouHumh+DdeOe8kfZglD7yKmcVciQ/CRm RZ1g== X-Forwarded-Encrypted: i=1; AJvYcCU8PFHmjYe8PZx6PAOjaEmLYb9gr3OMQcg5XIRnYvxo+PqJKSK0dCz65cV9M7Xr11Y5tlAU3lpcP7uw4bI=@vger.kernel.org X-Gm-Message-State: AOJu0YwfKAIzAqWf5xpelBe87RkETUhsVVMSI7+HiDKVDUQa1RfzEdS4 dJ2RDSrgHzfpv0LFSTMQXZds5Hec+amLBoji1NqAGTz5bVFnGTKClFQY X-Gm-Gg: ATEYQzxkmNe7wVEOW3GiwpT10UWjqn1kDQciScb1OsorptL4lTqOkvfCWoQ4JObv47K T5Qyhhud4S7+na/T7xAskNknVMw5SEi9vx70x+eCk6B2xdFRZ7WtzDZlmhH+B4klhGKDDiwUF7P po4rI0yo0n7GsJ6asZZgTyvLi6HwoMFk2qbjJ5NpT6qVlKJMJKW2bZ+KBls1Ff6dOZ6P+5lobVa +XCEC/05zfbFStt02Y9sQwb4kOdJipCBIKNL803xxJupYycOwy+GQhQpWA0EcuzysOPGNgNVSbF MGvXGrpCTe4zl0/09nHaFVyFpNq/O8hf/mMFYcEDHxp6PNM3+IxFiNWHSyKKAIVfld/DVMvWu6R 3UR89gCrHAZ833yvMFKFhHHh3JkE5CIPl/5dvrB1UoQHIS1jMiz3wbCRzVDQT0zyrryEmpylX9k PwX/DHC/L2VkiqlIeQpds7SROCRgIgSULrk6LwWs2YyOjY X-Received: by 2002:a05:7300:a198:b0:2be:694:5713 with SMTP id 5a478bee46e88-2be069458e8mr203613eec.36.1772321915822; Sat, 28 Feb 2026 15:38:35 -0800 (PST) Received: from localhost ([2603:8000:bb00:9b3f::18f6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdfb3f898asm1293640eec.29.2026.02.28.15.38.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Feb 2026 15:38:32 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 28 Feb 2026 15:38:29 -0800 Message-Id: Cc: , , Subject: Re: [PATCH v2 1/2] rust: add projection infrastructure From: "Aditya Rajan" To: "Gary Guo" , "Miguel Ojeda" , "Boqun Feng" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Danilo Krummrich" , "Nathan Chancellor" , "Nicolas Schier" X-Mailer: aerc 0.21.0 References: <20260226154656.3241736-1-gary@kernel.org> <20260226154656.3241736-2-gary@kernel.org> In-Reply-To: <20260226154656.3241736-2-gary@kernel.org> On Thu Feb 26, 2026 at 7:46 AM PST, Gary Guo wrote: > From: Gary Guo > diff --git a/rust/kernel/projection.rs b/rust/kernel/projection.rs > new file mode 100644 > index 000000000000..186ec194f2b8 > --- /dev/null > +++ b/rust/kernel/projection.rs > +unsafe impl ProjectIndex<[T]> for usize { > + type Output =3D T; > + > + #[inline(always)] > + fn get(self, slice: *mut [T]) -> Option<*mut T> { > + if self > slice.len() { I am not sure but shouldn't this be `self >=3D slice.len()` ? I could be wr= ong but `slice.get(n)` should return `None` for slice 0..n ? There is a similar condition somewhere else in the code as well. [...] > + // Check unaligned field. Not all users (e.g. DMA) can h= andle unaligned > + // projections. (e.g. DMA). Nit: Comment mentions (e.g. DMA) twice One question regarding the `in bounds` check otherwise LGTM Thanks Aditya