From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Josh Law" <hlcj1234567@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
"Josh Law" <objecting@objecting.org>
Subject: Re: [PATCH] staging: axis-fifo: minimize lock duration in write
Date: Sun, 01 Mar 2026 12:39:17 -0600 [thread overview]
Message-ID: <DGRNY1T40JK7.3H4QL6BCQOXFT@gmail.com> (raw)
In-Reply-To: <20260301005836.2513391-1-objecting@objecting.org>
On Sat Feb 28, 2026 at 6:58 PM CST, Josh Law wrote:
> Memory allocation and copy from user space with vmemdup_user() is relatively slow and can sleep. Move it outside the lock to minimize the time the mutex is held, reducing contention for concurrent accesses.
>
> Signed-off-by: Josh Law <objecting@objecting.org>
> ---
Hi,
It looks like you've sent a few patches editing the same file with 3?
chained together but the rest just own their own. This is a little
confusing trying to review. Typically you'd make a cover letter and then
chain them all together using git send-email.
Also, keep commit body lines under 75 chars. You should use this script
to catch things like this:
"$ ./scripts/checkpatch.pl --strict <patch>"
Thanks,
ET
next prev parent reply other threads:[~2026-03-01 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 0:58 [PATCH] staging: axis-fifo: minimize lock duration in write Josh Law
2026-03-01 18:39 ` Ethan Tidmore [this message]
2026-03-09 16:07 ` Greg Kroah-Hartman
2026-03-09 16:11 ` Josh Law
2026-03-09 16:56 ` Greg Kroah-Hartman
2026-03-09 17:04 ` Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGRNY1T40JK7.3H4QL6BCQOXFT@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hlcj1234567@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=objecting@objecting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox