From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996A824634F for ; Sun, 1 Mar 2026 18:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772390377; cv=none; b=d4Z7VXwR5ptZpUH6O0QHFeL9nAMi3DdlZAUpz7joKtXPBnQ0zQaV0Sz4hE3hBy4chHwrIaIJeGzCDJW9WdnrnCQrp2yLjI4Diiqf0QQ9SwUElQB+xp4QJYK7NBgpmqxiDr2d6Wk3sCgW7hUkToa2ndVLSDUbvbUKSYeCZLRH7MI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772390377; c=relaxed/simple; bh=t9jt++0PcoPuo3XTtezsl22tbZdI0zAS7+qGBA/xnKQ=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=cP86dJk8tRYtIEFnWW2C9UUR1diimZZhgprSJ1qC15M3znd9ObveqFJNCqOz5FtcvCO1/mSwxqxZkTEb+ry8mQng6vXEikJJfFF/IX9MKVC3udA8bXo8R2dmayHGbFa5BdUBjR1y3p4JCmrdXp3bMdkAzf1DzUhwbT1x0+82PZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WVj2U2Fi; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WVj2U2Fi" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-64ca1ba0089so3102603d50.1 for ; Sun, 01 Mar 2026 10:39:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772390375; x=1772995175; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t9jt++0PcoPuo3XTtezsl22tbZdI0zAS7+qGBA/xnKQ=; b=WVj2U2FiR+p0M8y4qnpHfqtuxnWtzlpPgBxcvZRX7RlpOmF2vX9c91WBThxEEgQy0q HGCLzkmvSjA6B79D32JiBzc8A7g+XZeDqdFKl0mtp78LFF8GTceoSmmDllQjJlvax10+ a1RuJpQIo5cakQOHI15XPYlyFVTVI36b+ctZNNDUmw8qCbb0Y3eaNfBUzo7u0Ttb9nEr /L2BWg962c+ZU70HgEUR2EvgUOm+QbUgC5kk9ikjJlvwx4gENjjmXAUGo7XPhaZxbVq3 D3HLnAfs2XP6AfWN33vo2dPQ48rsQyMD4IC1XtYS4qplea4s6gfHl3hbFDkwaKsDCuUr Kr+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772390375; x=1772995175; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=t9jt++0PcoPuo3XTtezsl22tbZdI0zAS7+qGBA/xnKQ=; b=vgk3i937JA4nfuhpYXCqI9D6EsyxmRAg4SZJbiEFSYksW4XiyYN8g7zxXvB+22tAJb 8I3WVgZtgtptaywAvIhz99Z7ze0B8pz8JgzQggxCrr1rQvWrMA/xCbOCfJ/ODOAMdkFb gLfuZSBQKnahqawc0K9n62sXVlH/VKY7GSSYV9ut/FKQDDmGjI2neN+8EEXqGl8Lvb8f 1k2f/fpL0Ms8oAiya13umQHDm1puyDvWqHwDGSxujxPDYfUaGyU3QcjQfpYqiaIQdDb2 htk6/iIKX5pRBqTvwSjGes9HtQoOe/bjC3/GYKHd0V54Q920xupaS8/bXwdnxkMMPaZE yOrg== X-Forwarded-Encrypted: i=1; AJvYcCUEFQKOQB+bB1fICv8oYu98YFFuqUzXSBuLxcKxxVaVx+QbY1QyBW8ZcFqM+zGMSAWU41hw5C2nDNqwiVk=@vger.kernel.org X-Gm-Message-State: AOJu0YyS/Lv5awgbmcV5dlCplTACCuq8bkVuHxXjosvxpkDEmx7oQqmV DwIdnQoV3mA/yMYtLhHiyLW3uPKSBAYD9BqsQChJ6L+S0docq8t8MGH7 X-Gm-Gg: ATEYQzwdFswnG4x1W6eUC7HzBZXEe5KDI+K7DsNa4oiSTnxYmrxHryZfWvkLBYe8tc+ pUOyzmeKnwDXoStootjKY5UAgEbLWPHjww66IPqo+n8D1eqNpLXnzLDrMZcbSGge9gbfeqZF9RS 7rzLOl60LMIWnhUskbkrbKiCAvf0kGd71lIxe3PUjjfCo431v0EqLquRLEPigUdXBebv8YGrHTd apmLa90WeNDQDTDzj0gqEeqcMNfXnRio+ngLuIHXx55pHjXtmGH0t9res8juLPOVL59NiRVw0sU 4zPt07B302UYGIjMbWV2w7m3LvyBo8Agn9Pq6NXwTDaAk6GMnYf2igR1+vMdWkLlh7JQFuAZ8BG fnvOe1Yy0sjOPGpzdsdMmsSs93vh55UrDS3vaeMbIttBX0X5MJWVz4SoPgfLKjAWKfAGuGGVdmm lPP7bBYtm/oReaYndH3lMPc0olph2rrNVR5Ivhfzh3mm9Zj/ptvDfP9h5+AIfn0zMkPXDzOJxth LPNUjLaNc54woh0NTGYlJlhtXhEqzQL X-Received: by 2002:a53:c04d:0:10b0:64c:b35c:aae6 with SMTP id 956f58d0204a3-64cc2077432mr6674262d50.13.1772390375518; Sun, 01 Mar 2026 10:39:35 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7627181sm4901072d50.14.2026.03.01.10.39.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 10:39:35 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 01 Mar 2026 12:39:17 -0600 Message-Id: Cc: , , "Josh Law" Subject: Re: [PATCH] staging: axis-fifo: minimize lock duration in write From: "Ethan Tidmore" To: "Josh Law" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260301005836.2513391-1-objecting@objecting.org> In-Reply-To: <20260301005836.2513391-1-objecting@objecting.org> On Sat Feb 28, 2026 at 6:58 PM CST, Josh Law wrote: > Memory allocation and copy from user space with vmemdup_user() is relativ= ely slow and can sleep. Move it outside the lock to minimize the time the m= utex is held, reducing contention for concurrent accesses. > > Signed-off-by: Josh Law > --- Hi, It looks like you've sent a few patches editing the same file with 3? chained together but the rest just own their own. This is a little confusing trying to review. Typically you'd make a cover letter and then chain them all together using git send-email. Also, keep commit body lines under 75 chars. You should use this script to catch things like this: "$ ./scripts/checkpatch.pl --strict " Thanks, ET