[PATCH v3] staging: rtl8723bs: fix CamelCase variable names

[PATCH v3] staging: rtl8723bs: fix CamelCase variable names

[Rivka Bukchin]

Rename pHT_info_ie and pHT_caps_ie to ht_info_ie and ht_caps_ie
to address checkpatch CamelCase warnings and follow snake_case
naming convention used in the kernel.

Signed-off-by: Rivka Bukchin <rivkab300@gmail.com>

---
v3:
- Rename pHT_caps_ie to ht_caps_ie for consistency
- Fix commit message format

v2:
- Use full real name in Signed-off-by and From fields

 drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 67197c7d4..fa833e992 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -801,8 +801,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 {
 	int ret = _SUCCESS;
 	u8 *p;
-	u8 *pHT_caps_ie = NULL;
-	u8 *pHT_info_ie = NULL;
+	u8 *ht_caps_ie = NULL;
+	u8 *ht_info_ie = NULL;
 	struct sta_info *psta = NULL;
 	u16 cap, ht_cap = false;
 	uint ie_len = 0;
@@ -1007,7 +1007,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		u8 max_rx_ampdu_factor = 0;
 		struct ieee80211_ht_cap *pht_cap = (struct ieee80211_ht_cap *)(p + 2);
 
-		pHT_caps_ie = p;
+		ht_caps_ie = p;
 
 		ht_cap = true;
 		network_type |= WIRELESS_11_24N;
@@ -1060,7 +1060,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		       &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
-		pHT_info_ie = p;
+		ht_info_ie = p;
 
 	switch (network_type) {
 	case WIRELESS_11B:
@@ -1095,9 +1095,9 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		if (pregistrypriv->ampdu_enable == 1)
 			pmlmepriv->htpriv.ampdu_enable = true;
 
-		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)pHT_caps_ie);
+		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)ht_caps_ie);
 
-		HT_info_handler(padapter, (struct ndis_80211_var_ie *)pHT_info_ie);
+		HT_info_handler(padapter, (struct ndis_80211_var_ie *)ht_info_ie);
 	}
 
 	pbss_network->length =
-- 
2.34.1

Re: [PATCH v3] staging: rtl8723bs: fix CamelCase variable names

[Ethan Tidmore]

On Mon Mar 2, 2026 at 10:08 AM CST, Rivka Bukchin wrote:
> Rename pHT_info_ie and pHT_caps_ie to ht_info_ie and ht_caps_ie
> to address checkpatch CamelCase warnings and follow snake_case
> naming convention used in the kernel.
>
> Signed-off-by: Rivka Bukchin <rivkab300@gmail.com>
>
> ---
> v3:
> - Rename pHT_caps_ie to ht_caps_ie for consistency
> - Fix commit message format
>
> v2:
> - Use full real name in Signed-off-by and From fields

Patch failed to apply against staging-next. :(

Thanks,

ET

Re: [PATCH v3] staging: rtl8723bs: fix CamelCase variable names

[Greg KH]

On Mon, Mar 02, 2026 at 06:08:49PM +0200, Rivka Bukchin wrote:
> Rename pHT_info_ie and pHT_caps_ie to ht_info_ie and ht_caps_ie
> to address checkpatch CamelCase warnings and follow snake_case
> naming convention used in the kernel.
> 
> Signed-off-by: Rivka Bukchin <rivkab300@gmail.com>

Does not apply to my current tree :(