public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>,
	<linux-staging@lists.linux.dev>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ethan Tidmore" <ethantidmore06@gmail.com>,
	"Navaneeth K" <knavaneeth786@gmail.com>,
	"Nikolay Kulikov" <nikolayof23@gmail.com>,
	"Bryant Boatright" <bryant.boatright@proton.me>,
	"Tanjim Kamal" <tanjimkamal1@gmail.com>,
	"William Hansen-Baird" <william.hansen.baird@gmail.com>,
	"Artur Stupa" <arthur.stupa@gmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing
Date: Mon, 02 Mar 2026 15:12:05 -0600	[thread overview]
Message-ID: <DGSLTL0V29WY.10JGCNINX01CP@gmail.com> (raw)
In-Reply-To: <20260302185340.61540-1-azpijr@gmail.com>

On Mon Mar 2, 2026 at 12:53 PM CST, Jose A. Perez de Azpillaga wrote:
> Fix spaces between bitwise OR operations rtw_action_frame_parse() for
> better readability.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index dbd4bcc8cd28..446e4051b9ae 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
>  
>  	fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
>  
> -	if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
> -		!= (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
> +	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
> +		!= (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)
>  	) {
>  		return false;
>  	}

Since you're editing this if statement it's preferred that you tidy it
up according to kernel standards that'd be:

	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) !=
	    (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION))
	    	return false;

Thanks,

ET

      reply	other threads:[~2026-03-02 21:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 18:53 [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing Jose A. Perez de Azpillaga
2026-03-02 21:12 ` Ethan Tidmore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGSLTL0V29WY.10JGCNINX01CP@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=arthur.stupa@gmail.com \
    --cc=azpijr@gmail.com \
    --cc=bryant.boatright@proton.me \
    --cc=gregkh@linuxfoundation.org \
    --cc=knavaneeth786@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nikolayof23@gmail.com \
    --cc=tanjimkamal1@gmail.com \
    --cc=william.hansen.baird@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox