* [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing
@ 2026-03-02 18:53 Jose A. Perez de Azpillaga
2026-03-02 21:12 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Jose A. Perez de Azpillaga @ 2026-03-02 18:53 UTC (permalink / raw)
To: linux-staging
Cc: Greg Kroah-Hartman, Ethan Tidmore, Navaneeth K, Nikolay Kulikov,
Bryant Boatright, Tanjim Kamal, William Hansen-Baird, Artur Stupa,
linux-kernel
Fix spaces between bitwise OR operations rtw_action_frame_parse() for
better readability.
Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index dbd4bcc8cd28..446e4051b9ae 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
- if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
- != (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
+ if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
+ != (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)
) {
return false;
}
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing
2026-03-02 18:53 [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing Jose A. Perez de Azpillaga
@ 2026-03-02 21:12 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-03-02 21:12 UTC (permalink / raw)
To: Jose A. Perez de Azpillaga, linux-staging
Cc: Greg Kroah-Hartman, Ethan Tidmore, Navaneeth K, Nikolay Kulikov,
Bryant Boatright, Tanjim Kamal, William Hansen-Baird, Artur Stupa,
linux-kernel
On Mon Mar 2, 2026 at 12:53 PM CST, Jose A. Perez de Azpillaga wrote:
> Fix spaces between bitwise OR operations rtw_action_frame_parse() for
> better readability.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index dbd4bcc8cd28..446e4051b9ae 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
>
> fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
>
> - if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
> - != (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
> + if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
> + != (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)
> ) {
> return false;
> }
Since you're editing this if statement it's preferred that you tidy it
up according to kernel standards that'd be:
if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) !=
(IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION))
return false;
Thanks,
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-02 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-02 18:53 [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing Jose A. Perez de Azpillaga
2026-03-02 21:12 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox