From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D84A01A6817 for ; Mon, 2 Mar 2026 21:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772485947; cv=none; b=RBlxD4HsaPSjVkhcWOXM87BMv5rkvhD+rUMv4YaiDPMWpAE+np1bPR8AW2Ffp8qz11E1zLyguYL1WvA16iPBTOtZ5cmmZExy1oCh6NIFydj8aTHMZdjSf/jg6IdXuUXMUIbSJJX/AKMeXs3Vl9i4d1QgqY7gjIeUN/LNapOao8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772485947; c=relaxed/simple; bh=2xFHj/UE82dqOU8pH0QS7JyYvEMtTH3P1lQF2rciO5g=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=QcFio3TU9/E/pcR1wd2WSuEWcRahBa6Ts4zgHq6560X5bcxVoDjo/uBtPbaWQptcxKMrMphozcaxfp/DjmwmxDemRpDGilQbl6LSHE45FlL3sQQ0v7gNl6te84Lx9q6aHCK+rgL/cG5hQVoo+PSPQqWpkl5DYJZg+pI8xV0JrvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M60aj22m; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M60aj22m" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-64c9a398bc7so4709450d50.2 for ; Mon, 02 Mar 2026 13:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772485945; x=1773090745; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MBja4YTvutTMTWbavEca/yFJrkw/+ippPZq5wl27/UY=; b=M60aj22mmx+c/szB4X/qXUjRlaXU6r7NUZ5LsL+rq+OK3qIIQ/oYJnm/+ngkb6zhi0 3e9KnuP91mdRL5lJQnvKKic73sONUFY6vSWfRkZOeUopvC8LL/1SIcD7u8L2Byi8S0xI wtnkGv4y2wgBSfYv0aqbbkJ0qX7cwLmc3Br90Q2hIP/wuaJLNu5atDIYJI7mrnu5thC7 ei6H6ULMgBqhukkVZzx1UwtB3W8U99LrmG6qCkXKA8GZjA/UBFpBuAJvjcfEgvFIpsr0 +Hun/pXB7yVF4+kvp1hBJvfOqzsKTg8g7RzugJrcnfD553+7pWbfmyL7bIkE5O00f80n ORGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772485945; x=1773090745; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MBja4YTvutTMTWbavEca/yFJrkw/+ippPZq5wl27/UY=; b=LWKl7mPNgdJGGYLVUeTgNW8+VQ1HFZ1YWS46vpPySVSEXAVrAkEKqNJdYUFVTL9zSU 6Ue7gRi96ncA54Ei7tWTDzADUT0p8DftOLOVlySmYq85qp0SGvl9Kw6GInnFVj+MQdBn Mh+sNiILbPRgJ/EEIURsC3Ea+NFVDZvmiF6I42/4Htn4AjqA6lGjdbd9VrKuyEbe1FOp wM6nKn0+tP1vNtgK7A1OkMEs2M0MgnV7btzP+IB8+n1FzRhYBO2PCtZu5YSA1fylbzo2 maJVbw0Ku7mqhX8zbNCJJRl6P9/1yZKxq7H3JKCwbPLVlcmmm5E9+VeA+OazH6o05OhX ssng== X-Forwarded-Encrypted: i=1; AJvYcCVEOedVzIahQV9ajUjDLQ4JIBTl5l/sFoigOSzUMB24GP/ZUk1qw33GjN+n/BmF+HAVYvjczAUfHkBNguw=@vger.kernel.org X-Gm-Message-State: AOJu0YwqgdFreJ6pENDj+8yXwMq+f2hgE9a8aT8obqCOcTnGzaSIM4sx v4zraMvN90psWd8qZN/pqeVXq4QUH5e9TZJfqffTJy2qI0GM1yhrF4Ze X-Gm-Gg: ATEYQzysknKpk4XlUTcrhbtkBZEOLWKA5UxZIxIwJauL51bbzuXlRCa112C4wqT82XS mX2d1sBaIR2Tvt5/5OEHlRyfqxNpfPDkf4U/oUqWaLlt3kmky/kT2FyOT2xN2FGJimsEJYFNJYp chCz95qt75Ex6ILzwyo5DblyOZEQxNwBXtA6fo41WtyrpcfdmdAadxxDsCAfIzC85aFnpH6pnDx eP6Jcb6EXjZe7Z0J6KbyGW/X0H45/FzaPfGJf+HN+bcrW1THKTxTI+jhJi4JXs6VY8Nnkw9SWPL FhwsUkAJPzNzyNO0EqUrjvBqzzFSPN+p3quSYJUJ7jDmYM180tF7plNEihhNWG6TYp/xPPQg1N+ HBwPHkN0g+zfJpi1jAsOvQuQy98UeKYCCcQq2/Wx5stgESsTDN+WDdTQpmSKBAKwewwRVFfpQOa Q5i1xDTKw8gHggH4mKHdiG9IdC5PAYAY44/IUtRHVrJhP6C7U2/0bYn1KG+DvzKfu11XAyeb+iQ RMzizA4ZpV0nNsqwywWHMUVl5Q6iUrw X-Received: by 2002:a53:e319:0:b0:646:a1ba:7168 with SMTP id 956f58d0204a3-64cc22cd0c4mr8569028d50.67.1772485944721; Mon, 02 Mar 2026 13:12:24 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7650ac4sm6009842d50.21.2026.03.02.13.12.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 13:12:24 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 02 Mar 2026 15:12:05 -0600 Message-Id: Cc: "Greg Kroah-Hartman" , "Ethan Tidmore" , "Navaneeth K" , "Nikolay Kulikov" , "Bryant Boatright" , "Tanjim Kamal" , "William Hansen-Baird" , "Artur Stupa" , Subject: Re: [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing From: "Ethan Tidmore" To: "Jose A. Perez de Azpillaga" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260302185340.61540-1-azpijr@gmail.com> In-Reply-To: <20260302185340.61540-1-azpijr@gmail.com> On Mon Mar 2, 2026 at 12:53 PM CST, Jose A. Perez de Azpillaga wrote: > Fix spaces between bitwise OR operations rtw_action_frame_parse() for > better readability. > > Signed-off-by: Jose A. Perez de Azpillaga > --- > drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/sta= ging/rtl8723bs/core/rtw_ieee80211.c > index dbd4bcc8cd28..446e4051b9ae 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > @@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 fra= me_len, u8 *category, u8 *act > =20 > fc =3D le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control= ); > =20 > - if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE)) > - !=3D (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION) > + if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) > + !=3D (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION) > ) { > return false; > } Since you're editing this if statement it's preferred that you tidy it up according to kernel standards that'd be: if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) !=3D (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)) return false; Thanks, ET