* [PATCH v2] staging: rtl8723bs: fix bitwise OR operator spacing
@ 2026-03-02 21:51 Jose A. Perez de Azpillaga
2026-03-02 22:03 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Jose A. Perez de Azpillaga @ 2026-03-02 21:51 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-staging, Ethan Tidmore, Dan Carpenter, Nikolay Kulikov,
Bryant Boatright, Siwanan Bungtong, Abraham Samuel Adekunle,
Artur Stupa, Navaneeth K, linux-kernel
Fix spaces between bitwise OR operations rtw_action_frame_parse() for
better readability.
Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
---
v2:
- Remove curly braces for single-line statement
- Move `!=` operator to the end of the first line
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index dbd4bcc8cd28..9c1ee1411c9b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1123,11 +1123,9 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
- if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
- != (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
- ) {
+ if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) !=
+ (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION))
return false;
- }
c = frame_body[0];
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] staging: rtl8723bs: fix bitwise OR operator spacing
2026-03-02 21:51 [PATCH v2] staging: rtl8723bs: fix bitwise OR operator spacing Jose A. Perez de Azpillaga
@ 2026-03-02 22:03 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-03-02 22:03 UTC (permalink / raw)
To: Jose A. Perez de Azpillaga, Greg Kroah-Hartman
Cc: linux-staging, Ethan Tidmore, Dan Carpenter, Nikolay Kulikov,
Bryant Boatright, Siwanan Bungtong, Abraham Samuel Adekunle,
Artur Stupa, Navaneeth K, linux-kernel
On Mon Mar 2, 2026 at 3:51 PM CST, Jose A. Perez de Azpillaga wrote:
> Fix spaces between bitwise OR operations rtw_action_frame_parse() for
> better readability.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
> v2:
> - Remove curly braces for single-line statement
> - Move `!=` operator to the end of the first line
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-02 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-02 21:51 [PATCH v2] staging: rtl8723bs: fix bitwise OR operator spacing Jose A. Perez de Azpillaga
2026-03-02 22:03 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox