From: "Benno Lossin" <lossin@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"Gary Guo" <gary@garyguo.net>, "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Janne Grunau" <j@jannau.net>,
asahi@lists.linux.dev, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rust: pin-init: internal: init: remove `#[disable_initialized_field_access]`
Date: Thu, 05 Mar 2026 09:05:40 +0100 [thread overview]
Message-ID: <DGUOZ3GDF3D4.3CBJGK1S3DPCO@kernel.org> (raw)
In-Reply-To: <CANiq72kNdc7=-uoWXBpxkn2No6-Z0hVnx_yWMNphyTVscsMkUA@mail.gmail.com>
On Wed Mar 4, 2026 at 1:26 PM CET, Miguel Ojeda wrote:
> On Wed, Mar 4, 2026 at 8:00 AM Benno Lossin <lossin@kernel.org> wrote:
>>
>> I figured that we can't really "close" a Zulip topic (we can mark it as
>> completed, but that topic was originally about the field accessors, so
>> not sure if this makes much sense.
>
> Using Link: instead of Closes: is supposed to mean that only part of
> the issue is fixed, i.e. whether you can "technically close" it or not
> is not important (e.g. Closes: to an archive like lore.kernel.org are
> very common and actually what the docs mention as the first use case).
>
> So I would say Closes: should be the "default", and Link: is for
> particular cases where an actual issue (or message) carries several
> topics and could be confusing to have several commits with the exact
> same Closes: line.
>
> In the case of Zulip, we can link to particular messages in a single
> thread, so typically it is possible to use Closes:, though the current
> UI isn't great to see where exactly it was linked to... :(
>
> Anyway, I guess the inspiration was the similar feature from forges,
> and perhaps in case someone has a custom tracking system that actually
> auto-closes things in a forge, but it is a bit confusing. Having
> allowed "# ..." for Closes: or a similar Closes(foo): instead of
> reusing Link: may have been better.
>
> I hope that helps!
Yeah that explains it, thanks!
In that case you can make it a closes tag when picking.
Cheers,
Benno
next prev parent reply other threads:[~2026-03-05 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 14:04 [PATCH v2 1/2] rust: pin-init: internal: init: remove `#[disable_initialized_field_access]` Benno Lossin
2026-03-02 14:04 ` [PATCH v2 2/2] rust: pin-init: internal: init: document load-bearing fact of field accessors Benno Lossin
2026-03-02 14:14 ` Gary Guo
2026-03-02 14:20 ` Miguel Ojeda
2026-03-02 14:48 ` Benno Lossin
2026-03-02 14:09 ` [PATCH v2 1/2] rust: pin-init: internal: init: remove `#[disable_initialized_field_access]` Gary Guo
2026-03-02 20:06 ` Janne Grunau
2026-03-03 11:31 ` Alice Ryhl
2026-03-04 6:59 ` Benno Lossin
2026-03-04 7:06 ` Alice Ryhl
2026-03-04 12:26 ` Miguel Ojeda
2026-03-05 8:05 ` Benno Lossin [this message]
2026-03-06 10:07 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGUOZ3GDF3D4.3CBJGK1S3DPCO@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=asahi@lists.linux.dev \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=j@jannau.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox