From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Harikrishna Shenoy" <h-shenoy@ti.com>,
<Laurent.pinchart@ideasonboard.com>, <airlied@gmail.com>,
<andrzej.hajda@intel.com>, <andy.yan@rock-chips.com>,
<aradhya.bhatia@linux.dev>, <devarsht@ti.com>,
<dianders@chromium.org>, <dri-devel@lists.freedesktop.org>,
<javierm@redhat.com>, <jernej.skrabec@gmail.com>,
<jonas@kwiboo.se>, <linux-kernel@vger.kernel.org>,
<linux@treblig.org>, <lumag@kernel.org>, <lyude@redhat.com>,
<maarten.lankhorst@linux.intel.com>, <mordan@ispras.ru>,
<mripard@kernel.org>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>, <s-jain1@ti.com>, <simona@ffwll.ch>,
<tomi.valkeinen@ideasonboard.com>, <tzimmermann@suse.de>,
<u-kumar1@ti.com>
Subject: Re: [PATCH v10 5/6] cadence: cdns-mhdp8546*: Change drm_connector from structure to pointer
Date: Mon, 09 Mar 2026 18:55:27 +0100 [thread overview]
Message-ID: <DGYG0UBEFW5W.29YB9R2AM8GZM@bootlin.com> (raw)
In-Reply-To: <20251209120332.3559893-6-h-shenoy@ti.com>
On Tue Dec 9, 2025 at 1:03 PM CET, Harikrishna Shenoy wrote:
> From: Jayesh Choudhary <j-choudhary@ti.com>
>
> Now that we have dropped the legacy code which became redundant with
> introduction of DRM_BRIDGE_ATTACH_NO_CONNECTOR
> usecase in driver,we can cleanly switch to drm_connector pointer
> instead of structure.
>
> Rename the connector_ptr member variable to connector for clarity and
> consistency. The driver was using both connector and connector_ptr members,
> but connector_ptr was the only one actually used throughout the code.
> This change removes the unused connector struct member and renames
> connector_ptr to connector for better readability.
>
> This is purely a code cleanup change with no functional impact. All
> references to connector_ptr are updated to use the renamed connector
> variable throughout the driver.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-03-09 17:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 12:03 [PATCH v10 0/6] MHDP8546 fixes related to DRM_BRIDGE_ATTACH_NO_CONNECTOR usecase Harikrishna Shenoy
2025-12-09 12:03 ` [PATCH v10 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Set the mhdp connector earlier in atomic_enable() Harikrishna Shenoy
2025-12-22 12:54 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 2/6] drm/bridge: cadence: cdns-mhdp8546-core: Add mode_valid hook to drm_bridge_funcs Harikrishna Shenoy
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 3/6] drm/bridge: cadence: cdns-mhdp8546-core: Handle HDCP state in bridge atomic check Harikrishna Shenoy
2025-12-22 12:56 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 4/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge Harikrishna Shenoy
2025-12-22 12:57 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli
2025-12-09 12:03 ` [PATCH v10 5/6] cadence: cdns-mhdp8546*: Change drm_connector from structure to pointer Harikrishna Shenoy
2025-12-22 13:02 ` Tomi Valkeinen
2026-03-09 17:55 ` Luca Ceresoli [this message]
2025-12-09 12:03 ` [PATCH v10 6/6] drm/bridge: cadence: cdns-mhdp8546-core: Reduce log level for DPCD read/write Harikrishna Shenoy
2026-03-09 17:55 ` Luca Ceresoli
2026-02-18 9:34 ` [PATCH v10 0/6] MHDP8546 fixes related to DRM_BRIDGE_ATTACH_NO_CONNECTOR usecase Beleswar Prasad Padhi
2026-03-09 18:08 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGYG0UBEFW5W.29YB9R2AM8GZM@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=aradhya.bhatia@linux.dev \
--cc=devarsht@ti.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=h-shenoy@ti.com \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=lumag@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mordan@ispras.ru \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox