Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention

Danilo Krummrich
2026-03-12T19:16:17Z

On Thu Mar 12, 2026 at 7:45 PM CET, Cheng-Yang Chou wrote:
> Hi John,
>
> On Tue, Mar 10, 2026 at 06:34:51PM -0700, John Hubbard wrote:
>> On 3/9/26 11:24 PM, Cheng-Yang Chou wrote:
>> > - name: c"nova",
>> > + name: c"nova-drm",
>> > desc: c"Nvidia Graphics",
>>
>> hmm, as long as we are fooling around with names here, I see that
>> this should be "NVIDIA Graphics and Compute", really.

SGTM.

>> > kernel::module_auxiliary_driver! {
>> > type: NovaDriver,
>> > - name: "Nova",
>> > + name: "nova-drm",
>>
>> Well, but now it is out of sync with the file name: nova.rs.
>>
>> You should change both, or neither, I'm thinking.
>
> I think renaming the file to nova_drm.rs would better reflect the
> driver's identity now that the module name is nova-drm, making it easier
> for readers to associate the source file with the driver.
>
> Would that work for you?

I think the module name should ideally match the directoy name, i.e. we have

drivers/gpu/nova-core/

with the module name "nova-core" and

drivers/gpu/drm/nova/

with the module name "nova-drm".

The reason why this is not .../nova-drm/ already is that I figured it would be a
bit redundant given that "drm" is already part of the path.

While I don't mind changing this, I wonder what this would mean for the
Kconfig, CONFIG_DRM_NOVA_DRM? :)