From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Ethan Tidmore" <ethantidmore06@gmail.com>,
<alexander.deucher@amd.com>, <christian.koenig@amd.com>
Cc: <airlied@gmail.com>, <simona@ffwll.ch>, <lijo.lazar@amd.com>,
<superm1@kernel.org>, <mario.limonciello@amd.com>,
<cesun102@amd.com>, <Leo.Lin@amd.com>, <Jammy.Zhou@amd.com>,
<amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/amdgpu: Fix resource leaks
Date: Sat, 14 Mar 2026 13:36:49 -0500 [thread overview]
Message-ID: <DH2Q18KB89QO.21OU5SNECAXMG@gmail.com> (raw)
In-Reply-To: <20260225145154.14168-1-ethantidmore06@gmail.com>
On Wed Feb 25, 2026 at 8:51 AM CST, Ethan Tidmore wrote:
> There are multiple resource leaks due to ioremap() being used and
> iounmap never being called in multiple possible error paths.
>
> Change ioremap() to devm_ioremap() to fix all resource leaks at
> once.
>
> Detected by Smatch:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4834 amdgpu_device_init() warn:
> 'adev->rmmio' from ioremap() not released on lines:
> 4539,4549,4563,4574,4592,4834.
>
> Fixes: d38ceaf99ed01 ("drm/amdgpu: add core driver (v4)")
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
Friendly ping.
Thanks,
ET
prev parent reply other threads:[~2026-03-14 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 14:51 [PATCH v2] drm/amdgpu: Fix resource leaks Ethan Tidmore
2026-03-14 18:36 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH2Q18KB89QO.21OU5SNECAXMG@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=Jammy.Zhou@amd.com \
--cc=Leo.Lin@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cesun102@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=simona@ffwll.ch \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox