From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE64241686 for ; Sat, 14 Mar 2026 18:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773513412; cv=none; b=tEY823hhcQDLfrdo46qUe2syK/dwyY4LTt+o3iscGd0BZKjeNAFsQjGJiMLRtjf+u6i06q6RkPpdOSjrJd6Lc50HHp9HKfHD55SCS30vI/DvbCGkuqIKj8EL1RkvwtUT/W360O8ctX3xcWarUWSYFutEGi2JhYiM9wLEbjLGTBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773513412; c=relaxed/simple; bh=j3EyIw04VNf2/EW2NiDs8upBgwGalbT+ND5YbBpTgmE=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=s/JeoTTr9+2wwJMW8RZ8v4rfyppD7oFmYJupZtx8bmjDFhdk0i8AR1M+m14q/LwyJGRWfVcylb8d9dHXFKn2Bjy8uU80A08JNPNN7TXmunHIFHK0EhOImBE2a77xQQgktkMqyRFjfJ2dnbcclYAyKqzu/tJaU+GXO6roufT2V1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BxK/4lJ5; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BxK/4lJ5" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-7986e0553bdso27569377b3.2 for ; Sat, 14 Mar 2026 11:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773513410; x=1774118210; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j3EyIw04VNf2/EW2NiDs8upBgwGalbT+ND5YbBpTgmE=; b=BxK/4lJ5PMrwH00D4tMopUy9VxwBDxdkvYgCWwtODmWKw7Mvkj3K/yNtK3IcVPCoq2 G01/1Pw0Xjy0xM+wDnoJfTAGiO7iOyyq9JGLRvI2SFJOozYltOIDEWL4hxVuEvbMHl7u Kz7dp+WeAaQArc4T5Py/W9Kva9lAkLunJJcE7Y0PMKRq9sqi+S904AmoSx9UFDZKD/BG q/FdqkG7lUjXABdo3mpduLSXc11GAhs9oQfgPKs5jCHYrT8RC8HbrlursEOuQl12osLN 76P0iI8gSs1pVSRypViygCQoG9erR3JaEPy2/k58t4G6QkNmdtJS7zHIy3x728jdFENJ U6dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773513410; x=1774118210; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=j3EyIw04VNf2/EW2NiDs8upBgwGalbT+ND5YbBpTgmE=; b=SVarrFsKKNakvsaFG8rxBvzToY3UP9ItEv265L1F0gwOBzFyFhQsT8QVokSVCv1xBO e4yXpMa+1SYsuuW8eY/iNbGmfatTJN/FJY51Lqy0c2WgYOw9WeI6tn7/7IbPeSysHMNR 0/l8zNbxHySRlOltgIFCo+cpLMKJ2PahdshRSCpaLmaAk1v9DrO+3fbXlaJdWrKiAitl ySu696HuzA0pYii1bAgziuUIx6w+gGEg1v4MQ1Mygw51LO0cVU4MMPu7WKOp9Yqz+hSy qy/geHPrbck9AItMTaPHGZlo32Hkkd/6vK9LrtXNRD33Nqw2+cWvghHIkahlulaI5nJW M/hw== X-Forwarded-Encrypted: i=1; AJvYcCXMjMnkx2g+svjMfXDmvX0iUIJUeXjji15vkyMSMIEkuamEEyujYp6zfQSHcT60++6KAsGa6OenoFQUdWw=@vger.kernel.org X-Gm-Message-State: AOJu0YxRbLsgdlaX6vHcEeP6v5AJ003SoaTOQxp+4rIpS/l2FGqVfXsQ squLvJiHRQjoaIFmmygPEoGIFpVsth2s40zT+D9Vi/k/cpHo2FtNUFpU X-Gm-Gg: ATEYQzwlAQ+yceQpmoA15t7lvunUTJBgDEAsiQLhMWyGZ8pG0ePUFKpB157hz1/PaLs Zjw0Lz4JsIHgSQJyjQbg34hc7qO3BCHbB7+7sDq4XueXDMaOFxLG+mXmNS9uEJPImt4JT1xOHEp U+BprQqS6bcp2DTZJYmXrbU0WBxmbP8pKJdwytRLWt2++I2Q7Rtxko3E/TaSb0iAfxX4ldQBTbT 7vKmac+d4x3OPYoxPMSfEmxfSZFXmMAGjaG4BR27zI2cD50mSkh/Xu+Kgs9Zp7WErVLNXSVKAht qrs3l6/DCHXqgSJxbTQTQkhQ3J7qYpygv1x4z+STEQBZiW9T55cM8ADmYPgtXnGY9fAmG34OHkA XLTvQGH0vQvyM00RUiGedYnAELiO+/PDLPdqelz/pVoAKmXI+jXpg8ZJbiBQGj3iPgDT+HIx9H0 HvpxEdKyPAmghg72vT7u09FtWCoMZBqoqBm+T0+sGlIumxIjibRrV48gnWP5rcREJaj5goRPm8x xR0yPlmwbCKpaJDYXBCqc/8BV2fL1m2CsVi5wZ2ER8+5BYG5klPFuKkXjkwcGefdfQ= X-Received: by 2002:a05:690c:260c:b0:799:266:83e3 with SMTP id 00721157ae682-79a1c1d2627mr78752297b3.50.1773513410298; Sat, 14 Mar 2026 11:36:50 -0700 (PDT) Received: from localhost ([2601:7c0:c37c:4c00:f174:ec69:bc86:8883]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79917f2a268sm64415117b3.47.2026.03.14.11.36.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 11:36:50 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 14 Mar 2026 13:36:49 -0500 Message-Id: From: "Ethan Tidmore" To: "Ethan Tidmore" , , Cc: , , , , , , , , , , Subject: Re: [PATCH v2] drm/amdgpu: Fix resource leaks X-Mailer: aerc 0.21.0 References: <20260225145154.14168-1-ethantidmore06@gmail.com> In-Reply-To: <20260225145154.14168-1-ethantidmore06@gmail.com> On Wed Feb 25, 2026 at 8:51 AM CST, Ethan Tidmore wrote: > There are multiple resource leaks due to ioremap() being used and > iounmap never being called in multiple possible error paths. > > Change ioremap() to devm_ioremap() to fix all resource leaks at > once. > > Detected by Smatch: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4834 amdgpu_device_init() warn= : > 'adev->rmmio' from ioremap() not released on lines: > 4539,4549,4563,4574,4592,4834. > > Fixes: d38ceaf99ed01 ("drm/amdgpu: add core driver (v4)") > Signed-off-by: Ethan Tidmore > --- Friendly ping. Thanks, ET