From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50DE737C115 for ; Sun, 15 Mar 2026 21:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773610584; cv=none; b=JG1DWrjmvHf47407ILd/a1eaVuUccrsIjQi4KNm8j0gaxTwi1ud0CD4Aez+WX6I7HLOETazHjEydegpfsLQhyJC/khJxagqPKGwJOrIqMU0KVRFBp7Oi2dFwmKJRNgvj1vtuUYNERMlL7n+x/Oogc+l3JhDr/5CFsWY92FqB4P4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773610584; c=relaxed/simple; bh=kXRfqT68qZGulaiSJSbzKPkSGjBgNmbvE8WonQAUAa4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=BkDH/dQXLUpX72qkycVKpHqNEQ0bNpMbjRv9UGAHyeONb76DTiHWdW+H17ift7z11rBdHe5GrHrfQ52WlIEsWEYjqqVNnm+jdsUGPLRkf9abWHip43JndDb6ifoNciQDR/HWKbCk2ZjJ2EHf7fwGdA17PIM234EHDjW45g+GBRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JabU3UBu; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JabU3UBu" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-79801df3e42so49788227b3.0 for ; Sun, 15 Mar 2026 14:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773610582; x=1774215382; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v2Bq+5FEE7iFPrtOxsOCAb6k7KUXWiu5PqPdfBRrFhI=; b=JabU3UBuLDz9tgh8aIJ1b50NdtdMHaBSgl5TscD7RWHg1tNd1R9791hiSHdPcVjkfK kO4fI3CENrDwkasPGtS1DtMREL+S/myPb4Tl/1VYlEf1ZIHOhVZ1Zl8OA7v2L7jfv56s hPzSBJ6ZqKJy77x7d+StKY2i3iMj+AfptMgMP+fwjU6xYIGd5cuQoErSHGk1G6eBezEe Ui6GJfBmLKgAbMfxca8AwxRRhOEsczIYaa4Ti0okfsDukMybF3knv7fsq1nrttmzDwY6 cjD3y2X27J4+/9KLu6Vy49fQcTP7pomw2u33vjS6e3jDEf7yfQ5Ncpmlf0t1cc1VMACT up2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773610582; x=1774215382; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=v2Bq+5FEE7iFPrtOxsOCAb6k7KUXWiu5PqPdfBRrFhI=; b=aQyh2r+x1c3dcqwZPG7zsUG65zQab3OQ6iaFo+/KJNHyD+l3su08eC4iy0f7U2uwxj 7qL+BdUoCkVYnCpsjSZiPFJl9ZEoiO1IkBljfWnBtWsgzCvBic2mHMykBPLHaRHi9+w2 9L7V5m6q/2UQJQ3aWbDfXutux5HkXHzhIYVyJKhQo1KNGL/HJUWkua3BxOhwGUWTOPhj dUkE1taGG1BFaTn4EMcf+14JwZReO9Zqw8Wa28Tp1Nay+Z1WWVwgdqc4b4Dk9aNWlPoZ c+DrthY4nJg0sXbwfLu6l1o/WEbb/eXFMG7V58acXG5NkSCaRRIoUO7Tns82U3ZZVGEb yQ4g== X-Forwarded-Encrypted: i=1; AJvYcCV/WQSOYglIiK5DjKlNH1ixdov1EThzufl/A4AM2lmqO5qf8HauS1JvDmbE3Sbms8R3OoxK9RIfpXS4S98=@vger.kernel.org X-Gm-Message-State: AOJu0YxdVDpYmkp78KYKis7bweorBf0OFXTQLNAcruLaBIcyKs8TFGC3 ENVq31L/q8lGSkkepiUvu87w2WuG2CyV3GhXH3E/S9Xh58X0AkSDeOQi X-Gm-Gg: ATEYQzxRR2yNmgMlPIlcPqMKcMdMLVr0Yfpdpu195nAAHAC1uEQHrikr5j1svfAOar6 kBxzW545nk5zvFoQ62YdQuLukDHGw8goJwtSPiyng2SSAqtINiLTQugu1EVq+OhgzHHSqKR6VOh nSc0+13PB17rMiYUNaNxc1AjyLMSM69V+3ptGvM8VMWx2wn4y53bvFtGFwdmv09nqxjkCzFlF4a VVXAFQNNGiElRP4bySB53UUORp5n1tA8BuPZNtA0uXgsomRJoAq5/tNN8F4QYhYJjZSTptEq0FW fvbgAWN8ald1+ZJbZSJFBnSzSIzCrpBLaf31NPFXzFOuewETLSbuU6F4jScrUdmarSCkFLC0AZ+ kC/KKnHS6ifN+m3a7occWksULqLB2PJkWUjeD22btAuxscfQ1iw3GipsbU0xMQM0EEMu67BTSro Y8I1hgltoUjgCpo2pkKCfbWDuvqtwYXIqkEtpV89Vw27mx/Y0B7jmFtZmmWo7w077ffZFCew/2l YkJWCHa9xFWUt4pQgGoRbUZ8gHJk/3G/z/j+dr57mQ= X-Received: by 2002:a05:690c:c4fa:b0:79a:3be7:81a8 with SMTP id 00721157ae682-79a3be7b453mr41739997b3.6.1773610582304; Sun, 15 Mar 2026 14:36:22 -0700 (PDT) Received: from localhost ([2601:7c0:c37c:4c00::5585]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79917e1df14sm77283697b3.17.2026.03.15.14.36.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Mar 2026 14:36:21 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 15 Mar 2026 16:36:01 -0500 Message-Id: Cc: "Minu Jin" , , , "Oarora Etimis" Subject: Re: [PATCH] staging: rtl8723bs: Use kmemdup() to replace kzalloc() followed by memcpy() From: "Ethan Tidmore" To: "Oarora Etimis" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260315194738.154324-1-OaroraEtimis@gmail.com> In-Reply-To: <20260315194738.154324-1-OaroraEtimis@gmail.com> On Sun Mar 15, 2026 at 2:47 PM CDT, Oarora Etimis wrote: > The kzalloc() function allocates memory and zero-initializes it. > However, in rtw_cfg80211_set_wpa_ie(), the allocated buffer is > immediately overwritten by memcpy(). This makes the zero-initialization > completely unnecessary, wasting CPU cycles. > > Use kmemdup() to simplify the code, eliminate the redundant memcpy(), > and remove the unnecessary zeroing overhead. > > Signed-off-by: Oarora Etimis > --- This doesn't apply to staging-next. > =20 > - memcpy(buf, pie, ielen); > - > if (ielen < RSN_HEADER_LEN) { > - ret =3D -1; > + ret =3D -1; > goto exit; > } > =20 Also, this is a stray change. Keep one logical change per patch. Thanks, ET