From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D999732B989 for ; Mon, 16 Mar 2026 22:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773700030; cv=none; b=KVwroBP2Z8bXJH+AokA5BpHXJpHbK2oA8Bfu7ajfqeaat4OtXmgxUbKD9bQ+rBo5yQZzIrK99fSCFRKHn4wdydXFjuz/xcxbOAr+nAiUaoajlCsa3WUwvBoCXGYNq+FQo4jk1rrLtf10YGWZYRwQHtj+FyeV+tIhbWQZC+se/Uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773700030; c=relaxed/simple; bh=jBZmhUNlR1riuyc6gZVRgUoB8mRPDHdt6UlCO8EACCY=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=uB0ddp//0DRqYusABCLRfbv3IEtGfsk8Gk+QyflOR4SsLBUuCx8d03GfvchABG1D0J5njBVavDmyObvR5oBdsjVTCNXkZAn3EPGIGDGEkqbQ07yHPm7MxH0kzcxi8BFbeonlBwf0NUHLv9KMhM5JB3+TMVz+fofuopUicf7FZRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UJURzXDT; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UJURzXDT" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-64ca6595c8aso4907951d50.0 for ; Mon, 16 Mar 2026 15:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773700028; x=1774304828; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K7QBXKMJPlEyHjnfjvFJZVoF7egncVTdmwMHU1kbkE8=; b=UJURzXDT//ePdatBOdPXDfQxymoMAf7jSO5Rjt1ziWUA2DOtlhj65t23+FIKQbdB7T FrDU83sRgjOLw4TdxrpAU7NHsKn3oJrkmvv4qVaMzEmgmU9BxuU/3rPmhNwQfhrsrG8P dMLxs7kEYvsBZ3eJKCLKOJers1uUThGoV5HOqBcKXMDxqhtbUe0wwFXq3uZtU/SxurRR WrzADXGobIt1O3yMZ17AdQJZSUTfGMGsXNCn6eqK9ckyM++J89TlXOV0QahzhZBrp+Hs +e2ik3sIetahuH6SOpHik9KeJwUiOoR7u+g8Bahm1AqJi36QNn+OS3GbKyEVKB9Z6knn Uv1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773700028; x=1774304828; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K7QBXKMJPlEyHjnfjvFJZVoF7egncVTdmwMHU1kbkE8=; b=Waei6/P94f86O2kT5ERJMG1nuv7jsTUBuNLAQ+ueGxLdHFDTA1cYrvy0aJ94CVLi4t +Ej/8XW9YAIBWMUlwJHG5gzd91FCnmrKOy5ywUd/HaIEjA5bCLEE5AqNqznbfXqL+K7D d8t0/t7kPxQPxUFfdt8ErrP+LNkBOr8QU0wCLrx4LTzm0t8NnxnMZ+aZBkOTPXLPhzxp X68JohvbRHxbNE2FAkI3fPomJtkzg/OxgyuN/zDV8ntq8bXBV2vsWEI21USVJiNuHC86 gWxOm2eW+Fb+ZqG9uLowYwYz+PHs2e4iLT6o0H0ZC1bWwYi5WUMSA9f+0lLyPLJnGXe4 Uz2w== X-Forwarded-Encrypted: i=1; AJvYcCVbTQik7e1UgY9D+W0z9XFZaiGae38Vsio1XnOmJ6oDyjE1OpBxlmxTTRVxIws7qBdeJX8Qe7gfW+qfoqQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6LYNroE9i/NMnHzBXMRn1ACCpJeuDTreaoaaz9ccmUYqrEdi1 tMZg1BsOwcB+SxiCnQMaB8bAcCL7CO0TGMQ1iebcw08wYQPwjl2bD0H6 X-Gm-Gg: ATEYQzw3//0CuXjDckk5BPbSQQLjBfXZeXavc+NNMKp5umBMoQFEcmkBeU90aJ8J9eH oM7p4Me69v+QeSvsMMRlXh3mC5LD3bRdjr9kyvDJLFEyNpGBaNVM8p2z8MpA7kcTLBYSmQ+t2ff JZHHaqTVYlGSiXe35Xz0z/ZQoVqTwW81kK2FbKXP3aL3VSw9PAMzSsmnGLytLyhsLoNsujF965K S1W58tuu0zjXzpCc0fSOb0V+CT57G0D04y6D8/Gb8KGMgn4yOPH0F9dk3+Njd4XJpinmqZTDdu9 zwulsPlTgtC4X+U5zFSpKV0mcJgnXI1RQD9KvZ7hoEa+rQUdcKyj2MMOR2H/vlY4SsQ3Qa8JObA 8kNFGVKehXNJs1T6ULyGQSq6vf4/Agiov3ppw3S09Q9EScxT/JLQs46Ss795G6X7NHc73uejRtQ lUx9ENeuzFTopSptYq3nOz+JC9Ut3/l1YDIxLXmdTE4VI7eb+/tOQGPU0Ds48PQkwmFBQSpLhYx ynqw28wcOLKfA9MXedXE0lteJ+cmWoX X-Received: by 2002:a05:690e:44a3:b0:649:b2cd:eb7d with SMTP id 956f58d0204a3-64e630ae9eemr10408251d50.68.1773700027765; Mon, 16 Mar 2026 15:27:07 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e65a5411dsm6388301d50.9.2026.03.16.15.27.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 15:27:07 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 16 Mar 2026 17:26:46 -0500 Message-Id: Cc: "Ethan Tidmore" , , Subject: Re: [PATCH v2] staging: rtl8723bs: remove unused global efuse variables From: "Ethan Tidmore" To: "Marcos Andrade" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260316220435.2249-1-marcosandrade95963@gmail.com> In-Reply-To: <20260316220435.2249-1-marcosandrade95963@gmail.com> On Mon Mar 16, 2026 at 5:04 PM CDT, Marcos Andrade wrote: > Remove several global efuse variables from rtw_efuse.c and their > corresponding extern declarations in rtw_efuse.h. > > These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely > unused legacy code. The driver currently maintains the efuse state > properly within the 'efuse_hal' structure, which is encapsulated > inside 'hal_com_data'. > > The removal of this dead code cleans up the global namespace and > resolves multiple checkpatch.pl warnings regarding CamelCase naming > conventions. Verified by compilation that no functional code references > these variables. > > Signed-off-by: Marcos Andrade > Reviewed-by: Ethan Tidmore > --- > Changes in v2: > - Collected Reviewed-by tag from Ethan Tidmore. You don't have to do this. Normally you only do this would a reivewer gives you specifc instructions to do and then you can add their RB tag with their approval. Thanks, ET