From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7578E330D24 for ; Mon, 16 Mar 2026 22:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773700066; cv=none; b=iTFLJQhETR7Cg42oMcwcS+dEU7RUFQ/OwcuYsqxIQ19xAg4jq5sekWW7N2osolUbfZO23zwmtuRM4usjB2on4wm6WLpvcX4hbXBN1KlAmkiIWFub8ns1i6sLQZNcFHpzC384Zp6oWyq8i3r0aLgESI2WiDPEVqJROXyWsYsfLp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773700066; c=relaxed/simple; bh=Tpza4+6K8I/NWbGIY+DT3pE8PRDCA3LtWV1DRAkh9xA=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=eZD/B+eZiD4RXERVGqtb9kIt/NJXv8pdWB7AED5U2goiN8PnR3sliHDtgSe7JjAacO7PIa81JrHlUA1G/aeukAxUQ2ibhD1sUvxh0mlbue2R8auQwiyLNIyCnh7u2B7g8lMH/AeI9PW7PtSJIkkf7bs7jM03BjGWft2w8HjcHxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=czo2baKE; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="czo2baKE" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-79a535e7c00so13807307b3.3 for ; Mon, 16 Mar 2026 15:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773700064; x=1774304864; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5Vb5g/rkADgsShm9+VtelJ4BQsoHYpcByRPsV6VwUMg=; b=czo2baKEI1tQWnVX/p/tmNPDY14B9MgyTLVavMcft3XRqOffscqNpQXNvrzap1+O2d 31T9RAMgRQk6PNcqZ3HihYEqG0dxFKFPpQt4TxAqCVLMg43NsTpdlF/A1J1WzYYVBO5p O2gkaoKe7jNT4WTc+maUjLyEwTZMjU2mmknabJOYr6UynaJ5WpLBAEO7HenhV/9G3fiT 2pFgpy6kIPDWyu/DGrb6G9OWX6G0Y1X6YYQTlG6UBy9vLeA5hxFYloTfblVdFOpEcnwX sQXJ5fTSry5dLllVBw6fyJF9S9U17f9mB7ThfGlDna4B5u8WBNe+YN5gGTIr4TK2KbHV yTMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773700064; x=1774304864; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5Vb5g/rkADgsShm9+VtelJ4BQsoHYpcByRPsV6VwUMg=; b=Q0qOYQ655LMHd6ZixkJnxiSoOS0OZSHQ4tVNZA6Y9Yck16Z1Lc+K41UxwSvdnzC2t6 bj0Bp1pDHELswvsrcHh+SH+3uJrORTq3Uf56lL3XK83B/6Iq4u12NRyi17q1qMppb7Sk j/3PTHUBwKB1iz9Gy8dzwYm5QMb5FuZI2tE8U09CPBam75CCs2i1t8b9iUnVsoJrIbtQ Q6x6kp7qiExEBr9l2HSXHWsvwwgyJz8KXhm+7aZFxTK/jW+VtFICUB7j2LJBfFs46PEe 227AnL2HNREXxadOGMtLd5idsS6gwYJNMEYi6DKaOO7Lcyo5FiVQrvdexPdUwpVzIA8l bhXg== X-Forwarded-Encrypted: i=1; AJvYcCXsSZRVlFrkSIqqChn4W+8Z/fAM42VmBp+2UFg5m+kaSkYAi6IGgJOtyXQ6qNLYi+/fp5gwWPNtefnAMso=@vger.kernel.org X-Gm-Message-State: AOJu0YwhgYIjfzl7fRMWHY5kmcg5tgvxPyfrCq5g1ygQvmu7uv1Ovdc+ rCuqPhKlTjnntV/+jhDaOmzFiSz6Fssn2IzxvTvnQatcJxKr6ZofyzLXRFFZ4mxl X-Gm-Gg: ATEYQzwgheuwBckBzBBFR/0tHJDUWfuzKDaMGTL073ZbtG2+vvG6145LhiATdd9uJyM Rcg6qqWOCFDVMGLPdpiHjC+big/fXj/B6fa8u0xY4J9KJ70UvD9H2EBNIy+7hB7Pz0vxwn3YuZE oH3tEXMXtm9iAoRt6GYGFaVeDecynfGvtqhaF+KZUsDCiP++n0Jx5byRqH+l+ZoBmJdk9PZSv/2 TEmL+zmKPAfvwnBHbIaxsvsnPVhbtSpkB2O5URc7bHQFqr9ttfyCB2ZFSVTJMbbcP4dld5ImQsz nd8mtJuMBPWzXIdxLtafuo6KKk6+VVY8kmRRC+47gltpVbbWpX763OYlXHJU2f+ApU0cOkfFw/0 4ePnSZCCAincHll9jYe9C8UmhqIX+4wB2HqG30q8wqXfRqk7cZPv/2u4NRk3nhyfcnqUq7A3u9k KVqsJqZy22/kML5ba5JxXrdD0SPXJSfNE3oWL+MTSYj4lhAMERCYz48cX1n3tZ9B7tDkkTUjBDQ tcUHbnmcSglJsKXj6G+wMtpkCH5p070 X-Received: by 2002:a05:690c:e3c7:b0:79a:616d:b33b with SMTP id 00721157ae682-79a616db80cmr14531387b3.13.1773700064532; Mon, 16 Mar 2026 15:27:44 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a2de73263sm46963287b3.43.2026.03.16.15.27.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 15:27:44 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 16 Mar 2026 17:27:23 -0500 Message-Id: Cc: , Subject: Re: [PATCH v2] staging: rtl8723bs: remove unused global efuse variables From: "Ethan Tidmore" To: "Ethan Tidmore" , "Marcos Andrade" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260316220435.2249-1-marcosandrade95963@gmail.com> In-Reply-To: On Mon Mar 16, 2026 at 5:26 PM CDT, Ethan Tidmore wrote: > On Mon Mar 16, 2026 at 5:04 PM CDT, Marcos Andrade wrote: >> Remove several global efuse variables from rtw_efuse.c and their >> corresponding extern declarations in rtw_efuse.h. >> >> These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely >> unused legacy code. The driver currently maintains the efuse state >> properly within the 'efuse_hal' structure, which is encapsulated >> inside 'hal_com_data'. >> >> The removal of this dead code cleans up the global namespace and >> resolves multiple checkpatch.pl warnings regarding CamelCase naming >> conventions. Verified by compilation that no functional code references >> these variables. >> >> Signed-off-by: Marcos Andrade >> Reviewed-by: Ethan Tidmore >> --- >> Changes in v2: >> - Collected Reviewed-by tag from Ethan Tidmore. > > You don't have to do this. Normally you only do this would a reivewer > gives you specifc instructions to do and then you can add their RB tag > with their approval. > > Thanks, > > ET With that said, you don't have to do anything now, just keep it in mind for next time. Thanks, ET