From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5AA732B989; Mon, 16 Mar 2026 23:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773705417; cv=none; b=TwvNaMESOJ3fEBkucMEyCrGmyN3oRciZAdh2+e55mAhPT7SH9yoNjNfXTZc1G484GvLTuBlyaAdxA8WFJCUYxP2x67uI70Uf8At9EftPFVbG+atULfulEqeiMsigK5VLlW6GCCaH59FIgODgNcSj0xISs6gb7W+zt7Pb1vkWtTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773705417; c=relaxed/simple; bh=aBVSLPCBbP60rhVv5ksFK1Kh9ObDpoNnsj1rgiOLFWs=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=m/SdG6J1KaQIeAWap9sIA5S5I33s7ob1F9b6EYffpC8TpR0fzcxEww0iFlOgSkS67S+lm6ODEvSXctJiSKsW1PoQynYsDxWSLk+90856+SfVL+80Ik1AYYixRUn8lgmL89qkD2twfqi1cLQVPrcc/l17z/Ofqh64mN5eF/WaWSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bulxpirw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bulxpirw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D6C9C19421; Mon, 16 Mar 2026 23:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773705417; bh=aBVSLPCBbP60rhVv5ksFK1Kh9ObDpoNnsj1rgiOLFWs=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=bulxpirw9VyaOzQWWwrJxzZ3IWjFxgNtERN05KF3F6lULec4Wd0PrM+oRAJK4y85b i4WpYh3nRd0fnlbjWGoTrdSXg3pcJsLlLBtxj39/YohKPGvXREMZpEQvYo1eeh8hyl VRDxJxBXnL+qU7lBLe+FGreRxemuoHjm/1qQQvSqAjEXgaigZRFjqWS0oolb3M8n86 aaYWwOqkLKoMbg4nm6q/pF3tRX4gs4gmfbIte71xWfSeJUqAaBauxQF3ucnmpzP7nx Jjb1U5kqrz4+hj3XfKACoE+KHuD/iFi8N8GLJMeeeiXSuIHXrYelelV+ZPuYN8nBq7 pATFfxjOfNpCg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Mar 2026 00:56:52 +0100 Message-Id: Subject: Re: [PATCH v2 4/4] driver core: platform: use generic driver_override infrastructure Cc: , , , , , , To: , , , , , , , , , , From: "Danilo Krummrich" References: <20260303115720.48783-1-dakr@kernel.org> <20260303115720.48783-5-dakr@kernel.org> In-Reply-To: <20260303115720.48783-5-dakr@kernel.org> (Cc: Bartosz) On Tue Mar 3, 2026 at 12:53 PM CET, Danilo Krummrich wrote: > diff --git a/arch/sh/drivers/platform_early.c b/arch/sh/drivers/platform_= early.c > index 143747c45206..3cd17bb0be67 100644 > --- a/arch/sh/drivers/platform_early.c > +++ b/arch/sh/drivers/platform_early.c > @@ -25,10 +25,12 @@ static int platform_match(struct device *dev, struct = device_driver *drv) > { > struct platform_device *pdev =3D to_platform_device(dev); > struct platform_driver *pdrv =3D to_platform_driver(drv); > + int ret; > =20 > /* When driver_override is set, only bind to the matching driver */ > - if (pdev->driver_override) > - return !strcmp(pdev->driver_override, drv->name); > + ret =3D device_match_driver_override(dev, drv); > + if (ret >=3D 0) > + return ret; > =20 > /* Then try to match against the id table */ > if (pdrv->id_table) I was just about to pick up this series, but then noticed that checking for driver_override in the platform_early case doesn't make sense in the first = place and was accidentally added when the platform_match() callback was copied ov= er in commit 507fd01d5333 ("drivers: move the early platform device support to arch/sh"). Thus, I'm going to drop this hunk and add in the following patch; please le= t me know if there are any concerns. commit 39cae4095efda4b00b436c0fc46f21de84128969 Author: Danilo Krummrich Date: Tue Mar 17 00:37:15 2026 +0100 sh: platform_early: remove pdev->driver_override check In commit 507fd01d5333 ("drivers: move the early platform device suppor= t to arch/sh") platform_match() was copied over to the sh platform_early code, accidentally including the driver_override check. This check does not make sense for platform_early, as sysfs is not even available in first place at this point in the boot process, hence remov= e the check. Fixes: 507fd01d5333 ("drivers: move the early platform device support t= o arch/sh") Signed-off-by: Danilo Krummrich diff --git a/arch/sh/drivers/platform_early.c b/arch/sh/drivers/platform_ea= rly.c index 143747c45206..48ddbc547bd9 100644 --- a/arch/sh/drivers/platform_early.c +++ b/arch/sh/drivers/platform_early.c @@ -26,10 +26,6 @@ static int platform_match(struct device *dev, struct dev= ice_driver *drv) struct platform_device *pdev =3D to_platform_device(dev); struct platform_driver *pdrv =3D to_platform_driver(drv); - /* When driver_override is set, only bind to the matching driver */ - if (pdev->driver_override) - return !strcmp(pdev->driver_override, drv->name); - /* Then try to match against the id table */ if (pdrv->id_table) return platform_match_id(pdrv->id_table, pdev) !=3D NULL;