[PATCH v2 0/2] gpu: nova: rename drivers and directory to use kebab-case convention

[PATCH v2 0/2] gpu: nova: rename drivers and directory to use kebab-case convention

[Cheng-Yang Chou]

Rename the nova-core and nova-drm drivers to follow kernel naming
conventions before these names become UAPI (e.g. exposed via
driver_override).

Changes in v2:
- Also fix nova-drm driver description from "Nvidia Graphics" to
  "NVIDIA Graphics and Compute" (John Hubbard)
- Rename drivers/gpu/drm/nova/ directory to drivers/gpu/drm/nova-drm/
  and nova.rs to nova_drm.rs to match the module name (Danilo Krummrich)
- Link to v1:
  https://lore.kernel.org/all/20260310062443.2763230-1-yphbchou0911@gmail.com/

Link: https://github.com/Rust-for-Linux/linux/issues/1228

Thanks,
Cheng-Yang

---
Cheng-Yang Chou (2):
  gpu: nova: rename drivers to use kebab-case convention
  gpu: nova-drm: rename nova/ directory to nova-drm/

 MAINTAINERS                                            | 6 +++---
 drivers/gpu/drm/Kconfig                                | 2 +-
 drivers/gpu/drm/Makefile                               | 2 +-
 drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
 drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
 drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 6 +++---
 drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
 drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
 drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} | 2 +-
 drivers/gpu/drm/nova/Makefile                          | 3 ---
 drivers/gpu/nova-core/nova_core.rs                     | 2 +-
 11 files changed, 14 insertions(+), 14 deletions(-)
 rename drivers/gpu/drm/{nova => nova-drm}/Kconfig (84%)
 create mode 100644 drivers/gpu/drm/nova-drm/Makefile
 rename drivers/gpu/drm/{nova => nova-drm}/driver.rs (94%)
 rename drivers/gpu/drm/{nova => nova-drm}/file.rs (100%)
 rename drivers/gpu/drm/{nova => nova-drm}/gem.rs (100%)
 rename drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} (92%)
 delete mode 100644 drivers/gpu/drm/nova/Makefile

-- 
2.48.1

[PATCH v2 1/2] gpu: nova: rename drivers to use kebab-case convention

[Cheng-Yang Chou]

Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
driver from "Nova" to "nova-drm" to follow kernel naming conventions
before these names become UAPI (e.g. exposed via driver_override).

Also fix the nova-drm driver description from "Nvidia Graphics" to
"NVIDIA Graphics and Compute".

Link: https://github.com/Rust-for-Linux/linux/issues/1228
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
Acked-by: Timur Tabi <ttabi@nvidia.com>
---
 drivers/gpu/drm/nova/driver.rs     | 6 +++---
 drivers/gpu/drm/nova/nova.rs       | 2 +-
 drivers/gpu/nova-core/nova_core.rs | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
index b1af0a099551..e3de04f358f0 100644
--- a/drivers/gpu/drm/nova/driver.rs
+++ b/drivers/gpu/drm/nova/driver.rs
@@ -32,11 +32,11 @@ pub(crate) struct NovaData {
     major: 0,
     minor: 0,
     patchlevel: 0,
-    name: c"nova",
-    desc: c"Nvidia Graphics",
+    name: c"nova-drm",
+    desc: c"NVIDIA Graphics and Compute",
 };
 
-const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
+const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
 const AUXILIARY_NAME: &CStr = c"nova-drm";
 
 kernel::auxiliary_device_table!(
diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
index 8893e58ee0db..1fd454c7e0df 100644
--- a/drivers/gpu/drm/nova/nova.rs
+++ b/drivers/gpu/drm/nova/nova.rs
@@ -10,7 +10,7 @@
 
 kernel::module_auxiliary_driver! {
     type: NovaDriver,
-    name: "Nova",
+    name: "nova-drm",
     authors: ["Danilo Krummrich"],
     description: "Nova GPU driver",
     license: "GPL v2",
diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs
index c1121e7c64c5..90e98380687b 100644
--- a/drivers/gpu/nova-core/nova_core.rs
+++ b/drivers/gpu/nova-core/nova_core.rs
@@ -22,7 +22,7 @@
 
 kernel::module_pci_driver! {
     type: driver::NovaCore,
-    name: "NovaCore",
+    name: "nova-core",
     authors: ["Danilo Krummrich"],
     description: "Nova Core GPU driver",
     license: "GPL v2",
-- 
2.48.1

[PATCH v2 2/2] gpu: nova-drm: rename nova/ directory to nova-drm/

[Cheng-Yang Chou]

Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
to nova_drm.rs (matching the object name nova_drm.o) to follow the
kebab-case naming convention already used by the auxiliary device name.

Update MAINTAINERS, Kconfig, and Makefile references accordingly.
Update the Kconfig help text to reflect the new module name nova-drm.

Link: https://github.com/Rust-for-Linux/linux/issues/1228
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
 MAINTAINERS                                            | 6 +++---
 drivers/gpu/drm/Kconfig                                | 2 +-
 drivers/gpu/drm/Makefile                               | 2 +-
 drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
 drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
 drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
 drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
 drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
 drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} | 0
 drivers/gpu/drm/nova/Makefile                          | 3 ---
 10 files changed, 9 insertions(+), 9 deletions(-)
 rename drivers/gpu/drm/{nova => nova-drm}/Kconfig (84%)
 create mode 100644 drivers/gpu/drm/nova-drm/Makefile
 rename drivers/gpu/drm/{nova => nova-drm}/driver.rs (100%)
 rename drivers/gpu/drm/{nova => nova-drm}/file.rs (100%)
 rename drivers/gpu/drm/{nova => nova-drm}/gem.rs (100%)
 rename drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} (100%)
 delete mode 100644 drivers/gpu/drm/nova/Makefile

diff --git a/MAINTAINERS b/MAINTAINERS
index 7b277d5bf3d1..7ee486627420 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8201,7 +8201,7 @@ B:	https://gitlab.freedesktop.org/drm/nova/-/issues
 C:	irc://irc.oftc.net/nouveau
 T:	git https://gitlab.freedesktop.org/drm/rust/kernel.git drm-rust-next
 F:	Documentation/gpu/nova/
-F:	drivers/gpu/drm/nova/
+F:	drivers/gpu/drm/nova-drm/
 F:	include/uapi/drm/nova_drm.h
 
 DRM DRIVER FOR OLIMEX LCD-OLINUXINO PANELS
@@ -8484,7 +8484,7 @@ X:	drivers/gpu/drm/i915/
 X:	drivers/gpu/drm/kmb/
 X:	drivers/gpu/drm/mediatek/
 X:	drivers/gpu/drm/msm/
-X:	drivers/gpu/drm/nova/
+X:	drivers/gpu/drm/nova-drm/
 X:	drivers/gpu/drm/radeon/
 X:	drivers/gpu/drm/tegra/
 X:	drivers/gpu/drm/tyr/
@@ -8496,7 +8496,7 @@ M:	Alice Ryhl <aliceryhl@google.com>
 S:	Supported
 W:	https://drm.pages.freedesktop.org/maintainer-tools/drm-rust.html
 T:	git https://gitlab.freedesktop.org/drm/rust/kernel.git
-F:	drivers/gpu/drm/nova/
+F:	drivers/gpu/drm/nova-drm/
 F:	drivers/gpu/drm/tyr/
 F:	drivers/gpu/nova-core/
 F:	rust/kernel/drm/
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index d3d52310c9cc..958fa142b6cd 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -308,7 +308,7 @@ source "drivers/gpu/drm/mgag200/Kconfig"
 source "drivers/gpu/drm/msm/Kconfig"
 source "drivers/gpu/drm/mxsfb/Kconfig"
 source "drivers/gpu/drm/nouveau/Kconfig"
-source "drivers/gpu/drm/nova/Kconfig"
+source "drivers/gpu/drm/nova-drm/Kconfig"
 source "drivers/gpu/drm/omapdrm/Kconfig"
 source "drivers/gpu/drm/panel/Kconfig"
 source "drivers/gpu/drm/panfrost/Kconfig"
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index ec2c5ff82382..acdec9e30a27 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -186,7 +186,7 @@ obj-$(CONFIG_DRM_VMWGFX)+= vmwgfx/
 obj-$(CONFIG_DRM_VGEM)	+= vgem/
 obj-$(CONFIG_DRM_VKMS)	+= vkms/
 obj-$(CONFIG_DRM_NOUVEAU) +=nouveau/
-obj-$(CONFIG_DRM_NOVA) += nova/
+obj-$(CONFIG_DRM_NOVA) += nova-drm/
 obj-$(CONFIG_DRM_EXYNOS) +=exynos/
 obj-$(CONFIG_DRM_ROCKCHIP) +=rockchip/
 obj-$(CONFIG_DRM_GMA500) += gma500/
diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova-drm/Kconfig
similarity index 84%
rename from drivers/gpu/drm/nova/Kconfig
rename to drivers/gpu/drm/nova-drm/Kconfig
index 3e637ad7b5ba..48a731bff9b1 100644
--- a/drivers/gpu/drm/nova/Kconfig
+++ b/drivers/gpu/drm/nova-drm/Kconfig
@@ -13,4 +13,4 @@ config DRM_NOVA
 
 	  This driver is work in progress and may not be functional.
 
-	  If M is selected, the module will be called nova.
+	  If M is selected, the module will be called nova-drm.
diff --git a/drivers/gpu/drm/nova-drm/Makefile b/drivers/gpu/drm/nova-drm/Makefile
new file mode 100644
index 000000000000..bd3a5e703742
--- /dev/null
+++ b/drivers/gpu/drm/nova-drm/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_DRM_NOVA) += nova_drm.o
diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova-drm/driver.rs
similarity index 100%
rename from drivers/gpu/drm/nova/driver.rs
rename to drivers/gpu/drm/nova-drm/driver.rs
diff --git a/drivers/gpu/drm/nova/file.rs b/drivers/gpu/drm/nova-drm/file.rs
similarity index 100%
rename from drivers/gpu/drm/nova/file.rs
rename to drivers/gpu/drm/nova-drm/file.rs
diff --git a/drivers/gpu/drm/nova/gem.rs b/drivers/gpu/drm/nova-drm/gem.rs
similarity index 100%
rename from drivers/gpu/drm/nova/gem.rs
rename to drivers/gpu/drm/nova-drm/gem.rs
diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova-drm/nova_drm.rs
similarity index 100%
rename from drivers/gpu/drm/nova/nova.rs
rename to drivers/gpu/drm/nova-drm/nova_drm.rs
diff --git a/drivers/gpu/drm/nova/Makefile b/drivers/gpu/drm/nova/Makefile
deleted file mode 100644
index 42019bff3173..000000000000
--- a/drivers/gpu/drm/nova/Makefile
+++ /dev/null
@@ -1,3 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-
-obj-$(CONFIG_DRM_NOVA) += nova.o
-- 
2.48.1

Re: [PATCH v2 1/2] gpu: nova: rename drivers to use kebab-case convention

[Gary Guo]

On Mon Mar 16, 2026 at 12:08 PM GMT, Cheng-Yang Chou wrote:
> Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
> driver from "Nova" to "nova-drm" to follow kernel naming conventions
> before these names become UAPI (e.g. exposed via driver_override).
> 
> Also fix the nova-drm driver description from "Nvidia Graphics" to
> "NVIDIA Graphics and Compute".
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> Acked-by: Timur Tabi <ttabi@nvidia.com>

Suggested-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  drivers/gpu/drm/nova/driver.rs     | 6 +++---
>  drivers/gpu/drm/nova/nova.rs       | 2 +-
>  drivers/gpu/nova-core/nova_core.rs | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH v2 1/2] gpu: nova: rename drivers to use kebab-case convention

[John Hubbard]

On 3/16/26 5:08 AM, Cheng-Yang Chou wrote:
> Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
> driver from "Nova" to "nova-drm" to follow kernel naming conventions
> before these names become UAPI (e.g. exposed via driver_override).
> 
> Also fix the nova-drm driver description from "Nvidia Graphics" to
> "NVIDIA Graphics and Compute".
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> Acked-by: Timur Tabi <ttabi@nvidia.com>
> ---
>   drivers/gpu/drm/nova/driver.rs     | 6 +++---
>   drivers/gpu/drm/nova/nova.rs       | 2 +-
>   drivers/gpu/nova-core/nova_core.rs | 2 +-
>   3 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard

> 
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index b1af0a099551..e3de04f358f0 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -32,11 +32,11 @@ pub(crate) struct NovaData {
>       major: 0,
>       minor: 0,
>       patchlevel: 0,
> -    name: c"nova",
> -    desc: c"Nvidia Graphics",
> +    name: c"nova-drm",
> +    desc: c"NVIDIA Graphics and Compute",
>   };
>   
> -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
> +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
>   const AUXILIARY_NAME: &CStr = c"nova-drm";
>   
>   kernel::auxiliary_device_table!(
> diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
> index 8893e58ee0db..1fd454c7e0df 100644
> --- a/drivers/gpu/drm/nova/nova.rs
> +++ b/drivers/gpu/drm/nova/nova.rs
> @@ -10,7 +10,7 @@
>   
>   kernel::module_auxiliary_driver! {
>       type: NovaDriver,
> -    name: "Nova",
> +    name: "nova-drm",
>       authors: ["Danilo Krummrich"],
>       description: "Nova GPU driver",
>       license: "GPL v2",
> diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs
> index c1121e7c64c5..90e98380687b 100644
> --- a/drivers/gpu/nova-core/nova_core.rs
> +++ b/drivers/gpu/nova-core/nova_core.rs
> @@ -22,7 +22,7 @@
>   
>   kernel::module_pci_driver! {
>       type: driver::NovaCore,
> -    name: "NovaCore",
> +    name: "nova-core",
>       authors: ["Danilo Krummrich"],
>       description: "Nova Core GPU driver",
>       license: "GPL v2",

Re: [PATCH v2 2/2] gpu: nova-drm: rename nova/ directory to nova-drm/

[John Hubbard]

On 3/16/26 5:08 AM, Cheng-Yang Chou wrote:
> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
> to nova_drm.rs (matching the object name nova_drm.o) to follow the
> kebab-case naming convention already used by the auxiliary device name.
> 
> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
> Update the Kconfig help text to reflect the new module name nova-drm.
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>

The subject line should be changed to:

   gpu: nova-drm: rename nova to nova-drm


Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
-- 
John Hubbard

> ---
>   MAINTAINERS                                            | 6 +++---
>   drivers/gpu/drm/Kconfig                                | 2 +-
>   drivers/gpu/drm/Makefile                               | 2 +-
>   drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>   drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>   drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>   drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>   drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
>   drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} | 0
>   drivers/gpu/drm/nova/Makefile                          | 3 ---
>   10 files changed, 9 insertions(+), 9 deletions(-)
>   rename drivers/gpu/drm/{nova => nova-drm}/Kconfig (84%)
>   create mode 100644 drivers/gpu/drm/nova-drm/Makefile
>   rename drivers/gpu/drm/{nova => nova-drm}/driver.rs (100%)
>   rename drivers/gpu/drm/{nova => nova-drm}/file.rs (100%)
>   rename drivers/gpu/drm/{nova => nova-drm}/gem.rs (100%)
>   rename drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} (100%)
>   delete mode 100644 drivers/gpu/drm/nova/Makefile
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7b277d5bf3d1..7ee486627420 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8201,7 +8201,7 @@ B:	https://gitlab.freedesktop.org/drm/nova/-/issues
>   C:	irc://irc.oftc.net/nouveau
>   T:	git https://gitlab.freedesktop.org/drm/rust/kernel.git drm-rust-next
>   F:	Documentation/gpu/nova/
> -F:	drivers/gpu/drm/nova/
> +F:	drivers/gpu/drm/nova-drm/
>   F:	include/uapi/drm/nova_drm.h
>   
>   DRM DRIVER FOR OLIMEX LCD-OLINUXINO PANELS
> @@ -8484,7 +8484,7 @@ X:	drivers/gpu/drm/i915/
>   X:	drivers/gpu/drm/kmb/
>   X:	drivers/gpu/drm/mediatek/
>   X:	drivers/gpu/drm/msm/
> -X:	drivers/gpu/drm/nova/
> +X:	drivers/gpu/drm/nova-drm/
>   X:	drivers/gpu/drm/radeon/
>   X:	drivers/gpu/drm/tegra/
>   X:	drivers/gpu/drm/tyr/
> @@ -8496,7 +8496,7 @@ M:	Alice Ryhl <aliceryhl@google.com>
>   S:	Supported
>   W:	https://drm.pages.freedesktop.org/maintainer-tools/drm-rust.html
>   T:	git https://gitlab.freedesktop.org/drm/rust/kernel.git
> -F:	drivers/gpu/drm/nova/
> +F:	drivers/gpu/drm/nova-drm/
>   F:	drivers/gpu/drm/tyr/
>   F:	drivers/gpu/nova-core/
>   F:	rust/kernel/drm/
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index d3d52310c9cc..958fa142b6cd 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -308,7 +308,7 @@ source "drivers/gpu/drm/mgag200/Kconfig"
>   source "drivers/gpu/drm/msm/Kconfig"
>   source "drivers/gpu/drm/mxsfb/Kconfig"
>   source "drivers/gpu/drm/nouveau/Kconfig"
> -source "drivers/gpu/drm/nova/Kconfig"
> +source "drivers/gpu/drm/nova-drm/Kconfig"
>   source "drivers/gpu/drm/omapdrm/Kconfig"
>   source "drivers/gpu/drm/panel/Kconfig"
>   source "drivers/gpu/drm/panfrost/Kconfig"
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index ec2c5ff82382..acdec9e30a27 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -186,7 +186,7 @@ obj-$(CONFIG_DRM_VMWGFX)+= vmwgfx/
>   obj-$(CONFIG_DRM_VGEM)	+= vgem/
>   obj-$(CONFIG_DRM_VKMS)	+= vkms/
>   obj-$(CONFIG_DRM_NOUVEAU) +=nouveau/
> -obj-$(CONFIG_DRM_NOVA) += nova/
> +obj-$(CONFIG_DRM_NOVA) += nova-drm/
>   obj-$(CONFIG_DRM_EXYNOS) +=exynos/
>   obj-$(CONFIG_DRM_ROCKCHIP) +=rockchip/
>   obj-$(CONFIG_DRM_GMA500) += gma500/
> diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova-drm/Kconfig
> similarity index 84%
> rename from drivers/gpu/drm/nova/Kconfig
> rename to drivers/gpu/drm/nova-drm/Kconfig
> index 3e637ad7b5ba..48a731bff9b1 100644
> --- a/drivers/gpu/drm/nova/Kconfig
> +++ b/drivers/gpu/drm/nova-drm/Kconfig
> @@ -13,4 +13,4 @@ config DRM_NOVA
>   
>   	  This driver is work in progress and may not be functional.
>   
> -	  If M is selected, the module will be called nova.
> +	  If M is selected, the module will be called nova-drm.
> diff --git a/drivers/gpu/drm/nova-drm/Makefile b/drivers/gpu/drm/nova-drm/Makefile
> new file mode 100644
> index 000000000000..bd3a5e703742
> --- /dev/null
> +++ b/drivers/gpu/drm/nova-drm/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +obj-$(CONFIG_DRM_NOVA) += nova_drm.o
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova-drm/driver.rs
> similarity index 100%
> rename from drivers/gpu/drm/nova/driver.rs
> rename to drivers/gpu/drm/nova-drm/driver.rs
> diff --git a/drivers/gpu/drm/nova/file.rs b/drivers/gpu/drm/nova-drm/file.rs
> similarity index 100%
> rename from drivers/gpu/drm/nova/file.rs
> rename to drivers/gpu/drm/nova-drm/file.rs
> diff --git a/drivers/gpu/drm/nova/gem.rs b/drivers/gpu/drm/nova-drm/gem.rs
> similarity index 100%
> rename from drivers/gpu/drm/nova/gem.rs
> rename to drivers/gpu/drm/nova-drm/gem.rs
> diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova-drm/nova_drm.rs
> similarity index 100%
> rename from drivers/gpu/drm/nova/nova.rs
> rename to drivers/gpu/drm/nova-drm/nova_drm.rs
> diff --git a/drivers/gpu/drm/nova/Makefile b/drivers/gpu/drm/nova/Makefile
> deleted file mode 100644
> index 42019bff3173..000000000000
> --- a/drivers/gpu/drm/nova/Makefile
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -
> -obj-$(CONFIG_DRM_NOVA) += nova.o

thanks,
-- 
John Hubbard

[PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Cheng-Yang Chou]

Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
to nova_drm.rs (matching the object name nova_drm.o) to follow the
kebab-case naming convention already used by the auxiliary device name.

Update MAINTAINERS, Kconfig, and Makefile references accordingly.
Update the Kconfig help text to reflect the new module name nova-drm.

Link: https://github.com/Rust-for-Linux/linux/issues/1228
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
---
Changes in v3:
- Rename subject line (John Hubbard)

 MAINTAINERS                                            | 6 +++---
 drivers/gpu/drm/Kconfig                                | 2 +-
 drivers/gpu/drm/Makefile                               | 2 +-
 drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
 drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
 drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
 drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
 drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
 drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} | 0
 drivers/gpu/drm/nova/Makefile                          | 3 ---
 10 files changed, 9 insertions(+), 9 deletions(-)
 rename drivers/gpu/drm/{nova => nova-drm}/Kconfig (84%)
 create mode 100644 drivers/gpu/drm/nova-drm/Makefile
 rename drivers/gpu/drm/{nova => nova-drm}/driver.rs (100%)
 rename drivers/gpu/drm/{nova => nova-drm}/file.rs (100%)
 rename drivers/gpu/drm/{nova => nova-drm}/gem.rs (100%)
 rename drivers/gpu/drm/{nova/nova.rs => nova-drm/nova_drm.rs} (100%)
 delete mode 100644 drivers/gpu/drm/nova/Makefile

diff --git a/MAINTAINERS b/MAINTAINERS
index 7b277d5bf3d1..7ee486627420 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8201,7 +8201,7 @@ B:	https://gitlab.freedesktop.org/drm/nova/-/issues
 C:	irc://irc.oftc.net/nouveau
 T:	git https://gitlab.freedesktop.org/drm/rust/kernel.git drm-rust-next
 F:	Documentation/gpu/nova/
-F:	drivers/gpu/drm/nova/
+F:	drivers/gpu/drm/nova-drm/
 F:	include/uapi/drm/nova_drm.h
 
 DRM DRIVER FOR OLIMEX LCD-OLINUXINO PANELS
@@ -8484,7 +8484,7 @@ X:	drivers/gpu/drm/i915/
 X:	drivers/gpu/drm/kmb/
 X:	drivers/gpu/drm/mediatek/
 X:	drivers/gpu/drm/msm/
-X:	drivers/gpu/drm/nova/
+X:	drivers/gpu/drm/nova-drm/
 X:	drivers/gpu/drm/radeon/
 X:	drivers/gpu/drm/tegra/
 X:	drivers/gpu/drm/tyr/
@@ -8496,7 +8496,7 @@ M:	Alice Ryhl <aliceryhl@google.com>
 S:	Supported
 W:	https://drm.pages.freedesktop.org/maintainer-tools/drm-rust.html
 T:	git https://gitlab.freedesktop.org/drm/rust/kernel.git
-F:	drivers/gpu/drm/nova/
+F:	drivers/gpu/drm/nova-drm/
 F:	drivers/gpu/drm/tyr/
 F:	drivers/gpu/nova-core/
 F:	rust/kernel/drm/
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index d3d52310c9cc..958fa142b6cd 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -308,7 +308,7 @@ source "drivers/gpu/drm/mgag200/Kconfig"
 source "drivers/gpu/drm/msm/Kconfig"
 source "drivers/gpu/drm/mxsfb/Kconfig"
 source "drivers/gpu/drm/nouveau/Kconfig"
-source "drivers/gpu/drm/nova/Kconfig"
+source "drivers/gpu/drm/nova-drm/Kconfig"
 source "drivers/gpu/drm/omapdrm/Kconfig"
 source "drivers/gpu/drm/panel/Kconfig"
 source "drivers/gpu/drm/panfrost/Kconfig"
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index ec2c5ff82382..acdec9e30a27 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -186,7 +186,7 @@ obj-$(CONFIG_DRM_VMWGFX)+= vmwgfx/
 obj-$(CONFIG_DRM_VGEM)	+= vgem/
 obj-$(CONFIG_DRM_VKMS)	+= vkms/
 obj-$(CONFIG_DRM_NOUVEAU) +=nouveau/
-obj-$(CONFIG_DRM_NOVA) += nova/
+obj-$(CONFIG_DRM_NOVA) += nova-drm/
 obj-$(CONFIG_DRM_EXYNOS) +=exynos/
 obj-$(CONFIG_DRM_ROCKCHIP) +=rockchip/
 obj-$(CONFIG_DRM_GMA500) += gma500/
diff --git a/drivers/gpu/drm/nova/Kconfig b/drivers/gpu/drm/nova-drm/Kconfig
similarity index 84%
rename from drivers/gpu/drm/nova/Kconfig
rename to drivers/gpu/drm/nova-drm/Kconfig
index 3e637ad7b5ba..48a731bff9b1 100644
--- a/drivers/gpu/drm/nova/Kconfig
+++ b/drivers/gpu/drm/nova-drm/Kconfig
@@ -13,4 +13,4 @@ config DRM_NOVA
 
 	  This driver is work in progress and may not be functional.
 
-	  If M is selected, the module will be called nova.
+	  If M is selected, the module will be called nova-drm.
diff --git a/drivers/gpu/drm/nova-drm/Makefile b/drivers/gpu/drm/nova-drm/Makefile
new file mode 100644
index 000000000000..bd3a5e703742
--- /dev/null
+++ b/drivers/gpu/drm/nova-drm/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_DRM_NOVA) += nova_drm.o
diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova-drm/driver.rs
similarity index 100%
rename from drivers/gpu/drm/nova/driver.rs
rename to drivers/gpu/drm/nova-drm/driver.rs
diff --git a/drivers/gpu/drm/nova/file.rs b/drivers/gpu/drm/nova-drm/file.rs
similarity index 100%
rename from drivers/gpu/drm/nova/file.rs
rename to drivers/gpu/drm/nova-drm/file.rs
diff --git a/drivers/gpu/drm/nova/gem.rs b/drivers/gpu/drm/nova-drm/gem.rs
similarity index 100%
rename from drivers/gpu/drm/nova/gem.rs
rename to drivers/gpu/drm/nova-drm/gem.rs
diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova-drm/nova_drm.rs
similarity index 100%
rename from drivers/gpu/drm/nova/nova.rs
rename to drivers/gpu/drm/nova-drm/nova_drm.rs
diff --git a/drivers/gpu/drm/nova/Makefile b/drivers/gpu/drm/nova/Makefile
deleted file mode 100644
index 42019bff3173..000000000000
--- a/drivers/gpu/drm/nova/Makefile
+++ /dev/null
@@ -1,3 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-
-obj-$(CONFIG_DRM_NOVA) += nova.o
-- 
2.48.1

Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Alexandre Courbot]

On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
> to nova_drm.rs (matching the object name nova_drm.o) to follow the
> kebab-case naming convention already used by the auxiliary device name.
>
> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
> Update the Kconfig help text to reflect the new module name nova-drm.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> ---
> Changes in v3:
> - Rename subject line (John Hubbard)
>
>  MAINTAINERS                                            | 6 +++---
>  drivers/gpu/drm/Kconfig                                | 2 +-
>  drivers/gpu/drm/Makefile                               | 2 +-
>  drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>  drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>  drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>  drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>  drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0

That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
Even `tegra-drm` is in `drm/tegra`.

Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Martin Roukala]

On 3/17/26 15:20, Alexandre Courbot wrote:
> On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
>> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
>> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
>> to nova_drm.rs (matching the object name nova_drm.o) to follow the
>> kebab-case naming convention already used by the auxiliary device name.
>>
>> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
>> Update the Kconfig help text to reflect the new module name nova-drm.
>>
>> Link: https://github.com/Rust-for-Linux/linux/issues/1228
>> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
>> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>> Changes in v3:
>> - Rename subject line (John Hubbard)
>>
>>   MAINTAINERS                                            | 6 +++---
>>   drivers/gpu/drm/Kconfig                                | 2 +-
>>   drivers/gpu/drm/Makefile                               | 2 +-
>>   drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>>   drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>>   drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>>   drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>>   drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
> 
> That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
> Even `tegra-drm` is in `drm/tegra`.

Same opinion here.

Cheers,
Martin (an old nouveau dev)

Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Danilo Krummrich]

On Tue Mar 17, 2026 at 2:20 PM CET, Alexandre Courbot wrote:
> On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
>> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
>> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
>> to nova_drm.rs (matching the object name nova_drm.o) to follow the
>> kebab-case naming convention already used by the auxiliary device name.
>>
>> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
>> Update the Kconfig help text to reflect the new module name nova-drm.
>>
>> Link: https://github.com/Rust-for-Linux/linux/issues/1228
>> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
>> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>> Changes in v3:
>> - Rename subject line (John Hubbard)
>>
>>  MAINTAINERS                                            | 6 +++---
>>  drivers/gpu/drm/Kconfig                                | 2 +-
>>  drivers/gpu/drm/Makefile                               | 2 +-
>>  drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>>  drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>>  drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>>  drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>>  drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
>
> That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
> Even `tegra-drm` is in `drm/tegra`.

Well, that's why I named it "nova" in the first place, but I don't want
KBUILD_MODNAME to diverge from the directory name and I also don't want the
driver name to diverge from KBUILD_MODNAME.

So, if we rename the driver name to nova-drm, then the other parts should be
renamed as well.

Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Alexandre Courbot]

On Tue Mar 17, 2026 at 10:53 PM JST, Danilo Krummrich wrote:
> On Tue Mar 17, 2026 at 2:20 PM CET, Alexandre Courbot wrote:
>> On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
>>> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
>>> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
>>> to nova_drm.rs (matching the object name nova_drm.o) to follow the
>>> kebab-case naming convention already used by the auxiliary device name.
>>>
>>> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
>>> Update the Kconfig help text to reflect the new module name nova-drm.
>>>
>>> Link: https://github.com/Rust-for-Linux/linux/issues/1228
>>> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
>>> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
>>> ---
>>> Changes in v3:
>>> - Rename subject line (John Hubbard)
>>>
>>>  MAINTAINERS                                            | 6 +++---
>>>  drivers/gpu/drm/Kconfig                                | 2 +-
>>>  drivers/gpu/drm/Makefile                               | 2 +-
>>>  drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>>>  drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>>>  drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>>>  drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>>>  drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
>>
>> That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
>> Even `tegra-drm` is in `drm/tegra`.
>
> Well, that's why I named it "nova" in the first place, but I don't want
> KBUILD_MODNAME to diverge from the directory name and I also don't want the
> driver name to diverge from KBUILD_MODNAME.

What is the rationale for that? I like consistency too, but also think
it is not particularly difficult to figure out that "nova-drm" resides
in "drm/nova".

Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Danilo Krummrich]

On Tue Mar 17, 2026 at 4:22 PM CET, Alexandre Courbot wrote:
> On Tue Mar 17, 2026 at 10:53 PM JST, Danilo Krummrich wrote:
>> On Tue Mar 17, 2026 at 2:20 PM CET, Alexandre Courbot wrote:
>>> On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
>>>> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
>>>> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
>>>> to nova_drm.rs (matching the object name nova_drm.o) to follow the
>>>> kebab-case naming convention already used by the auxiliary device name.
>>>>
>>>> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
>>>> Update the Kconfig help text to reflect the new module name nova-drm.
>>>>
>>>> Link: https://github.com/Rust-for-Linux/linux/issues/1228
>>>> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
>>>> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
>>>> ---
>>>> Changes in v3:
>>>> - Rename subject line (John Hubbard)
>>>>
>>>>  MAINTAINERS                                            | 6 +++---
>>>>  drivers/gpu/drm/Kconfig                                | 2 +-
>>>>  drivers/gpu/drm/Makefile                               | 2 +-
>>>>  drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>>>>  drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>>>>  drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>>>>  drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>>>>  drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
>>>
>>> That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
>>> Even `tegra-drm` is in `drm/tegra`.
>>
>> Well, that's why I named it "nova" in the first place, but I don't want
>> KBUILD_MODNAME to diverge from the directory name and I also don't want the
>> driver name to diverge from KBUILD_MODNAME.
>
> What is the rationale for that? I like consistency too, but also think
> it is not particularly difficult to figure out that "nova-drm" resides
> in "drm/nova".

It is consistency. But why are we discussing this, what is the concern being
consistent here?

Re: [PATCH v2 1/2] gpu: nova: rename drivers to use kebab-case convention

[Danilo Krummrich]

On Mon Mar 16, 2026 at 1:08 PM CET, Cheng-Yang Chou wrote:
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index b1af0a099551..e3de04f358f0 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -32,11 +32,11 @@ pub(crate) struct NovaData {
>      major: 0,
>      minor: 0,
>      patchlevel: 0,
> -    name: c"nova",
> -    desc: c"Nvidia Graphics",
> +    name: c"nova-drm",
> +    desc: c"NVIDIA Graphics and Compute",
>  };

Can you please move this into the second patch. Additionally, in the second
patch, please only keep the Kconfig change and use the following in the
Makefile.

	obj-$(CONFIG_DRM_NOVA) += nova-drm.o
	nova-drm-y := nova.o

I.e. keep the directory and filenames as they are.

We can use the same trick for nova-core, so we get nova-core.ko and nova-drm.ko.

Thanks,
Danilo

>  
> -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
> +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
>  const AUXILIARY_NAME: &CStr = c"nova-drm";
>  
>  kernel::auxiliary_device_table!(
> diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
> index 8893e58ee0db..1fd454c7e0df 100644
> --- a/drivers/gpu/drm/nova/nova.rs
> +++ b/drivers/gpu/drm/nova/nova.rs
> @@ -10,7 +10,7 @@
>  
>  kernel::module_auxiliary_driver! {
>      type: NovaDriver,
> -    name: "Nova",
> +    name: "nova-drm",
>      authors: ["Danilo Krummrich"],
>      description: "Nova GPU driver",
>      license: "GPL v2",
> diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs
> index c1121e7c64c5..90e98380687b 100644
> --- a/drivers/gpu/nova-core/nova_core.rs
> +++ b/drivers/gpu/nova-core/nova_core.rs
> @@ -22,7 +22,7 @@
>  
>  kernel::module_pci_driver! {
>      type: driver::NovaCore,
> -    name: "NovaCore",
> +    name: "nova-core",
>      authors: ["Danilo Krummrich"],
>      description: "Nova Core GPU driver",
>      license: "GPL v2",
> -- 
> 2.48.1

Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[Alexandre Courbot]

On Wed Mar 18, 2026 at 12:34 AM JST, Danilo Krummrich wrote:
> On Tue Mar 17, 2026 at 4:22 PM CET, Alexandre Courbot wrote:
>> On Tue Mar 17, 2026 at 10:53 PM JST, Danilo Krummrich wrote:
>>> On Tue Mar 17, 2026 at 2:20 PM CET, Alexandre Courbot wrote:
>>>> On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
>>>>> Rename the nova-drm driver directory from drivers/gpu/drm/nova/ to
>>>>> drivers/gpu/drm/nova-drm/ and the top-level source file from nova.rs
>>>>> to nova_drm.rs (matching the object name nova_drm.o) to follow the
>>>>> kebab-case naming convention already used by the auxiliary device name.
>>>>>
>>>>> Update MAINTAINERS, Kconfig, and Makefile references accordingly.
>>>>> Update the Kconfig help text to reflect the new module name nova-drm.
>>>>>
>>>>> Link: https://github.com/Rust-for-Linux/linux/issues/1228
>>>>> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
>>>>> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
>>>>> ---
>>>>> Changes in v3:
>>>>> - Rename subject line (John Hubbard)
>>>>>
>>>>>  MAINTAINERS                                            | 6 +++---
>>>>>  drivers/gpu/drm/Kconfig                                | 2 +-
>>>>>  drivers/gpu/drm/Makefile                               | 2 +-
>>>>>  drivers/gpu/drm/{nova => nova-drm}/Kconfig             | 2 +-
>>>>>  drivers/gpu/drm/nova-drm/Makefile                      | 3 +++
>>>>>  drivers/gpu/drm/{nova => nova-drm}/driver.rs           | 0
>>>>>  drivers/gpu/drm/{nova => nova-drm}/file.rs             | 0
>>>>>  drivers/gpu/drm/{nova => nova-drm}/gem.rs              | 0
>>>>
>>>> That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
>>>> Even `tegra-drm` is in `drm/tegra`.
>>>
>>> Well, that's why I named it "nova" in the first place, but I don't want
>>> KBUILD_MODNAME to diverge from the directory name and I also don't want the
>>> driver name to diverge from KBUILD_MODNAME.
>>
>> What is the rationale for that? I like consistency too, but also think
>> it is not particularly difficult to figure out that "nova-drm" resides
>> in "drm/nova".
>
> It is consistency. But why are we discussing this, what is the concern being
> consistent here?

I just find the repetition of "drm" unnecessary. That's not a big deal
though and I can definitely live with it.

Re: [PATCH v3 2/2] gpu: nova-drm: rename nova to nova-drm

[John Hubbard]

On 3/17/26 5:56 PM, Alexandre Courbot wrote:
> On Wed Mar 18, 2026 at 12:34 AM JST, Danilo Krummrich wrote:
>> On Tue Mar 17, 2026 at 4:22 PM CET, Alexandre Courbot wrote:
>>> On Tue Mar 17, 2026 at 10:53 PM JST, Danilo Krummrich wrote:
>>>> On Tue Mar 17, 2026 at 2:20 PM CET, Alexandre Courbot wrote:
>>>>> On Tue Mar 17, 2026 at 6:23 PM JST, Cheng-Yang Chou wrote:
....
>>>>> That `drm/nova-drm` reads a bit awkwardly to me and feels unnecessary.
>>>>> Even `tegra-drm` is in `drm/tegra`.
>>>>
>>>> Well, that's why I named it "nova" in the first place, but I don't want
>>>> KBUILD_MODNAME to diverge from the directory name and I also don't want the
>>>> driver name to diverge from KBUILD_MODNAME.
>>>
>>> What is the rationale for that? I like consistency too, but also think
>>> it is not particularly difficult to figure out that "nova-drm" resides
>>> in "drm/nova".
>>
>> It is consistency. But why are we discussing this, what is the concern being
>> consistent here?
> 
> I just find the repetition of "drm" unnecessary. That's not a big deal
> though and I can definitely live with it.

As I mentioned in an earlier version of this patchset, things such as
lsmod(1) do not show the source code directory of one's kernel module.

 $ lsmod|grep nova
nova                   16384  0
nova_core             253952  0

And of course, lsmod(1) is not the only case where this comes up: few
people know the source directory paths! Nor should they. But this
means that in many situations, we are left with an initial report
that only includes the module's basename.

We would like some hint about what "nova" means, especially
given the presence of nova_core.

So it turns out that a little redundancy, and even saying something
more than once, is helpful in this particular case. :)


thanks,
-- 
John Hubbard