From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B1003E3D94 for ; Tue, 17 Mar 2026 14:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773756694; cv=none; b=UWWR5ugjuGHoNsRuAeaBdDqmRlFyEmv6+e1eS6hig4i+Y2O2fUi+DnjEakjakfbQfI6QR3IRRJnWWnJ0cmn/URwiMr1+oJW+p1VD19UzmN2qV4dg/Hgh6kpvca1yLuMk7C1uf1870aa94E6vrHCBRLQv6HgIjsfmDOWaUH5U3gk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773756694; c=relaxed/simple; bh=NLJiSkzeQIFRX1mkhJW/Gt/oIZVKQKSSMHiMPxqN+3g=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=qNdsIP4PQ7ewykm8L+aX+WmXvvUp/mE/7PRX4JfXiKxq2MIzAQ8R3kze6Z9Sx3LjU3ti6ZOju+4trQmHofM5UyLL5ruWj3HCgUdS3RyRDn3ghhueoqh/rWUCPtYekB1YJa7hYC6zAqQUGXcLXu1Uc5vpkdaPt9Ld9ihKqW35f0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s8iqHEml; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s8iqHEml" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4853aec185aso47765655e9.1 for ; Tue, 17 Mar 2026 07:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773756690; x=1774361490; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mtjYw7NIr5M9DO4GZFC2fJ8GnFCnCjLLvq9mVI1210Q=; b=s8iqHEmlH10OsAm6JPTeZDEsyvWyx5r+eH9ejFr4SmafxT9TTIUwC5Rqp32hcARcct i0Q9BtIhek6kOgfVzHWHk4IfKbx2fCa8VaizUB/N4T/jtxmoRHJPZD98SeC8gReY4Yuy mhzqOuehI/GnoHBBm43QJljT53yOBK3+1FcW9nyjzqthIhr35MaSZTju+C7t0bGFQRl/ TwnGSdejBrrYlFmf4N+FoWdTwTkcAnQqdKGAK0MwWyA6RD3QtvnRKVZV0aFfzipSiKYP GHMbN52Zxa9EXv+NufLpqzsg79GALVxNdCByyPY/VUb2gq5bAzU72muO1f8B1f0i4wFS H6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773756690; x=1774361490; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mtjYw7NIr5M9DO4GZFC2fJ8GnFCnCjLLvq9mVI1210Q=; b=HivOr1fwKyAzN9HoPvYdhYJTOJVYbXhoedxys4B+1jNsPIB30BQs0IShOAF1ofxMpa dd0c+JVx/pk4FUJWgz5MS+StcxKgF4iR2iYZ1N12PAyPye0gToHsagcwTPVacu6gWDCJ wIzMN2n9DmFjkynoVKebMQ8w3j/J7vuLzahPT6xLXvcA8N/pRWjEDySPal2VYRlTrtN/ 8EeqJ5HIbl8VmRXTjM/SNpf/CVjEx1Sk34r7JMUET294NxPpJFrvAd7gj7NiWULEz017 SB4gCUIirRyK8qh+AUiwsmGjoq4A0iKaq6yFl8A6TCuIMnrXlmDpzpteUozO4uPXht+9 32YQ== X-Forwarded-Encrypted: i=1; AJvYcCW11dSK28Xo71G/LHmyS/E3/J+QJjzHfYwMd3TJPSkIHrsjRQzFCfxiAM+0YYvi2yw/pM5v64tygxnKgK0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6mbh/bDgMmah9LsGpOCIJaMFx1HHokZTaxC4433B1QvlzvXze 4/F5W4/r/6gDQ0ghsbLzhJ0urngBVJGuR3fFlIUXM3xniPsjR1St+rD6yKBuWX7oYiA= X-Gm-Gg: ATEYQzxETQjTY/DCd06CP7s6YWGX/q6S6sE1Vyl2G9h+gs1NMP+d7XAlOOXAQNqZNde 6cGKrV15w4Nt7YTS72F15IFgS9Rey4FTeV413CGMbcGNNLc5L7TWW3yUehdeQeinNK/ZTbbh9md kJxomhqGW8DkgWwiRS+U+IB5tJLuEkikOKOpaE0ljBwdmvkkCXOh5dcI8g/KhcFdqCmD9kDS8J0 P5SqotPpEG2XqXKZrsWvw3ItGgiJemf8IjZM2BNF/K+DToc7Qqy8OfiJpkmojJLSzRffREg2w2a ZJE35d1pVcsPFqvdUt3AB7HnWH9PdxouD8r5kMjiG2gvwF1HFuSCIh/AWvS8J4I8c4GK3kB2Vzc 6RMGlp8MYg4bGrdvtaSbKDBx67dix/4UOAQOEi/uDeU7jivy5fKst8bw79Vongt3jVlOS/7whr8 eJQ4yoFFfg6CIu3EDpbEEtK1CsnqvB3iqcouNNGoBiar8YXYM/+KdEjrYxUAUVKptpotQVbA82w 7mc/fl9xkzHguUe5A== X-Received: by 2002:a05:600c:4514:b0:480:4a8f:2d5c with SMTP id 5b1f17b1804b1-48556709e21mr271873225e9.29.1773756689493; Tue, 17 Mar 2026 07:11:29 -0700 (PDT) Received: from localhost ([2a02:c7c:5e34:8000:df24:76aa:fdca:2fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485563903bbsm194524525e9.0.2026.03.17.07.11.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 07:11:28 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Mar 2026 14:11:27 +0000 Message-Id: Cc: "Sam Protsenko" , , "Krzysztof Kozlowski" , =?utf-8?q?Andr=C3=A9_Draszik?= , "Conor Dooley" , "Tudor Ambarus" , "Rob Herring" , "Krzysztof Kozlowski" , "Alim Akhtar" , , , Subject: Re: [PATCH RFC 7/8] soc: samsung: exynos-pmu: add Exynos850 CPU hotplug support From: "Alexey Klimov" To: "Peter Griffin" , "Alexey Klimov" X-Mailer: aerc 0.21.0 References: <20260226-exynos850-cpuhotplug-v1-0-71d7c4063382@linaro.org> <20260226-exynos850-cpuhotplug-v1-7-71d7c4063382@linaro.org> In-Reply-To: Hi Peter, On Fri Mar 6, 2026 at 2:15 PM GMT, Peter Griffin wrote: > On Thu, 26 Feb 2026 at 15:47, Alexey Klimov wr= ote: >> >> Some Exynos-based SoCs require specific set of writes/updates to PMU >> and PMU intr gen blocks in order to put a CPU or a group of CPUs into >> a different sleep states or prepare these entities for a CPU_OFF. >> The same is valid for a reverse procedures like wake-ups or CPU(s) >> online. Without these writes/updates the CPU(s) wake-up or online >> fails. >> Add support for Exynos850-based SoCs for PMU and PMU intr gen write/upda= te >> sequences. >> While at this, also add description of Exynos850 PMU registers. >> >> Signed-off-by: Alexey Klimov >> --- >> drivers/soc/samsung/exynos-pmu.c | 86 ++++++++++++++++++++++= +++++-- >> include/linux/soc/samsung/exynos-regs-pmu.h | 5 ++ >> 2 files changed, 87 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exyn= os-pmu.c >> index 0967fa56708a..7b9b8e22d91b 100644 >> --- a/drivers/soc/samsung/exynos-pmu.c >> +++ b/drivers/soc/samsung/exynos-pmu.c >> @@ -118,6 +118,10 @@ static const struct regmap_config regmap_pmu_intr = =3D { >> .use_raw_spinlock =3D true, >> }; >> >> +const struct exynos_pmu_data exynos850_pmu_data =3D { >> + .pmu_cpuhp =3D true, >> +}; >> + > > You may want to consider having an e850-pmu.c file to contain the e850 > specific data and hooks. > > Andre recently moved some of the gs101-specific parts into gs101-pmu.c > (although not the actual gs101 online/offline hooks). Now that more > SoCs are being added it could be a good time for exynos-pmu to contain > only the generic code and the -pmu.c file having the > peculiarities/hooks for the specific SoC. Thanks. Yeah. That's why it was sent as an RFC to get pointers where to place things properly. I'll update it. [..] >> - pmu_context->cpu_pmu_online =3D __gs101_cpu_pmu_online; >> - pmu_context->cpu_pmu_offline =3D __gs101_cpu_pmu_offline; >> + if (of_machine_is_compatible("google,gs101")) { >> + pmu_context->cpu_pmu_online =3D __gs101_cpu_pmu_online; >> + pmu_context->cpu_pmu_offline =3D __gs101_cpu_pmu_offline= ; >> + } >> + >> + if (of_machine_is_compatible("samsung,exynos850")) { >> + pmu_context->cpu_pmu_online =3D __exynos850_cpu_pmu_onli= ne; >> + pmu_context->cpu_pmu_offline =3D __exynos850_cpu_pmu_off= line; >> > > There should be no compatibles inside probe (that rule applies to all > drivers & subsystems). Instead use the driver match data > (exynos_pmu_data). Thanks. Yep, I'll update it. BR, Alexey