From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Christian Hewitt" <christianshewitt@gmail.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
"Detlev Casanova" <detlev.casanova@collabora.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Sugar Zhang" <sugar.zhang@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
<dri-devel@lists.freedesktop.org>,
<linux-rockchip@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output
Date: Tue, 17 Mar 2026 17:16:11 +0100 [thread overview]
Message-ID: <DH56X74P9GC9.1O123S92J60RG@bootlin.com> (raw)
In-Reply-To: <20260228112822.4056354-1-christianshewitt@gmail.com>
Hello Christian,
On Sat Feb 28, 2026 at 12:28 PM CET, Christian Hewitt wrote:
> From: Jonas Karlman <jonas@kwiboo.se>
>
> Channel Allocation (PB4) and Level Shift Information (PB5) are
> configured with values from PB1 and PB2 due to the wrong offset
> being used. This results in missing audio channels or incorrect
> speaker placement when playing multi-channel audio.
>
> Use the correct offset to fix multi-channel audio output.
>
> Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp")
> Reported-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
While applying this patch to drm-mics-fixes, checkpatch complains:
-:14: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
You can send v3 with the link, or just reply with the link and I'll take
care of adding it to the commit message.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-03-17 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 11:28 [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output Christian Hewitt
2026-03-17 16:16 ` Luca Ceresoli [this message]
2026-03-17 16:49 ` Christian Hewitt
2026-03-17 17:35 ` Luca Ceresoli
2026-03-18 18:12 ` Cristian Ciocaltea
2026-03-18 21:52 ` Luca Ceresoli
2026-03-17 17:29 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH56X74P9GC9.1O123S92J60RG@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=christianshewitt@gmail.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=detlev.casanova@collabora.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=sugar.zhang@rock-chips.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox