From: "Guillaume GONNET" <ggonnet.linux@gmail.com>
To: "Peter Korsgaard" <peter@korsgaard.com>
Cc: "Alasdair Kergon" <agk@redhat.com>,
"Mike Snitzer" <snitzer@kernel.org>,
"Mikulas Patocka" <mpatocka@redhat.com>,
"Benjamin Marzinski" <bmarzins@redhat.com>,
<dm-devel@schwermer.no>, <chanho.min@lge.com>,
<jaeyuel.im@lge.com>, <dm-devel@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <hch@lst.de>
Subject: Re: [PATCH] dm init: ensure device probing has finished in dm-mod.waitfor=
Date: Wed, 18 Mar 2026 10:25:15 +0100 [thread overview]
Message-ID: <DH5ST417XXZ2.BF2S1QWZIQRP@gmail.com> (raw)
In-Reply-To: <87341xh7hc.fsf@dell.be.48ers.dk>
On Wed Mar 18, 2026 at 9:22 AM CET, Peter Korsgaard wrote:
> There is already a wait_for_device_probe() just above the loop, so what
> does this fix exactly? Do we need both?
The mmc_rescan() function (that probes the MMC device) is called in a
delayed work. When the issue occurs, MMC device has not started probing
yet (bacause the work has not been scheduled yet), so the first
wait_for_device_probe() does not wait for it. That's also the reason why
this waitfor parameter exists, otherwise the first wait_for_device_probe
would be enough to wait for the MMC device if probing wasn't deleayed.
The second call ensures that this delayed probing, which includes scaning
avaialble partitions, is done.
That's also what is done for rootwait=, there is a first call to
wait_for_device_probe() in prepare_namespace(), then the busy while loop
in wait_for_root() still wait for probing to be done.
> Interesting enough, I have never encountered this issue myself. I do use
> a partition identifier (dm-mod.waitfor="PARTLABEL=root-a") which
> presumably sidetracks the /dev/mmcblk0 available, but partition table
> not yet parsed issue.
Yes, the issue occurs only when partition scaning has not finished yet.
next prev parent reply other threads:[~2026-03-18 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 21:32 [PATCH] dm init: ensure device probing has finished in dm-mod.waitfor= Guillaume Gonnet
2026-03-18 8:22 ` Peter Korsgaard
2026-03-18 9:25 ` Guillaume GONNET [this message]
2026-03-18 16:36 ` Mikulas Patocka
2026-03-18 17:57 ` Peter Korsgaard
2026-03-18 21:13 ` Mikulas Patocka
2026-03-19 8:47 ` Guillaume Gonnet
2026-03-19 10:53 ` Peter Korsgaard
2026-03-26 21:40 ` Francesco Valla
[not found] ` <abtakh4sU3HldDBB@BRUNHILD>
[not found] ` <DH6N0QM6764O.2CZNT5C8VH6Y1@gmail.com>
2026-03-27 4:33 ` Chanho Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH5ST417XXZ2.BF2S1QWZIQRP@gmail.com \
--to=ggonnet.linux@gmail.com \
--cc=agk@redhat.com \
--cc=bmarzins@redhat.com \
--cc=chanho.min@lge.com \
--cc=dm-devel@lists.linux.dev \
--cc=dm-devel@schwermer.no \
--cc=hch@lst.de \
--cc=jaeyuel.im@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=peter@korsgaard.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox