From: "Danilo Krummrich" <dakr@kernel.org>
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: <abelvesa@kernel.org>, <peng.fan@nxp.com>,
<daniel.baluta@oss.nxp.com>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <Frank.Li@nxp.com>, <s.hauer@pengutronix.de>,
<kernel@pengutronix.de>, <festevam@gmail.com>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<hanguidong02@gmail.com>, <driver-core@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<imx@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
"Alexander Stein" <alexander.stein@ew.tq-group.com>
Subject: Re: [PATCH v2] clk: scu/imx8qxp: do not register driver in probe()
Date: Wed, 18 Mar 2026 16:42:49 +0100 [thread overview]
Message-ID: <DH60U76GPPWN.1UJJ89FKSXOWL@kernel.org> (raw)
In-Reply-To: <177384710701.3709943.608237959975537642.b4-ty@oss.qualcomm.com>
On Wed Mar 18, 2026 at 4:39 PM CET, Abel Vesa wrote:
>
> On Fri, 13 Feb 2026 00:58:11 +0100, Danilo Krummrich wrote:
>> imx_clk_scu_init() registers the imx_clk_scu_driver while commonly being
>> called from IMX driver's probe() callbacks.
>>
>> However, it neither makes sense to register drivers from probe()
>> callbacks of other drivers, nor does the driver core allow registering
>> drivers with a device lock already being held.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] clk: scu/imx8qxp: do not register driver in probe()
> commit: 93a6d39e78bfa78b2160621aafbb490e063f12d9
This is already in Linus' tree, you gave your ACK in [1] for me to take it
through the driver-core tree.
[1] https://lore.kernel.org/all/66i6cgh5zmz32ikwjvrz3gtezjotltqmfzdai7ybwjhanx3bif@i5g62ziautwq/
next prev parent reply other threads:[~2026-03-18 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 23:58 [PATCH v2] clk: scu/imx8qxp: do not register driver in probe() Danilo Krummrich
2026-02-13 8:58 ` Daniel Baluta
2026-02-23 20:21 ` Danilo Krummrich
2026-02-24 9:57 ` Abel Vesa
2026-02-24 12:04 ` Danilo Krummrich
2026-02-25 8:16 ` Peng Fan
2026-02-25 11:31 ` Danilo Krummrich
2026-02-27 0:55 ` Peng Fan
2026-03-18 15:39 ` Abel Vesa
2026-03-18 15:42 ` Danilo Krummrich [this message]
2026-03-18 16:37 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH60U76GPPWN.1UJJ89FKSXOWL@kernel.org \
--to=dakr@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=daniel.baluta@oss.nxp.com \
--cc=driver-core@lists.linux.dev \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanguidong02@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=rafael@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox