From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 966073793DF for ; Thu, 19 Mar 2026 18:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773946693; cv=none; b=R8PTFKACq2RIuTtlZ5rGhVQ1maz29kguk9ANFyIVA88fl+8OQ80xKmmkjJxHGnInO8HItdZ0cTm6ixSVjriBbxD0swB2QY/ABpJiYXoXsL+xBYekV5/7TFWk36DDurlcWPBSwgRo6QkCqDAWK0VpoU5DTWygGLofmdNprlkC/ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773946693; c=relaxed/simple; bh=vwDjQpdj3eWbxanqNgni6K+3Doku4gkbphzj5sRO1uo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=PBq9fcIyaLQYq8yxaDLlBDpKf1wesGo/4LU82icamRjJB5YR2CZy2wijFvo72QqjQoEdfO3XUFkPy8BGh1tjPb63kWMX9SUIrz/CnxvaPuFjwPiEW0nSj0qyOG4qgyoOtmuVk5xfWA/jQ60a28KkLEeruj2Fdnpr6iqIRNZHwXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=afGD6azG; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="afGD6azG" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-64e9f79cae8so968640d50.1 for ; Thu, 19 Mar 2026 11:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773946691; x=1774551491; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HgvdV/GfEnt0ib/0W3RkqfdrYF59W9FuEUvFR8FEk/g=; b=afGD6azGbOllj372Orn5crUC6GAVf0WE3dfQkITYAs/0e56xdSNfumUUdbftOWiCae 5i03dCmuicx91Bg66P4QComTCJQf7dCnspgxOCmM5S53FTUywpG9Jhqro6BpW1p0PBLM g5U1jY9+v5wNIWFwiUoabFKIfBzxl3CufLI0YHgQyZZxRgIMCkoepshHaaFm2luwAyK8 CTKGQ6UMMthyDZAua2ofYR+vnDHslI3HtC6ueZi1U3DuaAE5t0Xl9WwrUWjVPgZdH2SW ydgH+oT5XcBj7hndhQ/wVMsVXd27/q9GYLqvXM5DB/Dx/gXJ3FYX6jf3iJ4no3EILl3t orqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773946691; x=1774551491; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HgvdV/GfEnt0ib/0W3RkqfdrYF59W9FuEUvFR8FEk/g=; b=Q3mm4aQRHj5cbIj/hi73VvafbCTsCKDy+T8vSy1s9tsEsAc1u4qX/SRG2Ut2Pt+q8p 8l8BTDQQUcQowUtxQHfPsJ7uQvO8YqD5rIYnMSlytgqoZZvDPWkDpoJ+7/MgZtPqyjHG ewnxRHFywep72VkQq4OQNX3HSah989YhwgvNX/sK5Jbg5hHZk4UIullGL8jL0evgcmuM 8TTCS5yV7uToiLGteiQzey2TeB2S0QUuZUyrLS9uj+uwVzJN8TwjWLT6S7Q/21gC3X/w rvvutMXW+yvYq5Mg+6wXx1Df1qVsOPki/YlR3B9MMcTZXmyVgz+VtmpQgE49ncwuc+iG c4Iw== X-Forwarded-Encrypted: i=1; AJvYcCWzQf6gSf3vAawTunSPt3+55Y84jZOIoUbdqzjuht5Mkur+qYH1MOQ7Dd1fJxMqQvF7v1ry2JsUCNjoZNQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzp388+zaKGqc9ukGl3tn6vIcTjlDVWrWvJ/CwsoXP2YVks/pNY VXU4fQd8RJVNYDu8tCC+IOLcskLLPV1UgueGsFGY3CVjHzhcInTCFKSC X-Gm-Gg: ATEYQzwdKs6zyMvC1ZYm/YY48qKHjawxfzgEMNiAaxPfOj9vvgzGRdqc+Tg2qPeay3W Ezxx1tVXK5wqGMEPc1EoL/wA+CqyHcOOpoLPPGHdx9vq1KEUPnD8gUtA87+tUNkifjMHPd7EZX1 XlZeS8C1MTSIoeDOeRbTjS1u4zL/0AFnPVp8uhrzk7r00I9KOlmdoeDPIoYMA/B95hbJ8OVKzKO SLkzkR8eW/w35TgACIABjf7PRLvOeNvNjXeGQDQvEx1TBoqOXS8zfr8LE0Xs/TsqNIz0blbrTSi T8/+4t0oVGLqB+xE9dAKzG+dsATl3nHUNE/bgsr8z6tT0K85yHvQa+OmsiJS+XZGo0IRai3km/a LjYlWd9uRBzc08Vk6IzsWulhYlQ6t+DYgJVlboTC2bP8u3dcbHq0dxvN3jT/AlPjG+GCWsoxtKt UpvBjAXEmQ3AAY4tVW68nHLvUkCpOjrnWBDfLov7z3wk8vET4Louqp5wqHyJnc4rqGJhREFsWWY nO7TbqyxHHiqiydCzqe4/+KSTkRzuUE X-Received: by 2002:a05:690e:1b49:b0:64e:a408:4328 with SMTP id 956f58d0204a3-64eaa8118fbmr492104d50.73.1773946691430; Thu, 19 Mar 2026 11:58:11 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e91a47690sm4009610d50.5.2026.03.19.11.58.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 11:58:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Mar 2026 13:58:10 -0500 Message-Id: Cc: Subject: Re: [PATCH] staging: rtl8723bs: break long lines in rtw_sta_mgt.c From: "Ethan Tidmore" To: "MalavyaRaval" , , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260319174229.62021-1-malavyaraval@gmail.com> In-Reply-To: <20260319174229.62021-1-malavyaraval@gmail.com> On Thu Mar 19, 2026 at 12:42 PM CDT, MalavyaRaval wrote: > The original patch attempted to use the preferred sizeof(*ptr) style, > but since the target variable is a u8 pointer, this caused a buffer > overflow. Reverting to sizeof(struct sta_info) ensures the correct > allocation size while satisfying the line-splitting requirement. > > Signed-off-by: MalavyaRaval You need to put FirstName LastName . ... > - pstapriv->pallocated_stainfo_buf =3D vzalloc(sizeof(struct sta_info) * = NUM_STA + 4); > + pstapriv->pallocated_stainfo_buf =3D vzalloc(sizeof(struct sta_info) * > + NUM_STA + 4); This just makes the code harder to read. Thanks, ET