From: "Benno Lossin" <lossin@kernel.org>
To: <alistair23@gmail.com>, <linux-kernel@vger.kernel.org>,
<rust-for-linux@vger.kernel.org>, <aliceryhl@google.com>,
<ojeda@kernel.org>
Cc: "Alistair Francis" <alistair.francis@wdc.com>
Subject: Re: [PATCH] rust: Mark all from() for Error functions inline
Date: Fri, 20 Mar 2026 09:15:59 +0100 [thread overview]
Message-ID: <DH7GL60ZUTSS.3UAGWO0GIJ01O@kernel.org> (raw)
In-Reply-To: <20260320011844.2264931-1-alistair.francis@wdc.com>
On Fri Mar 20, 2026 at 2:18 AM CET, alistair23 wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Mark all of the existing
>
> impl From<...> for Error {
> fn from(err: ...) -> Self {
> ...
> }
> }
>
> functions as `#[inline]`
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> rust/kernel/alloc/kvec/errors.rs | 3 +++
> rust/kernel/error.rs | 6 ++++++
> rust/kernel/ptr/projection.rs | 2 +-
> rust/kernel/xarray.rs | 1 +
> rust/pin-init/examples/error.rs | 2 ++
> rust/pin-init/examples/pthread_mutex.rs | 2 ++
Please split the pin-init changes into a separate patch.
Also note that I prefer to take patches to pin-init upstream:
https://github.com/rust-for-linux/pin-init
I'm also open to picking it from the mailing list if you don't want to
go to GitHub.
Cheers,
Benno
> rust/syn/error.rs | 1 +
> 7 files changed, 16 insertions(+), 1 deletion(-)
prev parent reply other threads:[~2026-03-20 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 1:18 [PATCH] rust: Mark all from() for Error functions inline alistair23
2026-03-20 2:55 ` Miguel Ojeda
2026-03-20 8:15 ` Benno Lossin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH7GL60ZUTSS.3UAGWO0GIJ01O@kernel.org \
--to=lossin@kernel.org \
--cc=aliceryhl@google.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox