From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DB3436826B for ; Fri, 20 Mar 2026 15:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774019204; cv=none; b=dqGFeTjvFmvdi18JczgPoMvqBPVDgDVgeJDG5AQyt87/WcomiOpXGoZ7UMle2fjK6JLXGn7SRvJkpscYStL9xMJ1S6GMIMtoQ7ZFTBe+ux2rBYyI50oP5LvvjJPTp9eiDZa2ROGIXWW9OlucU6NdSHfNSgRE9lXnupjQrAxigTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774019204; c=relaxed/simple; bh=+gY0U88ZU3WFbE3S3UKhriDpSE3AB91y+8EwGdS+r/8=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=ce33oyTIg1a5aFkNEXiLY12Lbovq46KhTvZAQ50maRCL7WHfxh26uiS7k6lNAiDCdMgDo3Z/9yYF15Oo5wL9dfGNDthKNeuzWUYGXqEoIJa6wDgprMTyfG6CCMcZFi1YPAqBG1s7ooEbd9wLEMnNuXAAQLrlQWd0rU+5w5AEaIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ru+5fBvc; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ru+5fBvc" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774019191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+gY0U88ZU3WFbE3S3UKhriDpSE3AB91y+8EwGdS+r/8=; b=ru+5fBvcm+pEAo0/qfX05QZrWp0JkVZkWaK/eGQezaL3cnyirJyZv/JIfWcEZr2udZrJys gL0u5/AscC8IMzlMsA/pii/52ijo4kxbVFlQM1NI/KKq0zjVsmDEwfSU0xz/UNh7xUJ8EN tSAdsI23J8B4l9To3y/mCEgDpxusVNI= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Mar 2026 23:05:33 +0800 Message-Id: Subject: Re: [PATCH 1/1] usb: dwc3: dwc3-generic-plat: Add optional VBUS regulator support X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Ze Huang" To: "Chukun Pan" , Cc: , , , , , , References: <20260320104026.1350571-1-amadeus@jmu.edu.cn> In-Reply-To: <20260320104026.1350571-1-amadeus@jmu.edu.cn> X-Migadu-Flow: FLOW_OUT On Fri Mar 20, 2026 at 6:40 PM CST, Chukun Pan wrote: > Hi, > >> I think it's better to align the driver with the actual hardware. I'm no= t >> opposed to managing any regulators in usb host/device drivers. But if we >> do have an onboard hub, and regulator belongs to the downstream ports of >> the hub, then it's hub's job, right? > >> Many boards leave gpio controlled regulators always on, that's what we >> want to solve. If we have to choose the parent of these regulators, why >> not put them in the correct hierarchy? > > I think we can manage the regulator in the USB host driver first, > and then use it after the onboard_usb_dev driver has been merged. > This is better than keeping the regulator always on. > >> If such a board really need the regulator, IMO, your patch is the way to= go. >> >> OrangePi haven't released the schematic yet. >> >> That's what I could find [1], which seems similar to RV2. > > There is no onboard USB hub. Just check the image: > > http://www.orangepi.org/img/r2s/details/17.png > http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details= /Orange-Pi-R2S.html > That's fine, thanks. > Thanks, > Chukun