From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F49B282F31 for ; Sat, 21 Mar 2026 23:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774135335; cv=none; b=e/jeDVD0RBix9Tl2lYXbPQ7XGAj8a8iM+t4QhJGLTqefrtvhkoN6XSWIztwQk+BB9NJYRJKauCFvhfwk6T2vUGM/AaTOTSzC2Ke3Seabufz4lFjuBsXTCYGb7XXXH95GoJhGJJidFQscDzmn7VkCwVKNdiWji2xInp9+l7+T9rU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774135335; c=relaxed/simple; bh=qNeJkCdabtlCm7cDTMYLL0emh9Mqvxu3XdKIuu1nM1E=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=OdeXN6Sz+Esd4whRKrJo+fVKSTnGECCjeEqAyXLpjw1xDwPha9F9NwwuYaa8Y7bzFMmFTmlvZ02HXoHQM4nrcaHb6vmL6HWxWnos2httdEWl166nTut39yWkxA2Lr/wtPN4h6OTdMbmSmM7hyarJnXOBQxIwZHI+JucVE9980xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RQYIDMGN; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RQYIDMGN" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2c107ef474fso2727450eec.0 for ; Sat, 21 Mar 2026 16:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774135334; x=1774740134; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UmSlASJxZ4qJNq9Ag8r4ipXI8Q0Axl649+ut2f+sZl0=; b=RQYIDMGNQYRLzKO63eDzWfTNup9KYswZxYOa5I0CDoynJc8Mdrc+GrE2q8fdJDV6LE DJsgwupddZfGlVDIqmrirpFWa/1Nt1y7t4gwijOSAvBlW31YIAel5g3FvmrTPsWwuNLq kgzlgLb5bhF81V3Fs0/+wsDfmUXfe7BwpyNVBMamk+dzDeHneTmCIr0+096TOsK1qdP6 HW46kULwAYw0qHleDWxf+EgRuFne9j9gpiNHvKtPUVVu4sqe2mEOO5dK/KwPB/pmBkly XJmgJb1kchnAE85+R8A68dAoJpE8wmKAfBtYjZNmRNKplU+cW7ZJehOwiKJthC35wxfq izVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774135334; x=1774740134; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UmSlASJxZ4qJNq9Ag8r4ipXI8Q0Axl649+ut2f+sZl0=; b=ZquCD3JWF/J3O3NUWEc5lpkCyI6bFPCOgHwn/xBe9L1xWF+u9Pe5zfntgS2xcKEhzz 4Ck5JtEvQJ6mI7FCZFxgRQMsc8UTGMIXSCpP1i3QSZHt5w+NBsOAIcBv5/c/JA8BHwRR 5s3BnW1VvlTaMtAltGOgF8neGAajMylod4G4BewPWVnTXoy6ZPQyR9Uj+KpEUNf5wC4g lVCRpsy1/vEeI/mize0+KEsv5tYQS+FHLWtw8h2hhGMsnUi3V3DNTHGjeFYtQUZ6CveJ MHeZIDu3lqluyOTkBON2fGkMIcWh/c82T2EIYJeUDMqNjWyUbZE2O3/HjENhB2BDgeE3 xmiw== X-Forwarded-Encrypted: i=1; AJvYcCU5R/l7Fzi/Vwwpp1rkehQN9HSbabopmaoYZiJIus29D4cOv6gAVD2ATjH/uXGpcL2MhMQLgdY6XPXa9xo=@vger.kernel.org X-Gm-Message-State: AOJu0YwB5p6fy3Dzh5GI9TKXXMG03lga8IUGKb/pn/366k63B3rp1mWE yuo+sYuDVxyHA0pAqIX+hQNP2kB4YIL2UeZXvg6qeR7r4Suc+R+8k0E5 X-Gm-Gg: ATEYQzwWxCZkvsWCISXFOKzmazD3o6CLncH9UUB8W8eSRDU+P23Cu0kcN/89bT2esQB c1wAj9+8A0GMPS9ByIkVgnqGfZJVW11Jx03ibmTFYIAmpeKHNtI2KespXoX3eWSCnjNPndfwttw 9hneqNgitVNH1mc+X6LZ/iOqw4yt3tRWJ+INBPRM4ybBsxTKh6e/9VT6z7hjTtt+MVdWHCRq3VX kbeLf0w0+h2eGfTsm73uEXBqPi0d2k62FFM+52kVS6fXBAV93RDEXprNdhxvyNWs2D4GHje3yzQ TLrNLSvWdG90+WlDjWkCTsU8MYqc3sCZYFQNvYuqt2s5qOAwAqeQky544lJSBrkd6/hg9EFRX9/ +EiMZX/glpBPJzkLnI06BW7uzKfjuKpQ/bxVNPSK203qIISo8twuZ8D5TlWUuKlbFruHZwq/a4u ibZh+ccZyAKMEhtF1CENNOb8ZwLOhL0If6x7lzPkDbC3GA X-Received: by 2002:a05:7300:3c05:b0:2be:140c:bc4a with SMTP id 5a478bee46e88-2c1095d7855mr4154948eec.3.1774135333601; Sat, 21 Mar 2026 16:22:13 -0700 (PDT) Received: from localhost ([2603:8000:bb00:9b3f::18f6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b14bac4sm10927970eec.4.2026.03.21.16.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Mar 2026 16:22:13 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 21 Mar 2026 16:22:09 -0700 Message-Id: Cc: , , , , Subject: Re: [PATCH v2 2/8] rust: dma: add generalized container for types other than slices From: "Aditya Rajan" To: "Danilo Krummrich" , , , , , , , , , , , , X-Mailer: aerc 0.21.0 References: <20260320194626.36263-1-dakr@kernel.org> <20260320194626.36263-3-dakr@kernel.org> In-Reply-To: <20260320194626.36263-3-dakr@kernel.org> On Fri Mar 20, 2026 at 12:45 PM PDT, Danilo Krummrich wrote: > diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs > index 2eea7e2f8f04..ff3e147f1a23 100644 > --- a/rust/kernel/dma.rs > +++ b/rust/kernel/dma.rs > +impl Coherent<[T]> { > /// Returns the number of elements `T` in this allocation. > /// > /// Note that this is not the size of the allocation in bytes, which= is provided by > /// [`Self::size`]. > - pub fn count(&self) -> usize { > - self.count There is still a mention of `self.count` in the safety comments; perhaps th= at should be changed to `self.len()` ? For example, see the safety comments in the following functions: `as_slice`= , `as_slice_mut`, and `write` in same file.