[PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Aadarsh Mandal]

fixed the warnings,reported by checkpatch in
drivers/staging/rtl8723bs/hal/sdio_halinit.c

It mainly included the leading whitespace errors and commented line
of codes, deleted those lines rebuild the module and it didn't produced
any errors. one warning remains, fixing it breaks the logic.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 54 ++++++++++----------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index e32f051ed415..70a5213ae52a 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -46,7 +46,7 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
 	u16 value16;
 	u32 value32;
 	u8 ret;
-/* 	u8 bMacPwrCtrlOn; */
+
 
 
 	/*  all of these MUST be configured before power on */
@@ -70,8 +70,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
 	rtw_write16(padapter, REG_APS_FSMCO, value16);
 
 	/*  Enable CMD53 R/W Operation */
-/* 	bMacPwrCtrlOn = true; */
-/* 	rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */
 
 	rtw_write8(padapter, REG_CR, 0x00);
 	/*  Enable MAC DMA/WMAC/SCHEDULE/SEC block */
@@ -214,6 +212,7 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)
 	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
 
 	u16 value = 0;
+
 	switch (pHalData->OutEpQueueSel) {
 	case TX_SELE_HQ:
 		value = QUEUE_HIGH;
@@ -341,6 +340,7 @@ static void _InitTransferPageSize(struct adapter *padapter)
 	/*  Tx page size is always 128. */
 
 	u8 value8;
+
 	value8 = _PSRX(PBP_128) | _PSTX(PBP_128);
 	rtw_write8(padapter, REG_PBP, value8);
 }
@@ -357,7 +357,6 @@ static void _InitNetworkType(struct adapter *padapter)
 	value32 = rtw_read32(padapter, REG_CR);
 
 	/*  TODO: use the other function to set network type */
-/* 	value32 = (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AD_HOC); */
 	value32 = (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AP);
 
 	rtw_write32(padapter, REG_CR, value32);
@@ -485,7 +484,7 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
 
 	/*  Tx aggregation setting */
-/* 	sdio_AggSettingTxUpdate(padapter); */
+/*	sdio_AggSettingTxUpdate(padapter); */
 
 	/*  Rx aggregation setting */
 	HalRxAggr8723BSdio(padapter);
@@ -639,7 +638,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 	}
 
 	/*  Disable Interrupt first. */
-/* 	rtw_hal_disable_interrupt(padapter); */
+/*	rtw_hal_disable_interrupt(padapter); */
 
 	ret = _InitPowerOn_8723BS(padapter);
 	if (ret == _FAIL)
@@ -659,7 +658,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 
 	rtl8723b_InitializeFirmwareVars(padapter);
 
-/* 	SIC_Init(padapter); */
+/*	SIC_Init(padapter); */
 
 	if (pwrctrlpriv->reg_rfoff)
 		pwrctrlpriv->rf_pwrstate = rf_off;
@@ -745,8 +744,8 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 
 	/*  Record original value for template. This is arough data, we can only use the data */
 	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/* 	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/* 	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
+/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
+/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
 
 	rtl8723b_InitAntenna_Selection(padapter);
 
@@ -789,7 +788,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 	/* ack for xmit mgmt frames. */
 	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));
 
-/* 	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
+/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
 
 	{
 		pwrctrlpriv->rf_pwrstate = rf_on;
@@ -842,7 +841,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 
 /*  */
 /*  Description: */
-/* 	RTL8723e card disable power sequence v003 which suggested by Scott. */
+/*  RTL8723e card disable power sequence v003 which suggested by Scott. */
 /*  */
 /*  First created by tynli. 2011.01.28. */
 /*  */
@@ -854,7 +853,7 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter)
 	/*  Run LPS WL RFOFF flow */
 	HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow);
 
-	/* 	==== Reset digital sequence   ====== */
+	/*	==== Reset digital sequence   ====== */
 
 	val = rtw_read8(padapter, REG_MCUFWDL);
 	if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */
@@ -877,7 +876,7 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter)
 	val |= BIT(0);
 	rtw_write8(padapter, REG_RSV_CTRL + 1, val);
 
-	/* 	==== Reset digital sequence end ====== */
+	/*	==== Reset digital sequence end ====== */
 
 	bMacPwrCtrlOn = false;	/*  Disable CMD53 R/W */
 	rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
@@ -979,13 +978,13 @@ void rtl8723bs_interface_configure(struct adapter *padapter)
 }
 
 /*  */
-/* 	Description: */
-/* 		We should set Efuse cell selection to WiFi cell in default. */
+/*	Description: */
+/*	We should set Efuse cell selection to WiFi cell in default. */
 /*  */
-/* 	Assumption: */
-/* 		PASSIVE_LEVEL */
+/*	Assumption: */
+/*	PASSIVE_LEVEL */
 /*  */
-/* 	Added by Roger, 2010.11.23. */
+/*	Added by Roger, 2010.11.23. */
 /*  */
 static void _EfuseCellSel(struct adapter *padapter)
 {
@@ -1071,24 +1070,24 @@ static void _ReadEfuseInfo8723BS(struct adapter *padapter)
 static void _ReadPROMContent(struct adapter *padapter)
 {
 	struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
-	u8 	eeValue;
+	u8 eeValue;
 
 	eeValue = rtw_read8(padapter, REG_9346CR);
 	/*  To check system boot selection. */
 	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
 	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;
 
-/* 	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
+/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
 
 	_ReadEfuseInfo8723BS(padapter);
 }
 
 /*  */
-/* 	Description: */
-/* 		Read HW adapter information by E-Fuse or EEPROM according CR9346 reported. */
+/*	Description: */
+/*	Read HW adapter information by E-Fuse or EEPROM according CR9346 reported. */
 /*  */
-/* 	Assumption: */
-/* 		PASSIVE_LEVEL (SDIO interface) */
+/*	Assumption: */
+/*	PASSIVE_LEVEL (SDIO interface) */
 /*  */
 /*  */
 static s32 _ReadAdapterInfo8723BS(struct adapter *padapter)
@@ -1147,6 +1146,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
 	case HW_VAR_SET_REQ_FW_PS:
 		{
 			u8 req_fw_ps = 0;
+
 			req_fw_ps = rtw_read8(padapter, 0x8f);
 			req_fw_ps |= 0x10;
 			rtw_write8(padapter, 0x8f, req_fw_ps);
@@ -1200,14 +1200,14 @@ void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int l
 }
 
 /*  */
-/* 	Description: */
-/* 		Query setting of specified variable. */
+/*	Description: */
+/*	Query setting of specified variable. */
 /*  */
 u8 GetHalDefVar8723BSDIO(
 	struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue
 )
 {
-	u8 	bResult = _SUCCESS;
+	u8 bResult = _SUCCESS;
 
 	switch (eVariable) {
 	case HAL_DEF_IS_SUPPORT_ANT_DIV:
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Luka Gejak]

On March 18, 2026 3:10:05 AM GMT+01:00, Aadarsh Mandal <aadarshmandal9354@gmail.com> wrote:
>fixed the warnings,reported by checkpatch in
>drivers/staging/rtl8723bs/hal/sdio_halinit.c
>
>It mainly included the leading whitespace errors and commented line
>of codes, deleted those lines rebuild the module and it didn't produced
>any errors. one warning remains, fixing it breaks the logic.
>
>Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>---
>Note:
>* This patch is part of the GSoC2026 application process for device tree bindings conversions
>* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 54 ++++++++++----------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
>diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>index e32f051ed415..70a5213ae52a 100644
>--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>@@ -46,7 +46,7 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
> 	u16 value16;
> 	u32 value32;
> 	u8 ret;
>-/* 	u8 bMacPwrCtrlOn; */
>+
By deleting this commented-out line and replacing it with a `+` on an empty line, you are introducing extra blank lines into the code. You should just delete the commented line entirely without leaving a gap.
> 
> 
> 	/*  all of these MUST be configured before power on */
>@@ -70,8 +70,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
> 	rtw_write16(padapter, REG_APS_FSMCO, value16);
> 
> 	/*  Enable CMD53 R/W Operation */
>-/* 	bMacPwrCtrlOn = true; */
>-/* 	rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */
The standard practice in the kernel is to completely delete dead or commented-out code rather than re-indenting it. If the code is no longer used, it is better to just remove it entirely. Re-formatting dead code usually isn't accepted in staging cleanups.

>@@ -1147,6 +1146,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
> 	case HW_VAR_SET_REQ_FW_PS:
> 		{
> 			u8 req_fw_ps = 0;
>+
> 			req_fw_ps = rtw_read8(padapter, 0x8f);
> 			req_fw_ps |= 0x10;
> 			rtw_write8(padapter, 0x8f, req_fw_ps);
This is a good fix. Adding the blank line after the variable declaration improves readability and follows the kernel coding style.

Hope this helps with your v2!

Best regards,
Luka Gejak
Hi Aadarsh,

Thanks for submitting this patch, and good luck with your GSoC application!

I am also currently working on cleanups for
the rtl8723bs driver. I took a look at your
patch and noticed a few formatting and logic
issues that you might want to fix in a v2 before the maintainers review it.

First, your subject line does not match the standard format for this subsystem. It should start with "staging: rtl8723bs: " and be more descriptive of the actual changes rather than mentioning the tool used. Something like:
"staging: rtl8723bs: clean up coding style in sdio_halinit.c"

I have left a few specific inline comments below regarding the code changes.

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Luka Gejak]

Hi Aadarsh,

Thanks for submitting this patch, and good luck with your GSoC application!

I am also currently working on cleanups for
the rtl8723bs driver. I took a look at your
patch and noticed a few formatting and logic
issues that you might want to fix in a v2 before the maintainers review it.

First, your subject line does not match the standard format for this subsystem. It should start with "staging: rtl8723bs: " and be more descriptive of the actual changes rather than mentioning the tool used. Something like:
"staging: rtl8723bs: clean up coding style in sdio_halinit.c"

I have left a few specific inline comments below regarding the code changes.

On March 18, 2026 3:10:05 AM GMT+01:00, Aadarsh Mandal <aadarshmandal9354@gmail.com> wrote:
fixed the warnings,reported by checkpatch in
drivers/staging/rtl8723bs/hal/sdio_halinit.c

It mainly included the leading whitespace errors and commented line
of codes, deleted those lines rebuild the module and it didn't produced
any errors. one warning remains, fixing it breaks the logic.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 54 ++++++++++----------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index e32f051ed415..70a5213ae52a 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -46,7 +46,7 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
 	u16 value16;
 	u32 value32;
 	u8 ret;
-/* 	u8 bMacPwrCtrlOn; */
+
By deleting this commented-out line and replacing it with a `+` on an empty line, you are introducing extra blank lines into the code. You should just delete the commented line entirely without leaving a gap.
 
 
 	/*  all of these MUST be configured before power on */
@@ -70,8 +70,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
 	rtw_write16(padapter, REG_APS_FSMCO, value16);
 
 	/*  Enable CMD53 R/W Operation */
-/* 	bMacPwrCtrlOn = true; */
-/* 	rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */
The standard practice in the kernel is to completely delete dead or commented-out code rather than re-indenting it. If the code is no longer used, it is better to just remove it entirely. Re-formatting dead code usually isn't accepted in staging cleanups.

@@ -1147,6 +1146,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
 	case HW_VAR_SET_REQ_FW_PS:
 		{
 			u8 req_fw_ps = 0;
+
 			req_fw_ps = rtw_read8(padapter, 0x8f);
 			req_fw_ps |= 0x10;
 			rtw_write8(padapter, 0x8f, req_fw_ps);
This is a good fix. Adding the blank line after the variable declaration improves readability and follows the kernel coding style.

Hope this helps with your v2!

Best regards,
Luka Gejak

[PATCH] [PATCH] staging: rtl8723bs: clean up coding style in sdio_halinit.c V2

[Aadarsh Mandal]

update since v1:
- fixed the changes mentioned by the Luka Gejak
- removed the commented code and space

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 163 ++++++++++++++++++-
 1 file changed, 161 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 1026554bcff0..063a0737933e 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -6,7 +6,6 @@
  ******************************************************************************/
 #include <drv_types.h>
 #include <rtl8723b_hal.h>
-
 #include "hal_com_h2c.h"
 /*
  * Description:
@@ -69,8 +68,8 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
 	rtw_write16(padapter, REG_APS_FSMCO, value16);
 
 	/*  Enable CMD53 R/W Operation */
-
 	rtw_write8(padapter, REG_CR, 0x00);
+
 	/*  Enable MAC DMA/WMAC/SCHEDULE/SEC block */
 	value16 = rtw_read16(padapter, REG_CR);
 	value16 |= (
@@ -483,6 +479,158 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
 
 	/*  Tx aggregation setting */
+/*	sdio_AggSettingTxUpdate(padapter); */
+
+	/*  Rx aggregation setting */
+	HalRxAggr8723BSdio(padapter);
+
+	sdio_AggSettingRxUpdate(padapter);
+
+	/*  201/12/10 MH Add for USB agg mode dynamic switch. */
+	pHalData->UsbRxHighSpeedMode = false;
+}
+
+static void _InitOperationMode(struct adapter *padapter)
+{
+	struct mlme_ext_priv *pmlmeext;
+	u8 regBwOpMode = 0;
+
+	pmlmeext = &padapter->mlmeextpriv;
+
+	/* 1 This part need to modified according to the rate set we filtered!! */
+	/*  */
+	/*  Set RRSR, RATR, and REG_BWOPMODE registers */
+	/*  */
+	switch (pmlmeext->cur_wireless_mode) {
+	case WIRELESS_MODE_B:
+		regBwOpMode = BW_OPMODE_20MHZ;
+		break;
+	case WIRELESS_MODE_G:
+		regBwOpMode = BW_OPMODE_20MHZ;
+		break;
+	case WIRELESS_MODE_AUTO:
+		regBwOpMode = BW_OPMODE_20MHZ;
+		break;
+	case WIRELESS_MODE_N_24G:
+		/*  It support CCK rate by default. */
+		/*  CCK rate will be filtered out only when associated AP does not support it. */
+		regBwOpMode = BW_OPMODE_20MHZ;
+		break;
+
+	default: /* for MacOSX compiler warning. */
+		break;
+	}
+
+	rtw_write8(padapter, REG_BWOPMODE, regBwOpMode);
+}
+
+static void _InitInterrupt(struct adapter *padapter)
+{
+	/*  HISR - turn all off */
+	rtw_write32(padapter, REG_HISR, 0);
+
+	/*  HIMR - turn all off */
+	rtw_write32(padapter, REG_HIMR, 0);
+
+	/*  */
+	/*  Initialize and enable SDIO Host Interrupt. */
+	/*  */
+	InitInterrupt8723BSdio(padapter);
+
+	/*  */
+	/*  Initialize system Host Interrupt. */
+	/*  */
+	InitSysInterrupt8723BSdio(padapter);
+}
+
+static void _InitRFType(struct adapter *padapter)
+{
+	struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
+
+	pHalData->rf_chip	= RF_6052;
+}
+
+static void _RfPowerSave(struct adapter *padapter)
+{
+/* YJ, TODO */
+}
+
+/*  */
+/*  2010/08/09 MH Add for power down check. */
+/*  */
+static bool HalDetectPwrDownMode(struct adapter *Adapter)
+{
+	u8 tmpvalue;
+	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
+	struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(Adapter);
+
+	EFUSE_ShadowRead(Adapter, 1, 0x7B/*EEPROM_RF_OPT3_92C*/, (u32 *)&tmpvalue);
+
+	/*  2010/08/25 MH INF priority > PDN Efuse value. */
+	if (tmpvalue & BIT4 && pwrctrlpriv->reg_pdnmode)
+		pHalData->pwrdown = true;
+	else
+		pHalData->pwrdown = false;
+
+	return pHalData->pwrdown;
+}	/*  HalDetectPwrDownMode */
+
+u32 rtl8723bs_hal_init(struct adapter *padapter)
+{
+	s32 ret;
+	struct hal_com_data *pHalData;
+	struct pwrctrl_priv *pwrctrlpriv;
+	u32 NavUpper = WiFiNavUpperUs;
+	u8 val;
+
+	pHalData = GET_HAL_DATA(padapter);
+	pwrctrlpriv = adapter_to_pwrctl(padapter);
+
+	if (
+		adapter_to_pwrctl(padapter)->bips_processing == true &&
+		adapter_to_pwrctl(padapter)->pre_ips_type == 0
+	) {
+		unsigned long start_time;
+		u8 cpwm_orig, cpwm_now;
+		u8 val8, bMacPwrCtrlOn = true;
+
+		/* for polling cpwm */
+		cpwm_orig = 0;
+		rtw_hal_get_hwreg(padapter, HW_VAR_CPWM, &cpwm_orig);
+
+		/* set rpwm */
+		val8 = rtw_read8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HRPWM1);
+		val8 &= 0x80;
+		val8 += 0x80;
+		val8 |= BIT(6);
+		rtw_write8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HRPWM1, val8);
+		adapter_to_pwrctl(padapter)->tog = (val8 + 0x80) & 0x80;
+
+		/* do polling cpwm */
+		start_time = jiffies;
+		do {
+			mdelay(1);
+
+			rtw_hal_get_hwreg(padapter, HW_VAR_CPWM, &cpwm_now);
+			if ((cpwm_orig ^ cpwm_now) & 0x80)
+				break;
+
+			if (jiffies_to_msecs(jiffies - start_time) > 100)
+				break;
+
+		} while (1);
+
+		rtl8723b_set_FwPwrModeInIPS_cmd(padapter, 0);
+
+		rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
+
+		hal_btcoex_InitHwConfig(padapter, false);
+
+		return _SUCCESS;
+	}
+
+	/*  Disable Interrupt first. */
+/*	rtw_hal_disable_interrupt(padapter); */
 
 	ret = _InitPowerOn_8723BS(padapter);
 	if (ret == _FAIL)
@@ -588,6 +739,8 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 
 	/*  Record original value for template. This is arough data, we can only use the data */
 	/*  for power adjust. The value can not be adjustde according to different power!!! */
+/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
+/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
 
 	rtl8723b_InitAntenna_Selection(padapter);
 
@@ -630,6 +783,7 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 	/* ack for xmit mgmt frames. */
 	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));
 
+/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
 
 	{
 		pwrctrlpriv->rf_pwrstate = rf_on;
@@ -918,6 +1072,8 @@ static void _ReadPROMContent(struct adapter *padapter)
 	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
 	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;
 
+/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
+
 	_ReadEfuseInfo8723BS(padapter);
 }
 
-- 
2.43.0

Re: [PATCH] [PATCH] staging: rtl8723bs: clean up coding style in sdio_halinit.c V2

[Luka Gejak]

Hi Aadarsh,

Thanks for sending the v2. It is great that you are working on these cleanups!

However, it looks like something went wrong with your local git tree when generating this patch. Instead of removing the dead code, this patch actually adds 161 lines to the file. It re-adds the commented-out code (e.g., `+/* sdio_AggSettingTxUpdate(padapter); */`) and inserts several large functions that shouldn't be part of a simple style cleanup. 

You might have accidentally reverted your changes, diffed against the wrong branch, or merged something incorrectly. I recommend doing a fresh "git fetch" from the staging tree, creating a new branch, and doing the cleanups again.

Also, for your v3, here are two quick formatting tips for the patch email:

1. Subject Line: Your subject currently says "[PATCH] [PATCH] ... V2". The standard kernel format is "[PATCH v2] staging: rtl8723bs: clean up...". You can generate this automatically by using the "-v" flag:  "git format-patch -v3 ..."

2. Changelog Placement: Your version history ("update since v1...") is currently in the main commit body. Anything above the "---" line becomes the permanent commit message in the Linux kernel history. 

For a single patch, you should place your changelog notes below the "---" line so they are dropped when the maintainer applies the patch. Alternatively, if you decide to break your cleanups into multiple patches (a patch series), you should generate a cover letter ("git format-patch -v3 --cover-letter ...") and put your version history in the cover letter instead.

Always double-check your generated ".patch" file with a text editor or "cat" before sending to make sure the diff only contains the exact lines you intended to change.

Also, for future versions of this series or any further discussions, please use my developer address luka.gejak@linux.dev in the CC list instead of my Gmail account. This helps me keep my kernel work organized and consistent with my own patches.

Looking forward to v3!

Best regards,
Luka Gejak

On March 18, 2026 10:26:39 AM GMT+01:00, Aadarsh Mandal <aadarshmandal9354@gmail.com> wrote:
>update since v1:
>- fixed the changes mentioned by the Luka Gejak
>- removed the commented code and space
>
>Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>---
>Note:
>* This patch is part of the GSoC2026 application process for device tree bindings conversions
>* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 163 ++++++++++++++++++-
> 1 file changed, 161 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>index 1026554bcff0..063a0737933e 100644
>--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>@@ -6,7 +6,6 @@
>  ******************************************************************************/
> #include <drv_types.h>
> #include <rtl8723b_hal.h>
>-
> #include "hal_com_h2c.h"
> /*
>  * Description:
>@@ -69,8 +68,8 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
> 	rtw_write16(padapter, REG_APS_FSMCO, value16);
> 
> 	/*  Enable CMD53 R/W Operation */
>-
> 	rtw_write8(padapter, REG_CR, 0x00);
>+
> 	/*  Enable MAC DMA/WMAC/SCHEDULE/SEC block */
> 	value16 = rtw_read16(padapter, REG_CR);
> 	value16 |= (
>@@ -483,6 +479,158 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
> 	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
> 
> 	/*  Tx aggregation setting */
>+/*	sdio_AggSettingTxUpdate(padapter); */
>+
>+	/*  Rx aggregation setting */
>+	HalRxAggr8723BSdio(padapter);
>+
>+	sdio_AggSettingRxUpdate(padapter);
>+
>+	/*  201/12/10 MH Add for USB agg mode dynamic switch. */
>+	pHalData->UsbRxHighSpeedMode = false;
>+}
>+
>+static void _InitOperationMode(struct adapter *padapter)
>+{
>+	struct mlme_ext_priv *pmlmeext;
>+	u8 regBwOpMode = 0;
>+
>+	pmlmeext = &padapter->mlmeextpriv;
>+
>+	/* 1 This part need to modified according to the rate set we filtered!! */
>+	/*  */
>+	/*  Set RRSR, RATR, and REG_BWOPMODE registers */
>+	/*  */
>+	switch (pmlmeext->cur_wireless_mode) {
>+	case WIRELESS_MODE_B:
>+		regBwOpMode = BW_OPMODE_20MHZ;
>+		break;
>+	case WIRELESS_MODE_G:
>+		regBwOpMode = BW_OPMODE_20MHZ;
>+		break;
>+	case WIRELESS_MODE_AUTO:
>+		regBwOpMode = BW_OPMODE_20MHZ;
>+		break;
>+	case WIRELESS_MODE_N_24G:
>+		/*  It support CCK rate by default. */
>+		/*  CCK rate will be filtered out only when associated AP does not support it. */
>+		regBwOpMode = BW_OPMODE_20MHZ;
>+		break;
>+
>+	default: /* for MacOSX compiler warning. */
>+		break;
>+	}
>+
>+	rtw_write8(padapter, REG_BWOPMODE, regBwOpMode);
>+}
>+
>+static void _InitInterrupt(struct adapter *padapter)
>+{
>+	/*  HISR - turn all off */
>+	rtw_write32(padapter, REG_HISR, 0);
>+
>+	/*  HIMR - turn all off */
>+	rtw_write32(padapter, REG_HIMR, 0);
>+
>+	/*  */
>+	/*  Initialize and enable SDIO Host Interrupt. */
>+	/*  */
>+	InitInterrupt8723BSdio(padapter);
>+
>+	/*  */
>+	/*  Initialize system Host Interrupt. */
>+	/*  */
>+	InitSysInterrupt8723BSdio(padapter);
>+}
>+
>+static void _InitRFType(struct adapter *padapter)
>+{
>+	struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
>+
>+	pHalData->rf_chip	= RF_6052;
>+}
>+
>+static void _RfPowerSave(struct adapter *padapter)
>+{
>+/* YJ, TODO */
>+}
>+
>+/*  */
>+/*  2010/08/09 MH Add for power down check. */
>+/*  */
>+static bool HalDetectPwrDownMode(struct adapter *Adapter)
>+{
>+	u8 tmpvalue;
>+	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
>+	struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(Adapter);
>+
>+	EFUSE_ShadowRead(Adapter, 1, 0x7B/*EEPROM_RF_OPT3_92C*/, (u32 *)&tmpvalue);
>+
>+	/*  2010/08/25 MH INF priority > PDN Efuse value. */
>+	if (tmpvalue & BIT4 && pwrctrlpriv->reg_pdnmode)
>+		pHalData->pwrdown = true;
>+	else
>+		pHalData->pwrdown = false;
>+
>+	return pHalData->pwrdown;
>+}	/*  HalDetectPwrDownMode */
>+
>+u32 rtl8723bs_hal_init(struct adapter *padapter)
>+{
>+	s32 ret;
>+	struct hal_com_data *pHalData;
>+	struct pwrctrl_priv *pwrctrlpriv;
>+	u32 NavUpper = WiFiNavUpperUs;
>+	u8 val;
>+
>+	pHalData = GET_HAL_DATA(padapter);
>+	pwrctrlpriv = adapter_to_pwrctl(padapter);
>+
>+	if (
>+		adapter_to_pwrctl(padapter)->bips_processing == true &&
>+		adapter_to_pwrctl(padapter)->pre_ips_type == 0
>+	) {
>+		unsigned long start_time;
>+		u8 cpwm_orig, cpwm_now;
>+		u8 val8, bMacPwrCtrlOn = true;
>+
>+		/* for polling cpwm */
>+		cpwm_orig = 0;
>+		rtw_hal_get_hwreg(padapter, HW_VAR_CPWM, &cpwm_orig);
>+
>+		/* set rpwm */
>+		val8 = rtw_read8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HRPWM1);
>+		val8 &= 0x80;
>+		val8 += 0x80;
>+		val8 |= BIT(6);
>+		rtw_write8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HRPWM1, val8);
>+		adapter_to_pwrctl(padapter)->tog = (val8 + 0x80) & 0x80;
>+
>+		/* do polling cpwm */
>+		start_time = jiffies;
>+		do {
>+			mdelay(1);
>+
>+			rtw_hal_get_hwreg(padapter, HW_VAR_CPWM, &cpwm_now);
>+			if ((cpwm_orig ^ cpwm_now) & 0x80)
>+				break;
>+
>+			if (jiffies_to_msecs(jiffies - start_time) > 100)
>+				break;
>+
>+		} while (1);
>+
>+		rtl8723b_set_FwPwrModeInIPS_cmd(padapter, 0);
>+
>+		rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
>+
>+		hal_btcoex_InitHwConfig(padapter, false);
>+
>+		return _SUCCESS;
>+	}
>+
>+	/*  Disable Interrupt first. */
>+/*	rtw_hal_disable_interrupt(padapter); */
> 
> 	ret = _InitPowerOn_8723BS(padapter);
> 	if (ret == _FAIL)
>@@ -588,6 +739,8 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
> 
> 	/*  Record original value for template. This is arough data, we can only use the data */
> 	/*  for power adjust. The value can not be adjustde according to different power!!! */
>+/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
>+/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
> 
> 	rtl8723b_InitAntenna_Selection(padapter);
> 
>@@ -630,6 +783,7 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
> 	/* ack for xmit mgmt frames. */
> 	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));
> 
>+/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
> 
> 	{
> 		pwrctrlpriv->rf_pwrstate = rf_on;
>@@ -918,6 +1072,8 @@ static void _ReadPROMContent(struct adapter *padapter)
> 	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
> 	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;
> 
>+/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
>+
> 	_ReadEfuseInfo8723BS(padapter);
> }
> 

Re: [PATCH] [PATCH] staging: rtl8723bs: clean up coding style in sdio_halinit.c V2

[Dan Carpenter]

Please line wrap your emails at 74 characters and avoid top posting.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Greg KH]

On Wed, Mar 18, 2026 at 07:59:28AM +0100, Luka Gejak wrote:
> Hi Aadarsh,
> 
> Thanks for submitting this patch, and good luck with your GSoC application!

Wait, what?  Is GSoC doing staging patches for "entrance" into the
program?  If so, SOMEONE needs to tell me this, otherwise I will have to
treat all of these as an abuse of the community review process and just
flat out reject all staging patches until the GSoC application process
is over.

This isn't ok, you all know better than to do this.

Who is in charge of the kernel GSoC project this year?

greg k-h

[PATCH v3] staging: rtl8723bs: remove dead code

[Aadarsh Mandal]

remove unused and commented code 
no changes in functionality

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v3:
 - regenrated patch from the clean tree
 - removed unwanted addition
v2:
 - accidently added the functions in the {} blocks
v1:
 - some commented code wasnt deleted.
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++--------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..8fbb46b3019d 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -68,8 +68,8 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
 	rtw_write16(padapter, REG_APS_FSMCO, value16);
 
 	/*  Enable CMD53 R/W Operation */
-	rtw_write8(padapter, REG_CR, 0x00);
 
+	rtw_write8(padapter, REG_CR, 0x00);
 	/*  Enable MAC DMA/WMAC/SCHEDULE/SEC block */
 	value16 = rtw_read16(padapter, REG_CR);
 	value16 |= (
@@ -210,7 +210,7 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)
 	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
 
 	u16 value = 0;
-
+	
 	switch (pHalData->OutEpQueueSel) {
 	case TX_SELE_HQ:
 		value = QUEUE_HIGH;
@@ -338,7 +338,7 @@ static void _InitTransferPageSize(struct adapter *padapter)
 	/*  Tx page size is always 128. */
 
 	u8 value8;
-
+	
 	value8 = _PSRX(PBP_128) | _PSTX(PBP_128);
 	rtw_write8(padapter, REG_PBP, value8);
 }
@@ -482,7 +482,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
 
 	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
 
 	/*  Rx aggregation setting */
 	HalRxAggr8723BSdio(padapter);
@@ -636,7 +635,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 	}
 
 	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
 
 	ret = _InitPowerOn_8723BS(padapter);
 	if (ret == _FAIL)
@@ -656,8 +654,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 
 	rtl8723b_InitializeFirmwareVars(padapter);
 
-/*	SIC_Init(padapter); */
-
 	if (pwrctrlpriv->reg_rfoff)
 		pwrctrlpriv->rf_pwrstate = rf_off;
 
@@ -742,8 +738,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 
 	/*  Record original value for template. This is arough data, we can only use the data */
 	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
 
 	rtl8723b_InitAntenna_Selection(padapter);
 
@@ -786,7 +780,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 	/* ack for xmit mgmt frames. */
 	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));
 
-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
 
 	{
 		pwrctrlpriv->rf_pwrstate = rf_on;
@@ -1068,20 +1061,18 @@ static void _ReadEfuseInfo8723BS(struct adapter *padapter)
 static void _ReadPROMContent(struct adapter *padapter)
 {
 	struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
-	u8 eeValue;
+	u8 	eeValue;
 
 	eeValue = rtw_read8(padapter, REG_9346CR);
 	/*  To check system boot selection. */
 	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
 	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;
 
-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
 	_ReadEfuseInfo8723BS(padapter);
 }
 
 /*  */
-/*	Description: */
+/* 	Description: */
 /*	Read HW adapter information by E-Fuse or EEPROM according CR9346 reported. */
 /*  */
 /*	Assumption: */
@@ -1144,7 +1135,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
 	case HW_VAR_SET_REQ_FW_PS:
 		{
 			u8 req_fw_ps = 0;
-
+			
 			req_fw_ps = rtw_read8(padapter, 0x8f);
 			req_fw_ps |= 0x10;
 			rtw_write8(padapter, 0x8f, req_fw_ps);
-- 
2.43.0

Re: [PATCH v3] staging: rtl8723bs: remove dead code

[Dan Carpenter]

On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote:
> remove unused and commented code 
> no changes in functionality

Line wrap at 74 characters.  Add a period to the end of the sentence.

> 
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---
> v3:
>  - regenrated patch from the clean tree
>  - removed unwanted addition
> v2:
>  - accidently added the functions in the {} blocks
> v1:
>  - some commented code wasnt deleted.
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> 
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++--------------
>  1 file changed, 6 insertions(+), 15 deletions(-)

It should only be deletions and 0 insertions.  Review the patch
and run checkpatch.pl on it before sending.

regards,
dan carpenter

Re: [PATCH v3] staging: rtl8723bs: remove dead code

[Dan Carpenter]

On Wed, Mar 18, 2026 at 02:17:58PM +0300, Dan Carpenter wrote:
> On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote:
> > remove unused and commented code 
> > no changes in functionality
> 
> Line wrap at 74 characters.  Add a period to the end of the sentence.
> 

Also use capital letters at the start of a sentence.

Remove unused and commented code. No changes in functionality.

Probably saying "No changes in functionality." is not really necessary
because it's obvious.  Where it's more important is with things like
changing strcpy() to strcpy() which could look like a bugfix.  But it's
fine to add that.  We would have accepted it either way.

Wait a day between resends.

regards,
dan carpenter

Re: [PATCH v3] staging: rtl8723bs: remove dead code

[Greg KH]

On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote:
> remove unused and commented code 
> no changes in functionality
> 
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---
> v3:
>  - regenrated patch from the clean tree
>  - removed unwanted addition
> v2:
>  - accidently added the functions in the {} blocks
> v1:
>  - some commented code wasnt deleted.
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> 
>  drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++--------------
>  1 file changed, 6 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index 063a0737933e..8fbb46b3019d 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -68,8 +68,8 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
>  	rtw_write16(padapter, REG_APS_FSMCO, value16);
>  
>  	/*  Enable CMD53 R/W Operation */
> -	rtw_write8(padapter, REG_CR, 0x00);
>  
> +	rtw_write8(padapter, REG_CR, 0x00);

This does not follow what you documented in the changelog :(

What tool told you to make this change?

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Greg KH]

On Wed, Mar 18, 2026 at 08:36:21PM +0530, Aadarsh 7001 wrote:
> On Wed, Mar 18, 2026 at 5:09 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Wed, Mar 18, 2026 at 07:59:28AM +0100, Luka Gejak wrote:
> > > Hi Aadarsh,
> > >
> > > Thanks for submitting this patch, and good luck with your GSoC
> > application!
> >
> > Wait, what?  Is GSoC doing staging patches for "entrance" into the
> > program?  If so, SOMEONE needs to tell me this, otherwise I will have to
> > treat all of these as an abuse of the community review process and just
> > flat out reject all staging patches until the GSoC application process
> > is over.
> >
> This isn't ok, you all know better than to do this.
> >
> > Who is in charge of the kernel GSoC project this year?
> >
> > greg k-h
> 
> Sorry for the confusion, that wasn't my intention to abuse the community
> > review process. This is my effort to learn and contribute to the kernel.
> > I'll be extra care ful on this. Thank you for clarification.

If you are applying for GSoC, this is not your fault.  I want to know
who the mentors that asked you to send this patch, where is that
documented?

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Ethan Tidmore]

On Wed Mar 18, 2026 at 10:11 AM CDT, Greg KH wrote:
> On Wed, Mar 18, 2026 at 08:36:21PM +0530, Aadarsh 7001 wrote:
>> On Wed, Mar 18, 2026 at 5:09 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>> 
>> > On Wed, Mar 18, 2026 at 07:59:28AM +0100, Luka Gejak wrote:
>> > > Hi Aadarsh,
>> > >
>> > > Thanks for submitting this patch, and good luck with your GSoC
>> > application!
>> >
>> > Wait, what?  Is GSoC doing staging patches for "entrance" into the
>> > program?  If so, SOMEONE needs to tell me this, otherwise I will have to
>> > treat all of these as an abuse of the community review process and just
>> > flat out reject all staging patches until the GSoC application process
>> > is over.
>> >
>> This isn't ok, you all know better than to do this.
>> >
>> > Who is in charge of the kernel GSoC project this year?
>> >
>> > greg k-h
>> 
>> Sorry for the confusion, that wasn't my intention to abuse the community
>> > review process. This is my effort to learn and contribute to the kernel.
>> > I'll be extra care ful on this. Thank you for clarification.
>
> If you are applying for GSoC, this is not your fault.  I want to know
> who the mentors that asked you to send this patch, where is that
> documented?
>
> thanks,
>
> greg k-h

It's on the actual page for it [1]:

Create a small patch that fixes a trivial issue in drivers/staging. 
See points 1) and 2) below to learn the process. Only after this patch 
is accepted by the community you can go and work on the next step.

Thanks,

ET

[1] https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Greg KH]

On Wed, Mar 18, 2026 at 12:54:38PM -0500, Ethan Tidmore wrote:
> On Wed Mar 18, 2026 at 10:11 AM CDT, Greg KH wrote:
> > On Wed, Mar 18, 2026 at 08:36:21PM +0530, Aadarsh 7001 wrote:
> >> On Wed, Mar 18, 2026 at 5:09 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >> 
> >> > On Wed, Mar 18, 2026 at 07:59:28AM +0100, Luka Gejak wrote:
> >> > > Hi Aadarsh,
> >> > >
> >> > > Thanks for submitting this patch, and good luck with your GSoC
> >> > application!
> >> >
> >> > Wait, what?  Is GSoC doing staging patches for "entrance" into the
> >> > program?  If so, SOMEONE needs to tell me this, otherwise I will have to
> >> > treat all of these as an abuse of the community review process and just
> >> > flat out reject all staging patches until the GSoC application process
> >> > is over.
> >> >
> >> This isn't ok, you all know better than to do this.
> >> >
> >> > Who is in charge of the kernel GSoC project this year?
> >> >
> >> > greg k-h
> >> 
> >> Sorry for the confusion, that wasn't my intention to abuse the community
> >> > review process. This is my effort to learn and contribute to the kernel.
> >> > I'll be extra care ful on this. Thank you for clarification.
> >
> > If you are applying for GSoC, this is not your fault.  I want to know
> > who the mentors that asked you to send this patch, where is that
> > documented?
> >
> > thanks,
> >
> > greg k-h
> 
> It's on the actual page for it [1]:
> 
> Create a small patch that fixes a trivial issue in drivers/staging. 
> See points 1) and 2) below to learn the process. Only after this patch 
> is accepted by the community you can go and work on the next step.
> 
> Thanks,
> 
> ET
> 
> [1] https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

And it points to a video of mine from 16 years ago

{sigh}

It would have been nice for someone from that project to give me the
heads-up that we would be getting a huge increase in our review load :(

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Luka Gejak]

On March 18, 2026 7:17:44 PM GMT+01:00, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Wed, Mar 18, 2026 at 12:54:38PM -0500, Ethan Tidmore wrote:
>> On Wed Mar 18, 2026 at 10:11 AM CDT, Greg KH wrote:
>> > On Wed, Mar 18, 2026 at 08:36:21PM +0530, Aadarsh 7001 wrote:
>> >> On Wed, Mar 18, 2026 at 5:09 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>> >> 
>> >> > On Wed, Mar 18, 2026 at 07:59:28AM +0100, Luka Gejak wrote:
>> >> > > Hi Aadarsh,
>> >> > >
>> >> > > Thanks for submitting this patch, and good luck with your GSoC
>> >> > application!
>> >> >
>> >> > Wait, what?  Is GSoC doing staging patches for "entrance" into the
>> >> > program?  If so, SOMEONE needs to tell me this, otherwise I will have to
>> >> > treat all of these as an abuse of the community review process and just
>> >> > flat out reject all staging patches until the GSoC application process
>> >> > is over.
>> >> >
>> >> This isn't ok, you all know better than to do this.
>> >> >
>> >> > Who is in charge of the kernel GSoC project this year?
>> >> >
>> >> > greg k-h
>> >> 
>> >> Sorry for the confusion, that wasn't my intention to abuse the community
>> >> > review process. This is my effort to learn and contribute to the kernel.
>> >> > I'll be extra care ful on this. Thank you for clarification.
>> >
>> > If you are applying for GSoC, this is not your fault.  I want to know
>> > who the mentors that asked you to send this patch, where is that
>> > documented?
>> >
>> > thanks,
>> >
>> > greg k-h
>> 
>> It's on the actual page for it [1]:
>> 
>> Create a small patch that fixes a trivial issue in drivers/staging. 
>> See points 1) and 2) below to learn the process. Only after this patch 
>> is accepted by the community you can go and work on the next step.
>> 
>> Thanks,
>> 
>> ET
>> 
>> [1] https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
>
>And it points to a video of mine from 16 years ago
>
>{sigh}
>
>It would have been nice for someone from that project to give me the
>heads-up that we would be getting a huge increase in our review load :(

Hey Greg, 
Due to an unfortunate situation of current GSoC and an increase in 
review load, I am able to assist with patch reviews if you want.
Best regards,
Luka Gejak

Re: [PATCH] staging: rtl8723bs: fixed the trailing whitespaces/commented code

[Greg KH]

On Wed, Mar 18, 2026 at 10:06:57PM +0100, Luka Gejak wrote:
> On March 18, 2026 7:17:44 PM GMT+01:00, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Wed, Mar 18, 2026 at 12:54:38PM -0500, Ethan Tidmore wrote:
> >> On Wed Mar 18, 2026 at 10:11 AM CDT, Greg KH wrote:
> >> > On Wed, Mar 18, 2026 at 08:36:21PM +0530, Aadarsh 7001 wrote:
> >> >> On Wed, Mar 18, 2026 at 5:09 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >> >> 
> >> >> > On Wed, Mar 18, 2026 at 07:59:28AM +0100, Luka Gejak wrote:
> >> >> > > Hi Aadarsh,
> >> >> > >
> >> >> > > Thanks for submitting this patch, and good luck with your GSoC
> >> >> > application!
> >> >> >
> >> >> > Wait, what?  Is GSoC doing staging patches for "entrance" into the
> >> >> > program?  If so, SOMEONE needs to tell me this, otherwise I will have to
> >> >> > treat all of these as an abuse of the community review process and just
> >> >> > flat out reject all staging patches until the GSoC application process
> >> >> > is over.
> >> >> >
> >> >> This isn't ok, you all know better than to do this.
> >> >> >
> >> >> > Who is in charge of the kernel GSoC project this year?
> >> >> >
> >> >> > greg k-h
> >> >> 
> >> >> Sorry for the confusion, that wasn't my intention to abuse the community
> >> >> > review process. This is my effort to learn and contribute to the kernel.
> >> >> > I'll be extra care ful on this. Thank you for clarification.
> >> >
> >> > If you are applying for GSoC, this is not your fault.  I want to know
> >> > who the mentors that asked you to send this patch, where is that
> >> > documented?
> >> >
> >> > thanks,
> >> >
> >> > greg k-h
> >> 
> >> It's on the actual page for it [1]:
> >> 
> >> Create a small patch that fixes a trivial issue in drivers/staging. 
> >> See points 1) and 2) below to learn the process. Only after this patch 
> >> is accepted by the community you can go and work on the next step.
> >> 
> >> Thanks,
> >> 
> >> ET
> >> 
> >> [1] https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> >
> >And it points to a video of mine from 16 years ago
> >
> >{sigh}
> >
> >It would have been nice for someone from that project to give me the
> >heads-up that we would be getting a huge increase in our review load :(
> 
> Hey Greg, 
> Due to an unfortunate situation of current GSoC and an increase in 
> review load, I am able to assist with patch reviews if you want.

I never turn down patch reviews, as long as they are correct :)

[PATCH v4] staging: rtl8723bs: removed dead code

[Aadarsh Mandal]

- removed the dead code.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v4:
 - removed the space insertion.
 - deleted the commented codes.
v3:
 - added the extra space that count as insertion.
 - removed unwanted addition.
v2:
 - accidently deleted the braces for the standalone code blocks {}.
 - deleted the reindented comment code, extra space.
v1:
 - reindented comment code,extra space remained.

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0

[PATCH v4] staging: rtl8723bs: removed dead code

[Aadarsh Mandal]

- removed the dead code.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v4:
 - removed the space insertion.
 - deleted the commented codes.
v3:
 - added the extra space that count as insertion.
 - removed unwanted addition.
v2:
 - accidently deleted the braces for the standalone code blocks {}.
 - deleted the reindented comment code, extra space.
v1:
 - reindented comment code,extra space remained.

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0

[PATCH v4] staging: rtl8723bs: removed dead code

[Aadarsh Mandal]

- removed the dead code.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v4:
 - removed the space insertion.
 - deleted the commented codes.
v3:
 - added the extra space that count as insertion.
 - removed unwanted addition.
v2:
 - accidently deleted the braces for the standalone code blocks {}.
 - deleted the reindented comment code, extra space.
v1:
 - reindented comment code,extra space remained.

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0

Re: [PATCH v4] staging: rtl8723bs: removed dead code

[Luka Gejak]

Please send only one version per 24 hours.
Otherwise, looking good to me.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Re: [PATCH v4] staging: rtl8723bs: removed dead code

[Ethan Tidmore]

On Thu Mar 19, 2026 at 9:18 AM CDT, Aadarsh Mandal wrote:
> - removed the dead code.
>
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---

This patch is corrupted.

Thanks,

ET

Re: [PATCH v4] staging: rtl8723bs: removed dead code

[Ethan Tidmore]

On Thu Mar 19, 2026 at 1:25 PM CDT, Ethan Tidmore wrote:
> On Thu Mar 19, 2026 at 9:18 AM CDT, Aadarsh Mandal wrote:
>> - removed the dead code.
>>
>> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>> ---
>
> This patch is corrupted.
>
> Thanks,
>
> ET

Also, your commit message should be a proper sentence, something like,
"Removed code that is not used anywhere in the driver."

Thanks,

ET

[PATCH v5] staging: rtl8723bs: cleaned up patch formatting

[Aadarsh Mandal]

Fix commit message formatting for the previous patch.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v4:
 - Remove extra space insertion.
 - Delete remaining commented-out code.
v3:
 - Add the extra space that count as insertion.
 - Remove unwanted addition.
v2:
 - Restore braces for standalone code blocks {}.
 - Delete reindented commented-out code and extra space.
v1:
 - Reindented commented-out code;extra space remained.

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0

Re: [PATCH v5] staging: rtl8723bs: cleaned up patch formatting

[Luka Gejak]

On March 20, 2026 3:46:52 PM GMT+01:00, Aadarsh Mandal <aadarshmandal9354@gmail.com> wrote:
>Fix commit message formatting for the previous patch.
>
>Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>---
>v4:
> - Remove extra space insertion.
> - Delete remaining commented-out code.
>v3:
> - Add the extra space that count as insertion.
> - Remove unwanted addition.
>v2:
> - Restore braces for standalone code blocks {}.
> - Delete reindented commented-out code and extra space.
>v1:
> - Reindented commented-out code;extra space remained.
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
>diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>index 063a0737933e..96a0c8e304da 100644
>--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
> {
>	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
>
>-	/*  Tx aggregation setting */
>-/*	sdio_AggSettingTxUpdate(padapter); */
>-
>	/*  Rx aggregation setting */
>	HalRxAggr8723BSdio(padapter);
>
>@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>		return _SUCCESS;
>	}
>
>-	/*  Disable Interrupt first. */
>-/*	rtw_hal_disable_interrupt(padapter); */
>-
>	ret = _InitPowerOn_8723BS(padapter);
>	if (ret == _FAIL)
>		return _FAIL;
>@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>
>	rtl8723b_InitializeFirmwareVars(padapter);
>
>-/*	SIC_Init(padapter); */
>-
>	if (pwrctrlpriv->reg_rfoff)
>		pwrctrlpriv->rf_pwrstate = rf_off;
>
>@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
>		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);
>
>-	/*  Record original value for template. This is arough data, we can only use the data */
>-	/*  for power adjust. The value can not be adjustde according to different power!!! */
>-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
>-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
>-
>	rtl8723b_InitAntenna_Selection(padapter);
>
>	/*  */
>@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>	/* ack for xmit mgmt frames. */
>	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));
>
>-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
>-
>	{
>		pwrctrlpriv->rf_pwrstate = rf_on;
>
>@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
>	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
>	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;
>
>-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
>-
>	_ReadEfuseInfo8723BS(padapter);
> }
>
>--
>2.43.0

Your commit message can't be: "Fix commit message formatting 
for the previous patch." Instead, it should be something like 
"Removed code that is not used anywhere in the driver."
Sincerely,
Luka Gejak

[PATCH v6] staging: rtl8723bs: remove commented-out code

[Aadarsh Mandal]

- Remove code that is not used anywhere in driver.
---
v4:
 - Remove extra space insertion.
 - Delete remaining commented-out code.
v3:
 - Add the extra space that count as insertion.
 - Remove unwanted addition.
v2:
 - Restore braces for standalone code blocks {}.
 - Delete reindented commented-out code and extra space.
v1:
 - Reindented commented-out code;extra space remained.
---

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0

Re: [PATCH v6] staging: rtl8723bs: remove commented-out code

[Ethan Tidmore]

On Sun Mar 22, 2026 at 6:48 AM CDT, Aadarsh Mandal wrote:
> - Remove code that is not used anywhere in driver.

Probably remove unused code would be better. Also you don't need to put
a - at the start.

> ---
Your SOB needs to be above this first ---.

> v4:
>  - Remove extra space insertion.
>  - Delete remaining commented-out code.
> v3:
>  - Add the extra space that count as insertion.
>  - Remove unwanted addition.
> v2:
>  - Restore braces for standalone code blocks {}.
>  - Delete reindented commented-out code and extra space.
> v1:
>  - Reindented commented-out code;extra space remained.
> ---
>
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---

This patch is corrupted.

Thanks,

ET

Re: [PATCH v6] staging: rtl8723bs: remove commented-out code

[Dan Carpenter]

On Sun, Mar 22, 2026 at 05:01:30PM -0500, Ethan Tidmore wrote:
> On Sun Mar 22, 2026 at 6:48 AM CDT, Aadarsh Mandal wrote:
> > - Remove code that is not used anywhere in driver.
> 
> Probably remove unused code would be better.

This doens't matter.  The other stuff is true, particularly the missing
S-o-by line.

regards,
dan carpenter

[PATCH v7] staging: rtl8723bs: remove commented-out code

[Aadarsh Mandal]

Remove code that is not used anywhere in driver.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v6:
 - No change.
v5:
 - No change.
v4:
 - Remove extra space insertion.
 - Delete remaining commented-out code.
v3:
 - Add the extra space that count as insertion.
 - Remove unwanted addition.
v2:
 - Restore braces for standalone code blocks {}.
 - Delete reindented commented-out code and extra space.
v1:
 - Reindented commented-out code;extra space remained.

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0

Re: [PATCH v7] staging: rtl8723bs: remove commented-out code

[Luka Gejak]

On March 24, 2026 5:07:18 AM GMT+01:00, Aadarsh Mandal <aadarshmandal9354@gmail.com> wrote:
>Remove code that is not used anywhere in driver.
>
>Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>---
>v6:
> - No change.
>v5:
> - No change.
>v4:
> - Remove extra space insertion.
> - Delete remaining commented-out code.
>v3:
> - Add the extra space that count as insertion.
> - Remove unwanted addition.
>v2:
> - Restore braces for standalone code blocks {}.
> - Delete reindented commented-out code and extra space.
>v1:
> - Reindented commented-out code;extra space remained.
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
>diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>index 063a0737933e..96a0c8e304da 100644
>--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
> {
>	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
>
>-	/*  Tx aggregation setting */
>-/*	sdio_AggSettingTxUpdate(padapter); */
>-
>	/*  Rx aggregation setting */
>	HalRxAggr8723BSdio(padapter);
>
>@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>		return _SUCCESS;
>	}
>
>-	/*  Disable Interrupt first. */
>-/*	rtw_hal_disable_interrupt(padapter); */
>-
>	ret = _InitPowerOn_8723BS(padapter);
>	if (ret == _FAIL)
>		return _FAIL;
>@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>
>	rtl8723b_InitializeFirmwareVars(padapter);
>
>-/*	SIC_Init(padapter); */
>-
>	if (pwrctrlpriv->reg_rfoff)
>		pwrctrlpriv->rf_pwrstate = rf_off;
>
>@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
>		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);
>
>-	/*  Record original value for template. This is arough data, we can only use the data */
>-	/*  for power adjust. The value can not be adjustde according to different power!!! */
>-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
>-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
>-
>	rtl8723b_InitAntenna_Selection(padapter);
>
>	/*  */
>@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>	/* ack for xmit mgmt frames. */
>	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));
>
>-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
>-
>	{
>		pwrctrlpriv->rf_pwrstate = rf_on;
>
>@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
>	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
>	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;
>
>-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
>-
>	_ReadEfuseInfo8723BS(padapter);
> }
>
>--
>2.43.0

Hi Aadarsh,
It seems patch is corrupted, so please regenerate it and don't edit the file manually.
Best regards,
Luka Gejak

Re: [PATCH v7] staging: rtl8723bs: remove commented-out code

[Dan Carpenter]

On Tue, Mar 24, 2026 at 09:37:18AM +0530, Aadarsh Mandal wrote:
> Remove code that is not used anywhere in driver.
> 
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---
> v6:
>  - No change.
> v5:
>  - No change.

Why are you resending with no change?

Also you're not working against staging-next.

regards,
dan carpenter

Re: [PATCH v7] staging: rtl8723bs: remove commented-out code

[Luka Gejak]

On March 24, 2026 7:54:43 AM GMT+01:00, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>On Tue, Mar 24, 2026 at 09:37:18AM +0530, Aadarsh Mandal wrote:
>> Remove code that is not used anywhere in driver.
>> 
>> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>> ---
>> v6:
>>  - No change.
>> v5:
>>  - No change.
>
>Why are you resending with no change?
>
>Also you're not working against staging-next.
>
>regards,
>dan carpenter
>

He probably means no code changes as the last 
two versions were related to commit messages 
and Signed-off-by field.
Sincerely,
Luka Gejak

Re: [PATCH v7] staging: rtl8723bs: remove commented-out code

[Dan Carpenter]

On Tue, Mar 24, 2026 at 09:12:20AM +0100, Luka Gejak wrote:
> On March 24, 2026 7:54:43 AM GMT+01:00, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> >On Tue, Mar 24, 2026 at 09:37:18AM +0530, Aadarsh Mandal wrote:
> >> Remove code that is not used anywhere in driver.
> >> 
> >> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> >> ---
> >> v6:
> >>  - No change.
> >> v5:
> >>  - No change.
> >
> >Why are you resending with no change?
> >
> >Also you're not working against staging-next.
> >
> >regards,
> >dan carpenter
> >
> 
> He probably means no code changes as the last 
> two versions were related to commit messages 
> and Signed-off-by field.

Thanks, Luka.  Changes to the commit message count as a change.

regards,
dan carpenter

Re: [PATCH v7] staging: rtl8723bs: remove commented-out code

[Luka Gejak]

On March 25, 2026 4:41:20 AM GMT+01:00, Aadarsh 7001 <aadarshmandal9354@gmail.com> wrote:
>On Tue, Mar 24, 2026 at 1:42 PM Luka Gejak <luka.gejak@linux.dev> wrote:
>
>> On March 24, 2026 7:54:43 AM GMT+01:00, Dan Carpenter <
>> dan.carpenter@linaro.org> wrote:
>> >On Tue, Mar 24, 2026 at 09:37:18AM +0530, Aadarsh Mandal wrote:
>> >> Remove code that is not used anywhere in driver.
>> >>
>> >> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>> >> ---
>> >> v6:
>> >>  - No change.
>> >> v5:
>> >>  - No change.
>> >
>> >Why are you resending with no change?
>> >
>> >Also you're not working against staging-next.
>> >
>> >regards,
>> >dan carpenter
>> >
>>
>> He probably means no code changes as the last
>> two versions were related to commit messages
>> and Signed-off-by field.
>
>Is it wrong to mention like that? Thanks
>
>Sincerely,
>
>Luka Gejak
>>

You should mention any changes made to the patch, even if they 
are only in commit message.
Best regards,
Luka Gejak