Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes

["Troy Mitchell" <troy.mitchell@linux.spacemit.com>]

On Wed Mar 25, 2026 at 5:49 PM CST, Yixun Lan wrote:
> Populate all I2C devicetree nodes for SpacemiT K3 SoC.
>
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
>  arch/riscv/boot/dts/spacemit/k3.dtsi | 98 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 98 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> index a3a8ceddabec..cab72591b7f1 100644
> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
> @@ -438,6 +438,76 @@ soc: soc {
>  		dma-noncoherent;
>  		ranges;
>  
> +		i2c0: i2c@d4010800 {
> +			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
> +			reg = <0x0 0xd4010800 0x0 0x38>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			interrupts = <36 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&syscon_apbc CLK_APBC_TWSI0>,
> +				 <&syscon_apbc CLK_APBC_TWSI0_BUS>;
> +			clock-names = "func", "bus";
> +			clock-frequency = <400000>;
> +			resets = <&syscon_apbc RESET_APBC_TWSI0>;
> +			status = "disabled";
> +		};
> +
> +		i2c1: i2c@d4011000 {
> +			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
> +			reg = <0x0 0xd4011000 0x0 0x38>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			interrupts = <37 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&syscon_apbc CLK_APBC_TWSI1>,
> +				 <&syscon_apbc CLK_APBC_TWSI1_BUS>;
> +			clock-names = "func", "bus";
> +			clock-frequency = <400000>;
> +			resets = <&syscon_apbc RESET_APBC_TWSI1>;
> +			status = "disabled";
> +		};
> +
> +		i2c2: i2c@d4012000 {
> +			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
> +			reg = <0x0 0xd4012000 0x0 0x38>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			interrupts = <38 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&syscon_apbc CLK_APBC_TWSI2>,
> +				 <&syscon_apbc CLK_APBC_TWSI2_BUS>;
> +			clock-names = "func", "bus";
> +			clock-frequency = <400000>;
> +			resets = <&syscon_apbc RESET_APBC_TWSI2>;
> +			status = "disabled";
> +		};
I think we should add a comment here to explain why there isn't i2c3.
Otherwise, LGTM.

Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>