From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDFDD23B612 for ; Wed, 25 Mar 2026 13:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774445329; cv=none; b=UASpgSrp1/EL12Uw8elVHnZfhV1v1WIU1e+XI/7aLB919AknYgKqKsvEshU7DLah4ViRjjnw5bbWkc/4z9kvdV9+4Qou9TtxyGKqjPB3pgKHilOT/LRm1nJJv8Fz4JWpAqZVTi42u69CLeL/Humqm/RXyHRXO5H+9UfVCjPlN5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774445329; c=relaxed/simple; bh=wh4KIPCsPABUTDz9zXsG/QiRr/KQLOGyNMFCFa7ua3s=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=E/Ji2INRdGTpUHf/hC8LuSf3Mc82PIzUEkwwOAPyULdN0UaIVH6fObOAd/X9DCHdvhc1+58mFfawHo4etWH0BUvWGH+y2Qwj/gl3Llsz1rjJydX4diYO2g/anw+6J9LK0+2vULYwbMbLVjxI6+3xKM49ZImDpk459pVPJKabm1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AsmGY5TW; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AsmGY5TW" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-48534941525so62566205e9.2 for ; Wed, 25 Mar 2026 06:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774445326; x=1775050126; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=ugI4fJPLVgpKdhxQIMsmcwuVQPmlpxkDqu42ttwGwnk=; b=AsmGY5TWjtyh0akE8cbLcZ8ue4j5TKcubKQZ8lnJ+VSPcXdM4mGTy4KfZrPUdXk9xy Nr8Lt5//zSJQGWqiUm0z0P8Zi/5pLvYYDdzqdOPULOT7a9izk4jh3vIQPmY9KCB+erZA CWnQvNtuCYz9pfZtcSchV3DWqN3JuZ9XeOjDmEVA5aJMqrM7gzCHBtUSgK+yOZWBB5mv fXyUe3w1n7/KD0EetfbBkeQvF+WfjkKCcTMB8W4IcziGHyBgkA5xlh5KDtgrN85SHyne Bc2l2hpLFAq94EJIcQwKzmhYolv3miFiqMxACaRgzYbVJzXmV9+7tCchfVpSPf28TfrT jegQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774445326; x=1775050126; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ugI4fJPLVgpKdhxQIMsmcwuVQPmlpxkDqu42ttwGwnk=; b=KptpNk/0/IOyJZ68exG9Q8sOqFn0JhIEqF85z5QKWNWw2GQqh9zNBSv63g+Awfi7vk Q8V2QscxlYAW5rbYtRAGPU4FS+SsL3KGx+WLodzmezudp5HMmiim1dkHFEJnLh0cN3h3 Od3gV2M4ImffYoIgu55ZxWYojkj8Oa8HGwyK9N4ttD52jl2O7yyB5MLwCZcHFhYFMpHn x0oZ4z+CKHKnVps6IUROKfVWlNG/WrPsF8AYzJkBuypeW5Y/1QCh452+UMxhf3c7Yk37 SGL6cgT+r+skpRqh66tTx4ubzx6s1jFJPmKeepUZRimjDYy1gg5LRgrO4DPGlH9+VyZI lt6Q== X-Forwarded-Encrypted: i=1; AJvYcCWYTRppSb3ZrD8fdrsfjTuqboIx8qroMvgO0Z28oAkHKL+ocni7cDlzflycdjDV03X1tJtBUF6tfEcS02o=@vger.kernel.org X-Gm-Message-State: AOJu0YzvnL3raF+ToyRgTS1XCVdLYzYsnXls1eVhCcyIlKhf35XEjL31 qG7a0mSvzJkRaCkSUJQI9uQi5nl75xbRDdZhr9C8T8IFEFrMs+I/AGNhfiqGscuqGjsf8h3ptq4 9V0O0BiIaQZEKaw== X-Received: from wmpr8.prod.google.com ([2002:a05:600c:3208:b0:486:f89b:7f11]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a088:b0:477:b734:8c53 with SMTP id 5b1f17b1804b1-48715fef727mr52438045e9.12.1774445325853; Wed, 25 Mar 2026 06:28:45 -0700 (PDT) Date: Wed, 25 Mar 2026 13:28:44 +0000 In-Reply-To: <20260324152702.GLacKtRrAGFea3FGqH@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-1-28bf1bd54f41@google.com> <20260324152702.GLacKtRrAGFea3FGqH@fat_crate.local> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH v2 01/22] x86/mm: split out preallocate_sub_pgd() From: Brendan Jackman To: Borislav Petkov , Brendan Jackman Cc: Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Vlastimil Babka , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes , , , , , Sumit Garg , , , Will Deacon , , "Kalyazin, Nikita" , , "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue Mar 24, 2026 at 3:27 PM UTC, Borislav Petkov wrote: > On Fri, Mar 20, 2026 at 06:23:25PM +0000, Brendan Jackman wrote: >> This code will be needed elsewhere in a following patch. Split out the >> trivial code move for easy review. >>=20 >> This changes the logging slightly: instead of panic() directly reporting >> the level of the failure, there is now a generic panic message which >> will be preceded by a separate warn that reports the level of the >> failure. This is a simple way to have this helper suit the needs of its >> new user as well as the existing one. > > "Describe your changes in imperative mood, e.g. =E2=80=9Cmake xyzzy do fr= otz=E2=80=9D instead > of =E2=80=9C[This patch] makes xyzzy do frotz=E2=80=9D or =E2=80=9C[I] ch= anged xyzzy to do frotz=E2=80=9D, as > if you are giving orders to the codebase to change its behaviour." Yeah there are a bunch of comments in this series where I've written "we do XYZ" instead of "do XYZ", I've set up an AI prompt [0] to try and catch it for me before I send you guys crazy with yet another series that makes the same mistake over and over. [0] https://lore.kernel.org/all/DHA6G1E2H5P4.2D7JKTRKIBE3U@google.com/ TBH for this particular case it seems borderline? The referent of the "this" is the previous paragraph, it's trying to show that the logging change is a side effect of the code movement rather than a part of the patch's intent. But there are more explicit ways to carry that message so I'll rewrite it. >> Other than logging, no functional change intended. >>=20 >> Signed-off-by: Brendan Jackman >> --- >> arch/x86/include/asm/pgalloc.h | 33 +++++++++++++++++++++++++++++++ >> arch/x86/mm/init_64.c | 44 +++++++----------------------------= ------- >> 2 files changed, 40 insertions(+), 37 deletions(-) >>=20 >> diff --git a/arch/x86/include/asm/pgalloc.h b/arch/x86/include/asm/pgall= oc.h >> index c88691b15f3c6..3541b86c9c6b0 100644 >> --- a/arch/x86/include/asm/pgalloc.h >> +++ b/arch/x86/include/asm/pgalloc.h > > Why in a header? > > That function is kinda bigger than the rest of the oneliners there... Hm, I suspect I wanted to avoid creating new ifdefs in the C file? Seems harmless though. Looks fine in arch/x86/mm/pgtable.c.