From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5C03612FB for ; Thu, 26 Mar 2026 18:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548595; cv=none; b=KOyCet3IOFTHWfErWnzHSxSabCAlclB1D47AsKlPVh1hevo6Ryl/ogpGbrwrSSezfb87o9ZLgo+f0jqBgUG2DuXEXYA7IhIdnYBQNjupUyp7qFYj6WVxKn7oNLNwE+eAWu2ui8i6X8J1+vtpflYqNa+IVh4Fqzce6+rQpfYrk5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548595; c=relaxed/simple; bh=KyxxPTeljQL4s/4n5F5qCkKxPIqZn+/VANAG7vn3xpE=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=otbDO0zF8TkmxUVRP+EoMaD93/WBcwgazgLEaR/LLG9n0zAxUJCWCi4hk3EEt7YMCxAztPz169w4C/FL0R79LE2XiUAigJTJftBSZ7OBxA+kre9Zyj/oAYF+iTFoZH4J3Nc4vrLfwLvbC5UmiFXhI67irEkcGH4lWmEOWLgNIag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bYjdSk2C; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bYjdSk2C" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-79801df3e42so17363957b3.0 for ; Thu, 26 Mar 2026 11:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774548592; x=1775153392; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O37BhboRnNuwha5lWKiZcjwoyDlHeTZOtbecgNN6F5k=; b=bYjdSk2Cmb+5+oW10OyntHkBIlduSW1gBe6qHDhRFMvfjROyZmtifPkes16FBBPz28 hlYe8FI7KNhEyGnnDGWAcqX56QzMJN/OmJxEpl7qeFBE/phc86odMxCz8T+LBIqoM9iR LjyTlVmzprurT4NCJgHkfROSLJAZc798kzwpMl2rX4laHB+RTj027abv45YSIj/OSigz lDioU5r2v5ImPKPStb7tQmWpQCQpANVf0hbD5n8mmMngPWFbppe9IoUG4MZBu4HHhO3c onIOWFI2cpWSTZruDsaetBt20bpVeTxEaICfml+rSgPMmOwvVK+7WkR+FLaginmKY7db +8NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774548592; x=1775153392; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=O37BhboRnNuwha5lWKiZcjwoyDlHeTZOtbecgNN6F5k=; b=R3UMihrLB2f5Qv+TP3PUO5XYrzKcbqAN0dlM6Fh2j6FcmGhRXfkrcLk98JPNGkprfH QPCk/7fi3NNXHL9S61/hKep84LQS0EFMFjVqGVtcy3mcziMtgr16sBYIPI49uXx5huE/ X9zWPCUwgtOLIourXL1FwRE9kX8aTpVFogUEHwCJ83P+7SbtnlJgLCUYnZNjRA0p1BDC u8lp+2KDOyao2JZ3mtozkQsM+QqipJicauNtNMOVqqYmZEFVLQq2uqMI0np+XHOey/DE 8325GT2T2brnQuocH1ylDCT8b06K7WuH8WX0fow/hc3flltWR2B6RZm/28KGbPJm0Xwq bK6g== X-Forwarded-Encrypted: i=1; AJvYcCX+c/tm47A2oSem9lQdFGNgjF2fM9MLt2hnZGC8/7mcyopbPL09t5KE2BqQ6j0vN0CY7Ens8zf/ldNjcnE=@vger.kernel.org X-Gm-Message-State: AOJu0YwKfzFBhm1SyZAJZgWFYPnQpl4zlBOP6R+RDPdDuADZ9kX+5fSb MFp3obsrK/1/4awdEjqgafQRAuJ9fQ+Z/DABvKZJB5nomsb3DL7lKha1 X-Gm-Gg: ATEYQzxfOnDzulOnSE5QuqGwDGtFam50LvId8OwjYxwiaQYoxVDNPXIK5nPRvXIRzuE Ko02MVMO/TkV6suovfqWqq2FKxWtB7y5CuWgisGxHOAF1q4ESzIcrKVen5rvY0s0nEZvPhzrmAl wiceTE6286opzfVJqcWUGeOqIHA+bgzSrjEOKtARGTA3/x6yvtx6GdajlMhMEbtG73B2pmKc6Q5 Iu8MUdy8LPdtJnZtQHuzBBICVc7O6aPib2FnfZPXenXRGMaWHdE/iHShCJZNWuSzxnScq9xlcCT TA/lbIQc6cY9t5XanWQn9Dzho17Mzpv1E/AkLcIZiWl80giY+HGJp46OVtRqbSgVnpMio1lAv4l YFVceE6W1yWqMh0e/FtqCMT0gjv0xKX75isu467nVxptwdiQCZZc5sJp7FITCc9L6EnC0cmh7hD Z5IQ5IBOfPjPVEF4uH82VO7nrQpyJF21dFjV/MqivpaUpHtAqaqy5a6nlGxzNMjpiPNFTfgA+9p BgntWIh9co+ZmwKBJaLQ5tp3G/bES37 X-Received: by 2002:a05:690c:3387:b0:798:5213:d90e with SMTP id 00721157ae682-79bd025214emr21822857b3.25.1774548592034; Thu, 26 Mar 2026 11:09:52 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79b17e4a0absm16324437b3.22.2026.03.26.11.09.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 11:09:51 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 26 Mar 2026 13:09:49 -0500 Message-Id: To: "MrXploisLite" , Cc: , Subject: Re: [PATCH] staging: rtl8723bs: fix checkpatch style issues From: "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260325234511.24762-1-arokigaming@gmail.com> In-Reply-To: <20260325234511.24762-1-arokigaming@gmail.com> On Wed Mar 25, 2026 at 6:45 PM CDT, MrXploisLite wrote: > Fix minor style issues in hal_com.c reported by checkpatch: > - Remove multiple blank lines > - Remove blank line after open brace > - Fix comparison style (constant on right side) > > No functional changes, only coding style fixes. > > Signed-off-by: MrXploisLite > --- You need to use your real name when submitting patches. Also, don't use the name of the tool in your subject, it should be something like "Remove unneeded blank lines". ... > - if (0xFF =3D=3D hw_channel_plan) > + if (hw_channel_plan =3D=3D 0xFF) > AutoLoadFail =3D true; Please keep one logical change per patch. The removal of blank lines and correcting comparison orientation are two different changes. Use "$ ./scripts/checkpatch.pl --strict " too before sending patches off, it helps catch a lot of easy mistakes. Thanks, ET