Re: [PATCH] staging: rtl8723bs: fix checkpatch style issues

Ethan Tidmore
2026-03-26T18:09:52Z

On Wed Mar 25, 2026 at 6:45 PM CDT, MrXploisLite wrote:
> Fix minor style issues in hal_com.c reported by checkpatch:
> - Remove multiple blank lines
> - Remove blank line after open brace
> - Fix comparison style (constant on right side)
>
> No functional changes, only coding style fixes.
>
> Signed-off-by: MrXploisLite <arokigaming@gmail.com>
> ---

You need to use your real name when submitting patches. Also, don't use
the name of the tool in your subject, it should be something like
"Remove unneeded blank lines".

...

> - if (0xFF == hw_channel_plan)
> + if (hw_channel_plan == 0xFF)
> AutoLoadFail = true;

Please keep one logical change per patch. The removal of blank lines and
correcting comparison orientation are two different changes.

Use "$ ./scripts/checkpatch.pl --strict <patch>" too before sending
patches off, it helps catch a lot of easy mistakes.

Thanks,

ET