From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CEBD30BF52 for ; Sun, 29 Mar 2026 23:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774828290; cv=none; b=iiG2sRrN8CnvYjtLaK0/AztoaBTPet/X7HVsqIovcoOp10LXa3TrvN8tgbuLvNbpSscdiSJ5mr0/9WDcO85GDXNbKzQDMcfvZ1cFNngKl09XoW2w3I+rLpF79fAtglcnRketWmzKU1kmDU+mOJq3ikVgF732xYTJI5A30AJENYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774828290; c=relaxed/simple; bh=YpMpuTZzOavO2FWVi3lBdct+RU887btYzppVB9m2k5k=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=fUmKhafI97Drm7UtHzbTQ0SD9oHVjXNVdpTsbn836s2swX5p1WKdHftIIppGNOMLDGawG9vG7QZtGO5YZ9mVkFnRnu1DVdSGmsYwEu6cGhf+KoZaMmdbvyvN3AXhL3oqmpWMpmsWPkokFE24zQ4GTgysTnxerr9vBOxPupDHuYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NZwb0LzW; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZwb0LzW" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-64937edbc9eso3960000d50.2 for ; Sun, 29 Mar 2026 16:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774828288; x=1775433088; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GqnS1YXyhha9tTC/Bm/LiCWocUSVBx6brOljirdp18M=; b=NZwb0LzWd58ZHUJnSZk56OfYn45FbND5UmbP2qvAHQqG6wnJoJkun7A3JaUhyMy+jJ 6vv0AW6H9gbVutbbjp1a6x7Yq5WWlWp9hbxoGJnqShxVDF9jP5hAx8vwX+pM4Vz3MEqj kjND8QX54Hd1CklDzJSsm2SCVY4ZytNM420Cjdhhvw1jLYCUwrP16zVjwj1/dRDxpXbM ytmS7BamFS2ut8BQNjEHkCtV8xZCOGdz6Ve3W4W4R/3fV458vIpvFbwLL7S501K3OQ6+ vzOpQeDbCxDPceI16SxHKIEOecA1/ziwgBrVjva01WBtYj9EqmxvIXarZ6gu5gTwOsNf xjVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774828288; x=1775433088; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GqnS1YXyhha9tTC/Bm/LiCWocUSVBx6brOljirdp18M=; b=Qn4+Z62P7w97Ch6fpQUqax+4726FmJ8qBxqbSnn/v98Mm1U68PgRZLEQ0SA8+VnsNe D8pBixkrxlW0aRojIvqrzrZx0gSM1u2B1UoDkcohuwag3SdwrlSJxQpFh7m8n0sthCrM ML6dOMPt/sVp4UEQ9YaMdqLEySqPCr9iRoTGqPxw/WHmbF0KVavvf88xaZzVc0cbpEDp yozsQEbC7pFEm7riYVsHuLpjWml09dmNpWc2ZAa4OPJKd91OLgMc5yl6XTHpwYhZIy2R mSCH/RYNo1Jsr606GELw1kXeYmKhds9EulG1mKeLdyE5M+DBIfy0O+z9we0vRTUBVchc Z0sg== X-Forwarded-Encrypted: i=1; AJvYcCXj6KroipeOKBjnXXvPz5mTfjmyUyNrbxFz9m2RNG+d+ELUwNcgN+Bi2oysw6B24/QIcxxl7f+88r43p/4=@vger.kernel.org X-Gm-Message-State: AOJu0YyOi3sEPG8dm/VoYDnLklmaY28S0DOICkSrbCv+BFWLsDbKP4uq A3uIhPsWQtZt77RmfhDaqDhDcB5s9Src0Y5L/ImDKV8TZpU+xFHNUC2S X-Gm-Gg: ATEYQzzCwm6VESuBPq6OmEmirXdhEmsWeBS75hevaBWEK4nn/xGSy6Ye9Pben2GWFIf 0g9MOazrbGO4Uufg9K7j8EVOZBcIy+be/KEjbD4yu0AAG4G7De/RYwQkJn0Xid+wxwgPNop9z+S 3V8niDrAxyQ9UwfQ70QP0F0sg4XiZU3ZRH9hzJdJa4fDTxUcQV6FOK+9Z36rLbDQmU40oDmg3ne gH3QYOKgfrTAhMXyTg+AlaK27+B073CQovJe5aiB1M25mPky/keFayUC119Ofl+QtwWgAGF10ZZ wX7qLA3MQr8O1GhvvUfwvnwL/hQv6bAHsiBlqRUOQdPZhNH1duXh6Tnha0BER7GQfX/r54Ko3L/ 2bux9fJXekAqAUkHYuKYwI4xi+KoIWgrNDkiiMiScFvy3MwzgU0Hv2NNZNQbM0pJKMFGnoiFUwN +LTgOej3JDFNa0nnMEDOUGZbj51CukTZMMBSo2npbud0gqjXGWWA1NT+zXJevU2AuIDdFsEiUw4 z+O0/AIURoKN5AR/aZJOq+FYRUGksutOGIWia58ODc= X-Received: by 2002:a05:690c:e4ed:b0:79b:d341:5711 with SMTP id 00721157ae682-79bddd29933mr98062087b3.24.1774828288285; Sun, 29 Mar 2026 16:51:28 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79cba46f3ccsm27551797b3.40.2026.03.29.16.51.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2026 16:51:27 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 29 Mar 2026 18:51:18 -0500 Message-Id: Subject: Re: [PATCH] staging: rtl8723bs: rename variables to snake_case From: "Ethan Tidmore" To: , "Greg Kroah-Hartman" Cc: "Michael Straube" , "Andy Shevchenko" , "Ethan Tidmore" , "Dan Carpenter" , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260327203636.24891-1-david@cardinalsystem.net> In-Reply-To: <20260327203636.24891-1-david@cardinalsystem.net> On Fri Mar 27, 2026 at 3:36 PM CDT, david wrote: > From: David Holland > > The Linux kernel coding style guidelines prohibit the use of CamelCase > variable names. All variables should be snakecase. > > Rename the 'ChipVersion' parameter to 'chip_version' and the > 'AutoLoadFail' parameter to 'auto_load_fail' in hal_com.c to adhere to > the standard snakecase naming convention. > > Signed-off-by: David Holland > --- ... > =20 > @@ -86,7 +86,7 @@ void dump_chip_info(struct hal_version ChipVersion) > * BIT[6:0] Channel Plan > *sw_channel_plan channel plan from SW (registry/module param) > *def_channel_plan channel plan used when HW/SW both invalid > - *AutoLoadFail efuse autoload fail or not > + *auto_load_fail efuse autoload fail or not I think the whitespace here was intentional (although I can't tell why they did it like this), originally the comments starting with channel and efuse lined up and this changes it. Thanks, ET